From: Paul Durrant <xadimgnik@gmail.com>
To: David Woodhouse <dwmw2@infradead.org>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Paul Durrant <pdurrant@amazon.com>,
Sean Christopherson <seanjc@google.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org
Subject: Re: [PATCH v5 06/10] KVM: xen: allow shared_info to be mapped by fixed HVA
Date: Tue, 26 Sep 2023 10:22:07 +0100 [thread overview]
Message-ID: <5b448307-19f3-4d69-b7f4-3ebedcff030a@xen.org> (raw)
In-Reply-To: <0bd42244f232ecc24cbbd2750196758bf7944293.camel@infradead.org>
On 23/09/2023 08:07, David Woodhouse wrote:
> On Fri, 2023-09-22 at 15:00 +0000, Paul Durrant wrote:
>> From: Paul Durrant <pdurrant@amazon.com>
>>
>> The shared_info page is not guest memory as such. It is a dedicated page
>> allocated by the VMM and overlaid onto guest memory in a GFN chosen by the
>> guest. The guest may even request that shared_info be moved from one GFN
>> to another, but the HVA is never going to change. Thus it makes much more
>> sense to map the shared_info page in kernel once using this fixed HVA.
>
> The words "makes much more sense" are doing a *lot* of work there. :)
>
> When heckling the cover letter in
> https://lore.kernel.org/kvm/d13e459e221f28fb1865eedea023e583a2277ab1.camel@infradead.org/
> I suggested that the explanation probably wants to make it into a
> commit message rather than just the cover letter which tends not to be
> preserved in the commit history. It's *this* commit which needs it, I
> think.
Ok, I'll try to come up with some concise wording.
Paul
next prev parent reply other threads:[~2023-09-26 9:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 14:59 [PATCH v5 00/10] KVM: xen: update shared_info and vcpu_info handling Paul Durrant
2023-09-22 15:00 ` [PATCH v5 01/10] KVM: pfncache: add a map helper function Paul Durrant
2023-09-22 15:00 ` [PATCH v5 02/10] KVM: pfncache: add a mark-dirty helper Paul Durrant
2023-09-22 15:00 ` [PATCH v5 03/10] KVM: pfncache: add a helper to get the gpa Paul Durrant
2023-09-22 15:00 ` [PATCH v5 04/10] KVM: pfncache: base offset check on khva rather than gpa Paul Durrant
2023-09-22 15:00 ` [PATCH v5 05/10] KVM: pfncache: allow a cache to be activated with a fixed (userspace) HVA Paul Durrant
2023-09-22 15:00 ` [PATCH v5 06/10] KVM: xen: allow shared_info to be mapped by fixed HVA Paul Durrant
2023-09-23 7:07 ` David Woodhouse
2023-09-26 9:22 ` Paul Durrant [this message]
2023-09-22 15:00 ` [PATCH v5 07/10] KVM: xen: allow vcpu_info " Paul Durrant
2023-09-22 15:44 ` David Woodhouse
2023-09-22 15:49 ` Paul Durrant
2023-09-22 15:52 ` David Woodhouse
2023-09-22 16:10 ` David Woodhouse
2023-09-22 15:00 ` [PATCH v5 08/10] KVM: selftests / xen: map shared_info using HVA rather than GFN Paul Durrant
2023-09-22 15:00 ` [PATCH v5 09/10] KVM: selftests / xen: re-map vcpu_info using HVA rather than GPA Paul Durrant
2023-09-22 16:11 ` David Woodhouse
2023-09-22 15:00 ` [PATCH v5 10/10] KVM: xen: advertize the KVM_XEN_HVM_CONFIG_SHARED_INFO_HVA capability Paul Durrant
2023-09-22 15:37 ` [PATCH v5 00/10] KVM: xen: update shared_info and vcpu_info handling David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5b448307-19f3-4d69-b7f4-3ebedcff030a@xen.org \
--to=xadimgnik@gmail.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=pdurrant@amazon.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®