[PATCH 1/1] MAINTAINERS: Add entry for Whiskey Cove PMIC GPIO driver

[PATCH 1/1] MAINTAINERS: Add entry for Whiskey Cove PMIC GPIO driver

[sathyanarayanan.kuppuswamy]

From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>

Added maintainer info for Whiskey Cove PMIC GPIO driver.

Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
---
 MAINTAINERS | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 09b5ab6..f76c349 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -13814,6 +13814,12 @@ F:	drivers/watchdog/
 F:	include/linux/watchdog.h
 F:	include/uapi/linux/watchdog.h
 
+WHISKEYCOVE PMIC GPIO DRIVER
+M:	Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
+L:	linux-gpio@vger.kernel.org
+S:	Maintained
+F:	drivers/gpio/gpio-wcove.c
+
 WIIMOTE HID DRIVER
 M:	David Herrmann <dh.herrmann@googlemail.com>
 L:	linux-input@vger.kernel.org
-- 
2.7.4

Re: [PATCH 1/1] MAINTAINERS: Add entry for Whiskey Cove PMIC GPIO driver

[Andy Shevchenko]

On Fri, Jun 30, 2017 at 10:20 PM,
<sathyanarayanan.kuppuswamy@linux.intel.com> wrote:
> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>

> +F:     drivers/gpio/gpio-wcove.c

If we are going to rename (which I personally consider as a good
idea), this should follow it, and not otherwise.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 1/1] MAINTAINERS: Add entry for Whiskey Cove PMIC GPIO driver

[sathyanarayanan kuppuswamy]

Hi Andy,


On 06/30/2017 01:51 PM, Andy Shevchenko wrote:
> If we are going to rename (which I personally consider as a good
> idea), this should follow it, and not otherwise.
I am having second thoughts about the rename. After going through the 
spec documents, I found that there are two main differences between CHT 
and BXT PMIC GPIO controllers.

1. BXT variant has 3 GPIO banks where as CHT variant has only 2 GPIO banks.
2. GPIO I/O control register and IRQ register mapping addresses are 
different in both BXT and CHT variants.

Given above differences, I think we have a choice to use the current 
driver and pass the above data difference to driver via .driver_data or 
platform_data. This is a bit messy method because we are not getting the 
register address or info about number of gpio banks from BIOS.

Other solution is to rename the existing driver to gpio-bxt-wcove.c and 
create a new one for CHT (if required).

Let me know your comments.

-- 
Sathyanarayanan Kuppuswamy
Linux kernel developer

Re: [PATCH 1/1] MAINTAINERS: Add entry for Whiskey Cove PMIC GPIO driver

[Linus Walleij]

On Fri, Jun 30, 2017 at 9:20 PM,
<sathyanarayanan.kuppuswamy@linux.intel.com> wrote:

> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>
> Added maintainer info for Whiskey Cove PMIC GPIO driver.
>
> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>

Patch applied.

Yours,
Linus Walleij