mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Petar Stoykov <pd.pstoykov@gmail.com>
Cc: linux-iio@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: iio: pressure: Add Sensirion SDP500
Date: Thu, 4 Jul 2024 11:47:28 +0200	[thread overview]
Message-ID: <38979dfa-ba9d-497b-b0c9-2ab7d79e1251@linaro.org> (raw)
In-Reply-To: <CADFWO8GWZzwuV_CSue9_GcBre2OdY4uBs8CiCtUePy4PW9BCuw@mail.gmail.com>

On 04/07/2024 10:18, Petar Stoykov wrote:
> On Tue, Jul 2, 2024 at 5:15 PM Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 02/07/2024 16:59, Petar Stoykov via B4 Relay wrote:
>>> From: Petar Stoykov <pd.pstoykov@gmail.com>
>>>
>>> Sensirion SDP500 is a digital differential pressure sensor. It provides
>>> a digital I2C output. Add devicetree bindings requiring the compatible
>>> string and I2C slave address (reg).
>>>
>>
>> You did not test your code before sending.
> 
> I tested the driver for sdp500 on our system and it worked well.
> I must admit that I forgot to change the dts to sdp510 and retest.
> 
>>
>> Please respond to existing feedback from v1 and v2, thus confirm that
>> you understood it and you are or are not going to implement it.
>>
> 
> I tried to reply to all previous comments. Sorry if I missed something.
> 
>> It does not look like you tested the bindings, at least after quick
>> look. Please run `make dt_binding_check` (see
>> Documentation/devicetree/bindings/writing-schema.rst for instructions).
>> Maybe you need to update your dtschema and yamllint.
> 
> I didn't know about that dt_binding_check. Then I spent a few hours
> yesterday fighting with dependencies to get it running.

It's just one command:
pipx install dtschema yamllint
(or pip, depending on your system)

Best regards,
Krzysztof


  reply	other threads:[~2024-07-04  9:47 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-02 14:59 [PATCH v3 0/3] Add support for " Petar Stoykov via B4 Relay
2024-07-02 14:59 ` [PATCH v3 1/3] dt-bindings: iio: pressure: Add " Petar Stoykov via B4 Relay
2024-07-02 15:15   ` Krzysztof Kozlowski
2024-07-04  8:18     ` Petar Stoykov
2024-07-04  9:47       ` Krzysztof Kozlowski [this message]
2024-07-02 16:30   ` Rob Herring (Arm)
2024-07-04  8:38     ` Petar Stoykov
2024-07-02 20:18   ` Jonathan Cameron
2024-07-04  8:35     ` Petar Stoykov
2024-07-07 15:30       ` Jonathan Cameron
2024-07-02 14:59 ` [PATCH v3 2/3] iio: pressure: Add driver for " Petar Stoykov via B4 Relay
2024-07-02 15:17   ` Krzysztof Kozlowski
2024-07-04  7:49     ` Petar Stoykov
2024-07-04  9:49       ` Krzysztof Kozlowski
2024-07-02 20:16   ` Jonathan Cameron
2024-07-04  8:09     ` Petar Stoykov
2024-07-07 15:34       ` Jonathan Cameron
2024-08-09 15:28   ` Andy Shevchenko
2024-07-02 14:59 ` [PATCH v3 3/3] MAINTAINERS: Add " Petar Stoykov via B4 Relay
2024-07-02 15:15   ` Krzysztof Kozlowski
2024-07-04  7:39     ` Petar Stoykov
2024-07-02 17:55   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=38979dfa-ba9d-497b-b0c9-2ab7d79e1251@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pd.pstoykov@gmail.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®