From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: pd.pstoykov@gmail.com
Cc: linux-iio@vger.kernel.org, Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] iio: pressure: Add driver for Sensirion SDP500
Date: Fri, 9 Aug 2024 18:28:51 +0300 [thread overview]
Message-ID: <ZrY1s5fYdC3hMxjj@smile.fi.intel.com> (raw)
In-Reply-To: <20240702-mainline_sdp500-v3-2-0902047b3eee@gmail.com>
On Tue, Jul 02, 2024 at 04:59:09PM +0200, Petar Stoykov via B4 Relay wrote:
> From: Petar Stoykov <pd.pstoykov@gmail.com>
>
> Sensirion SDP500 is a digital differential pressure sensor. The sensor is
> accessed over I2C.
...
+ array_size.h
+ bits.h
+ dev_printk.h
+ errno.h
> +#include <linux/i2c.h>
> +#include <linux/crc8.h>
> +#include <linux/iio/iio.h>
+ mod_devicetable.h
+ module.h
> +#include <linux/regulator/consumer.h>
+ types.h
Keep them ordered, also you may split iio/ group out
> +#include <asm/unaligned.h>
linux/*
...blank line...
asm/*
...blank line...
iio/*
...
> +struct sdp500_data {
> + struct device *dev;
> +};
Why is this structure needed at all? You may put dev pointer directly, no?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-08-09 15:28 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-02 14:59 [PATCH v3 0/3] Add support " Petar Stoykov via B4 Relay
2024-07-02 14:59 ` [PATCH v3 1/3] dt-bindings: iio: pressure: Add " Petar Stoykov via B4 Relay
2024-07-02 15:15 ` Krzysztof Kozlowski
2024-07-04 8:18 ` Petar Stoykov
2024-07-04 9:47 ` Krzysztof Kozlowski
2024-07-02 16:30 ` Rob Herring (Arm)
2024-07-04 8:38 ` Petar Stoykov
2024-07-02 20:18 ` Jonathan Cameron
2024-07-04 8:35 ` Petar Stoykov
2024-07-07 15:30 ` Jonathan Cameron
2024-07-02 14:59 ` [PATCH v3 2/3] iio: pressure: Add driver for " Petar Stoykov via B4 Relay
2024-07-02 15:17 ` Krzysztof Kozlowski
2024-07-04 7:49 ` Petar Stoykov
2024-07-04 9:49 ` Krzysztof Kozlowski
2024-07-02 20:16 ` Jonathan Cameron
2024-07-04 8:09 ` Petar Stoykov
2024-07-07 15:34 ` Jonathan Cameron
2024-08-09 15:28 ` Andy Shevchenko [this message]
2024-07-02 14:59 ` [PATCH v3 3/3] MAINTAINERS: Add " Petar Stoykov via B4 Relay
2024-07-02 15:15 ` Krzysztof Kozlowski
2024-07-04 7:39 ` Petar Stoykov
2024-07-02 17:55 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZrY1s5fYdC3hMxjj@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pd.pstoykov@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®