* [PATCH] gpu: nova-core: restore the "Probe Nova Core GPU driver" debug print
@ 2026-09-29 20:43 John Hubbard
2026-09-29 20:50 ` Danilo Krummrich
0 siblings, 1 reply; 3+ messages in thread
From: John Hubbard @ 2026-09-29 20:43 UTC (permalink / raw)
To: Danilo Krummrich, Alexandre Courbot
Cc: Timur Tabi, Alistair Popple, Eliot Courtney, Zhi Wang,
David Airlie, Simona Vetter, Bjorn Helgaas, Miguel Ojeda,
Alex Gaynor, Boqun Feng, Gary Guo, Björn Roy Baron,
Benno Lossin, Andreas Hindborg, Alice Ryhl, Trevor Gross,
nova-gpu, LKML, John Hubbard
This is a high value thing to print, because it acts as kind of a
bookend, showing the beginning of trying to boot up.
Cc: Danilo Krummrich <dakr@kernel.org>
Fixes: 658c5f0042e6 ("gpu: nova-core: use a single try_pin_init!() block in probe()")"
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---
drivers/gpu/nova-core/driver.rs | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/nova-core/driver.rs b/drivers/gpu/nova-core/driver.rs
index 291a047e4d86..96f2638d6400 100644
--- a/drivers/gpu/nova-core/driver.rs
+++ b/drivers/gpu/nova-core/driver.rs
@@ -102,6 +102,8 @@ fn probe<'bound>(
) -> impl PinInit<Self::Data<'bound>, Error> + 'bound {
try_pin_init!(NovaCore {
_: {
+ dev_dbg!(pdev, "Probe Nova Core GPU driver.\n");
+
pdev.enable_device_mem()?;
pdev.set_master();
},
base-commit: 658c5f0042e6e897338dd04330a363aa7022c85d
--
2.55.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpu: nova-core: restore the "Probe Nova Core GPU driver" debug print
2026-09-29 20:43 [PATCH] gpu: nova-core: restore the "Probe Nova Core GPU driver" debug print John Hubbard
@ 2026-09-29 20:50 ` Danilo Krummrich
2026-09-29 20:51 ` John Hubbard
0 siblings, 1 reply; 3+ messages in thread
From: Danilo Krummrich @ 2026-09-29 20:50 UTC (permalink / raw)
To: John Hubbard
Cc: Alexandre Courbot, Timur Tabi, Alistair Popple, Eliot Courtney,
Zhi Wang, David Airlie, Simona Vetter, Bjorn Helgaas,
Miguel Ojeda, Alex Gaynor, Boqun Feng, Gary Guo,
Björn Roy Baron, Benno Lossin, Andreas Hindborg, Alice Ryhl,
Trevor Gross, nova-gpu, LKML
On Tue Sep 29, 2026 at 10:43 PM CEST, John Hubbard wrote:
> This is a high value thing to print, because it acts as kind of a
> bookend, showing the beginning of trying to boot up.
>
> Cc: Danilo Krummrich <dakr@kernel.org>
> Fixes: 658c5f0042e6 ("gpu: nova-core: use a single try_pin_init!() block in probe()")"
> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
> ---
> drivers/gpu/nova-core/driver.rs | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/nova-core/driver.rs b/drivers/gpu/nova-core/driver.rs
> index 291a047e4d86..96f2638d6400 100644
> --- a/drivers/gpu/nova-core/driver.rs
> +++ b/drivers/gpu/nova-core/driver.rs
> @@ -102,6 +102,8 @@ fn probe<'bound>(
> ) -> impl PinInit<Self::Data<'bound>, Error> + 'bound {
> try_pin_init!(NovaCore {
> _: {
> + dev_dbg!(pdev, "Probe Nova Core GPU driver.\n");
I'd like to keep it outside of this block, as it will transform into a field
storing a pci::DeviceEnableGuard soon.
Let's put it in its own _: {} block or before try_pin_init!().
> +
> pdev.enable_device_mem()?;
> pdev.set_master();
> },
>
> base-commit: 658c5f0042e6e897338dd04330a363aa7022c85d
> --
> 2.55.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpu: nova-core: restore the "Probe Nova Core GPU driver" debug print
2026-09-29 20:50 ` Danilo Krummrich
@ 2026-09-29 20:51 ` John Hubbard
0 siblings, 0 replies; 3+ messages in thread
From: John Hubbard @ 2026-09-29 20:51 UTC (permalink / raw)
To: Danilo Krummrich
Cc: Alexandre Courbot, Timur Tabi, Alistair Popple, Eliot Courtney,
Zhi Wang, David Airlie, Simona Vetter, Bjorn Helgaas,
Miguel Ojeda, Alex Gaynor, Boqun Feng, Gary Guo,
Björn Roy Baron, Benno Lossin, Andreas Hindborg, Alice Ryhl,
Trevor Gross, nova-gpu, LKML
On 9/29/26 1:50 PM, Danilo Krummrich wrote:
> On Tue Sep 29, 2026 at 10:43 PM CEST, John Hubbard wrote:
>> This is a high value thing to print, because it acts as kind of a
>> bookend, showing the beginning of trying to boot up.
>>
>> Cc: Danilo Krummrich <dakr@kernel.org>
>> Fixes: 658c5f0042e6 ("gpu: nova-core: use a single try_pin_init!() block in probe()")"
>> Signed-off-by: John Hubbard <jhubbard@nvidia.com>
>> ---
>> drivers/gpu/nova-core/driver.rs | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/nova-core/driver.rs b/drivers/gpu/nova-core/driver.rs
>> index 291a047e4d86..96f2638d6400 100644
>> --- a/drivers/gpu/nova-core/driver.rs
>> +++ b/drivers/gpu/nova-core/driver.rs
>> @@ -102,6 +102,8 @@ fn probe<'bound>(
>> ) -> impl PinInit<Self::Data<'bound>, Error> + 'bound {
>> try_pin_init!(NovaCore {
>> _: {
>> + dev_dbg!(pdev, "Probe Nova Core GPU driver.\n");
>
>
> I'd like to keep it outside of this block, as it will transform into a field
> storing a pci::DeviceEnableGuard soon.
>
> Let's put it in its own _: {} block or before try_pin_init!().
OK, will do.
>
>> +
>> pdev.enable_device_mem()?;
>> pdev.set_master();
>> },
>>
>> base-commit: 658c5f0042e6e897338dd04330a363aa7022c85d
>> --
>> 2.55.0
>
thanks,
--
John Hubbard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-09-29 20:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-29 20:43 [PATCH] gpu: nova-core: restore the "Probe Nova Core GPU driver" debug print John Hubbard
2026-09-29 20:50 ` Danilo Krummrich
2026-09-29 20:51 ` John Hubbard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®