From: Nick Piggin <piggin@cyberone.com.au>
To: Andrew Morton <akpm@osdl.org>
Cc: Con Kolivas <kernel@kolivas.org>,
linux-kernel@vger.kernel.org, mingo@elte.hu, mbligh@aracnet.com
Subject: Re: [PATCH] Fix find busiest queue 2.6.0-test9
Date: Sun, 09 Nov 2003 10:42:53 +1100 [thread overview]
Message-ID: <3FAD7F7D.2020003@cyberone.com.au> (raw)
In-Reply-To: <20031108145840.52fed740.akpm@osdl.org>
Andrew Morton wrote:
>Con Kolivas <kernel@kolivas.org> wrote:
>
>>Hi
>>
>>I believe this is a simple typo / variable name mixup between rq_src and
>>this_rq. So far all testing shows positive (if minor) improvements.
>>
>>
>
>Looks right to me. I'll queue this up for the 2.6.1 deluge.
>
prev_cpu_load[i] is nr_running of cpu i last time this operation was
performed. Either it, or the current nr_running is taken, whichever
is lower.
I guess its done this way for cache benefits, but it was correct as
Ingo intended. For example, with Con's patch you can see
rq_src->prev_cpu_load[i] will only ever use the ith position in the array.
I wonder what improvements Con is seeing? If they are significant, change
prev_cpu_load to be an integer type and do a similar thing here.
next prev parent reply other threads:[~2003-11-08 23:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-08 16:49 Con Kolivas
2003-11-08 22:41 ` Nick Piggin
2003-11-08 22:58 ` Andrew Morton
2003-11-08 23:42 ` Nick Piggin [this message]
2003-11-09 0:44 ` Davide Libenzi
2003-11-09 15:34 ` Martin J. Bligh
2003-11-09 15:53 ` Davide Libenzi
2003-11-09 15:58 ` Martin J. Bligh
2003-11-09 16:05 ` Davide Libenzi
2003-11-09 16:07 ` Con Kolivas
2003-11-09 17:10 ` Martin J. Bligh
2003-11-10 0:59 ` Nick Piggin
2003-11-10 7:46 ` Ingo Molnar
2003-11-09 15:59 ` Con Kolivas
2003-11-09 16:48 ` Martin J. Bligh
2003-11-09 17:27 ` Davide Libenzi
2003-11-09 20:39 ` Martin J. Bligh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3FAD7F7D.2020003@cyberone.com.au \
--to=piggin@cyberone.com.au \
--cc=akpm@osdl.org \
--cc=kernel@kolivas.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@aracnet.com \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®