From: Ingo Molnar <mingo@elte.hu>
To: Davide Libenzi <davidel@xmailserver.org>
Cc: "Martin J. Bligh" <mbligh@aracnet.com>,
Nick Piggin <piggin@cyberone.com.au>,
Andrew Morton <akpm@osdl.org>, Con Kolivas <kernel@kolivas.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fix find busiest queue 2.6.0-test9
Date: Mon, 10 Nov 2003 08:46:19 +0100 (CET) [thread overview]
Message-ID: <Pine.LNX.4.56.0311100841290.2914@earth> (raw)
In-Reply-To: <Pine.LNX.4.44.0311090801130.12198-100000@bigblue.dev.mdolabs.com>
On Sun, 9 Nov 2003, Davide Libenzi wrote:
> Maybe something like:
>
> * We fend off statistical fluctuations in runqueue lengths by
> * saving the runqueue length (as seen by the balancing CPU) during the
> * previous load-balancing operation and using the smaller one the current
> * and saved lengths.
yep, agreed - patch for 2.6.1 attached. (I also fixed a typo in the
original comment and reformatted the lines) Anything else?
Ingo
--- kernel/sched.c.orig
+++ kernel/sched.c
@@ -1061,10 +1061,11 @@
* the lock held.
*
* We fend off statistical fluctuations in runqueue lengths by
- * saving the runqueue length during the previous load-balancing
- * operation and using the smaller one the current and saved lengths.
- * If a runqueue is long enough for a longer amount of time then
- * we recognize it and pull tasks from it.
+ * saving the runqueue length (as seen by the balancing CPU) during
+ * the previous load-balancing operation and using the smaller one
+ * of the current and saved lengths. If a runqueue is long enough
+ * for a longer amount of time then we recognize it and pull tasks
+ * from it.
*
* The 'current runqueue length' is a statistical maximum variable,
* for that one we take the longer one - to avoid fluctuations in
next prev parent reply other threads:[~2003-11-10 7:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-08 16:49 Con Kolivas
2003-11-08 22:41 ` Nick Piggin
2003-11-08 22:58 ` Andrew Morton
2003-11-08 23:42 ` Nick Piggin
2003-11-09 0:44 ` Davide Libenzi
2003-11-09 15:34 ` Martin J. Bligh
2003-11-09 15:53 ` Davide Libenzi
2003-11-09 15:58 ` Martin J. Bligh
2003-11-09 16:05 ` Davide Libenzi
2003-11-09 16:07 ` Con Kolivas
2003-11-09 17:10 ` Martin J. Bligh
2003-11-10 0:59 ` Nick Piggin
2003-11-10 7:46 ` Ingo Molnar [this message]
2003-11-09 15:59 ` Con Kolivas
2003-11-09 16:48 ` Martin J. Bligh
2003-11-09 17:27 ` Davide Libenzi
2003-11-09 20:39 ` Martin J. Bligh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.56.0311100841290.2914@earth \
--to=mingo@elte.hu \
--cc=akpm@osdl.org \
--cc=davidel@xmailserver.org \
--cc=kernel@kolivas.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@aracnet.com \
--cc=piggin@cyberone.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®