Re: [PATCH v2 2/5] dt-bindings: clock: qcom: Add Qualcomm Shikra Display clock controller

[Imran Shaik <imran.shaik@oss.qualcomm.com>]

On 29-05-2026 05:03 pm, Dmitry Baryshkov wrote:
> On Fri, May 29, 2026 at 02:53:29PM +0530, Imran Shaik wrote:
>>
>>
>> On 28-05-2026 07:14 pm, Dmitry Baryshkov wrote:
>>> On Thu, May 28, 2026 at 03:37:03PM +0530, Imran Shaik wrote:
>>>> The Qualcomm Shikra Display clock controller reuses the QCM2290 DISPCC,
>>>> but has minor differences with the number of input clocks. Update the
>>>> existing QCM2290 DISPCC bindings using conditional schema so that the
>>>> QCM2290 requirements remain unchanged while accommodating the additional
>>>> clocks required for Shikra.
>>>
>>> According to the IPcat, display clock controller also has (unused)
>>> inputs for the DSI1. Please extend the ABI for Agatti, then extend add
>>> Shikra.
>>>
>>
>> Sure, will add the DSI1 to Agatti as well. Since we are extending the ABI
>> for Agatti, I will remove the clock-names from the bindings
> 
> Why?
> 
>> and update the
>> DISPCC driver to use the indices-based approach instead.
>>
>> With these updates, the bindings, driver, and Agatti DT must be picked
>> together to avoid any functional issues or ABI breakage. I will explicitly
>> document these details in the commit message in the next series.
> 
> Well, no. DT comes through a separate tree anyway. Be sure that the
> updated driver works with the old DT. Also make sure to not change the
> order of the clocks, you can't break the ABI.
> 

Sure, I’ll keep the clock-names property and only append new clocks at 
the end without changing the current order.

Thanks,
Imran