From: Imran Shaik <imran.shaik@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Loic Poulain <loic.poulain@oss.qualcomm.com>,
Ajit Pandey <ajit.pandey@oss.qualcomm.com>,
Taniya Das <taniya.das@oss.qualcomm.com>,
Jagadeesh Kona <jagadeesh.kona@oss.qualcomm.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/5] clk: qcom: Add support for Qualcomm GPU Clock Controller on Shikra
Date: Fri, 29 May 2026 14:54:40 +0530 [thread overview]
Message-ID: <95c74b63-2155-4118-9c99-da483ade3203@oss.qualcomm.com> (raw)
In-Reply-To: <mnbrfojxfu7acedzvaxv3wpkcv6u4fhfoc5lh7xv24spm7juvo@srxwa6rnpje2>
On 28-05-2026 07:16 pm, Dmitry Baryshkov wrote:
> On Thu, May 28, 2026 at 03:37:06PM +0530, Imran Shaik wrote:
>> The Qualcomm Shikra GPU clock controller is similar to QCM2290 GPUCC
>> hardware block, with minor differences. Drop modelling of critical
>> clocks and keep them enabled at probe time, update the QCM2290 GPUCC
>> driver to align with the latest common qcom_cc_probe() model. Update the
>> GDSC *_wait_val and flags which are applicable for both QCM2290 and Shikra.
>
> There are a lot of separate, unrelated changes. Split your patches (not
> only this one) following the 'atomic logical changes' approach.
>
Sure, will split the patches in next series.
Thanks,
Imran
>> Signed-off-by: Imran Shaik <imran.shaik@oss.qualcomm.com>
>> ---
>> drivers/clk/qcom/gpucc-qcm2290.c | 174 +++++++++++++++++----------------------
>> 1 file changed, 74 insertions(+), 100 deletions(-)
>>
prev parent reply other threads:[~2026-05-29 9:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-28 10:07 [PATCH v2 0/5] clk: qcom: Add DISPCC and GPUCC support for the Qualcomm Shikra SoC Imran Shaik
2026-05-28 10:07 ` [PATCH v2 1/5] clk: qcom: gcc-qcm2290: Drop modelling of critical clocks Imran Shaik
2026-05-28 13:22 ` Dmitry Baryshkov
2026-05-29 9:22 ` Imran Shaik
2026-05-29 11:31 ` Dmitry Baryshkov
2026-05-28 10:07 ` [PATCH v2 2/5] dt-bindings: clock: qcom: Add Qualcomm Shikra Display clock controller Imran Shaik
2026-05-28 13:44 ` Dmitry Baryshkov
2026-05-29 9:23 ` Imran Shaik
2026-05-29 11:33 ` Dmitry Baryshkov
2026-06-01 3:05 ` Imran Shaik
2026-05-30 11:33 ` Krzysztof Kozlowski
2026-05-28 10:07 ` [PATCH v2 3/5] dt-bindings: clock: qcom: Add Qualcomm Shikra GPU " Imran Shaik
2026-05-28 10:07 ` [PATCH v2 4/5] clk: qcom: dispcc-qcm2290: Add support for Qualcomm Shikra DISPCC Imran Shaik
2026-05-28 13:42 ` Dmitry Baryshkov
2026-05-29 9:23 ` Imran Shaik
2026-05-29 11:34 ` Dmitry Baryshkov
2026-06-01 3:36 ` Imran Shaik
2026-05-28 10:07 ` [PATCH v2 5/5] clk: qcom: Add support for Qualcomm GPU Clock Controller on Shikra Imran Shaik
2026-05-28 13:46 ` Dmitry Baryshkov
2026-05-29 9:24 ` Imran Shaik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95c74b63-2155-4118-9c99-da483ade3203@oss.qualcomm.com \
--to=imran.shaik@oss.qualcomm.com \
--cc=ajit.pandey@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=jagadeesh.kona@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=mturquette@baylibre.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=taniya.das@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®