* [PATCH v2] cpupowerutils: bench - Fix cpu online check
@ 2017-11-07 9:47 Abhishek Goel
2017-11-07 9:50 ` Abhishek
2017-11-15 15:21 ` Shuah Khan
0 siblings, 2 replies; 4+ messages in thread
From: Abhishek Goel @ 2017-11-07 9:47 UTC (permalink / raw)
To: trenn, linux-pm, linux-kernel; +Cc: Abhishek Goel
cpupower_is_cpu_online was incorrectly checking for 0. This patch fixes
this by checking for 1 when the cpu is online.
Signed-off-by: Abhishek Goel <huntbag@linux.vnet.ibm.com>
---
v2: Commit message rephrased.
---
tools/power/cpupower/bench/system.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/power/cpupower/bench/system.c b/tools/power/cpupower/bench/system.c
index c25a74a..2bb3eef 100644
--- a/tools/power/cpupower/bench/system.c
+++ b/tools/power/cpupower/bench/system.c
@@ -61,7 +61,7 @@ int set_cpufreq_governor(char *governor, unsigned int cpu)
dprintf("set %s as cpufreq governor\n", governor);
- if (cpupower_is_cpu_online(cpu) != 0) {
+ if (cpupower_is_cpu_online(cpu) != 1) {
perror("cpufreq_cpu_exists");
fprintf(stderr, "error: cpu %u does not exist\n", cpu);
return -1;
--
2.9.3
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] cpupowerutils: bench - Fix cpu online check
2017-11-07 9:47 [PATCH v2] cpupowerutils: bench - Fix cpu online check Abhishek Goel
@ 2017-11-07 9:50 ` Abhishek
2017-11-07 18:36 ` Shuah Khan
2017-11-15 15:21 ` Shuah Khan
1 sibling, 1 reply; 4+ messages in thread
From: Abhishek @ 2017-11-07 9:50 UTC (permalink / raw)
To: Shuah Khan, Shuah Khan, Thomas Renninger, linux-pm, linux-kernel
Hi,
Can you please have a look at this also?
Thanks and Regards,
Abhishek Goel
System Engineer
IBM India Pvt. Ltd.
On 11/07/2017 03:17 PM, Abhishek Goel wrote:
> cpupower_is_cpu_online was incorrectly checking for 0. This patch fixes
> this by checking for 1 when the cpu is online.
>
> Signed-off-by: Abhishek Goel <huntbag@linux.vnet.ibm.com>
> ---
> v2: Commit message rephrased.
> ---
> tools/power/cpupower/bench/system.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/power/cpupower/bench/system.c b/tools/power/cpupower/bench/system.c
> index c25a74a..2bb3eef 100644
> --- a/tools/power/cpupower/bench/system.c
> +++ b/tools/power/cpupower/bench/system.c
> @@ -61,7 +61,7 @@ int set_cpufreq_governor(char *governor, unsigned int cpu)
>
> dprintf("set %s as cpufreq governor\n", governor);
>
> - if (cpupower_is_cpu_online(cpu) != 0) {
> + if (cpupower_is_cpu_online(cpu) != 1) {
> perror("cpufreq_cpu_exists");
> fprintf(stderr, "error: cpu %u does not exist\n", cpu);
> return -1;
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] cpupowerutils: bench - Fix cpu online check
2017-11-07 9:50 ` Abhishek
@ 2017-11-07 18:36 ` Shuah Khan
0 siblings, 0 replies; 4+ messages in thread
From: Shuah Khan @ 2017-11-07 18:36 UTC (permalink / raw)
To: Abhishek, Shuah Khan, Thomas Renninger, linux-pm, linux-kernel; +Cc: Shuah Khan
On 11/07/2017 02:50 AM, Abhishek wrote:
> Hi,
>
> Can you please have a look at this also?
>
> Thanks and Regards,
> Abhishek Goel
> System Engineer
> IBM India Pvt. Ltd.
>
Same comment on top posting.
> On 11/07/2017 03:17 PM, Abhishek Goel wrote:
>> cpupower_is_cpu_online was incorrectly checking for 0. This patch fixes
>> this by checking for 1 when the cpu is online.
>>
>> Signed-off-by: Abhishek Goel <huntbag@linux.vnet.ibm.com>
>> ---
>> v2: Commit message rephrased.
>> ---
>> tools/power/cpupower/bench/system.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/power/cpupower/bench/system.c b/tools/power/cpupower/bench/system.c
>> index c25a74a..2bb3eef 100644
>> --- a/tools/power/cpupower/bench/system.c
>> +++ b/tools/power/cpupower/bench/system.c
>> @@ -61,7 +61,7 @@ int set_cpufreq_governor(char *governor, unsigned int cpu)
>>
>> dprintf("set %s as cpufreq governor\n", governor);
>>
>> - if (cpupower_is_cpu_online(cpu) != 0) {
>> + if (cpupower_is_cpu_online(cpu) != 1) {
>> perror("cpufreq_cpu_exists");
>> fprintf(stderr, "error: cpu %u does not exist\n", cpu);
>> return -1;
>
Ths patch looks good to me. I still need it in my Inbox. Please send it
to me directly.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] cpupowerutils: bench - Fix cpu online check
2017-11-07 9:47 [PATCH v2] cpupowerutils: bench - Fix cpu online check Abhishek Goel
2017-11-07 9:50 ` Abhishek
@ 2017-11-15 15:21 ` Shuah Khan
1 sibling, 0 replies; 4+ messages in thread
From: Shuah Khan @ 2017-11-15 15:21 UTC (permalink / raw)
To: Abhishek Goel, trenn, linux-pm, linux-kernel, Shuah Khan, Shuah Khan
On 11/07/2017 02:47 AM, Abhishek Goel wrote:
> cpupower_is_cpu_online was incorrectly checking for 0. This patch fixes
> this by checking for 1 when the cpu is online.
>
> Signed-off-by: Abhishek Goel <huntbag@linux.vnet.ibm.com>
> ---
> v2: Commit message rephrased.
> ---
> tools/power/cpupower/bench/system.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/power/cpupower/bench/system.c b/tools/power/cpupower/bench/system.c
> index c25a74a..2bb3eef 100644
> --- a/tools/power/cpupower/bench/system.c
> +++ b/tools/power/cpupower/bench/system.c
> @@ -61,7 +61,7 @@ int set_cpufreq_governor(char *governor, unsigned int cpu)
>
> dprintf("set %s as cpufreq governor\n", governor);
>
> - if (cpupower_is_cpu_online(cpu) != 0) {
> + if (cpupower_is_cpu_online(cpu) != 1) {
> perror("cpufreq_cpu_exists");
> fprintf(stderr, "error: cpu %u does not exist\n", cpu);
> return -1;
>
Thanks. I will queue this up for 4.15-rc2
-- Shuah
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-15 15:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-11-07 9:47 [PATCH v2] cpupowerutils: bench - Fix cpu online check Abhishek Goel
2017-11-07 9:50 ` Abhishek
2017-11-07 18:36 ` Shuah Khan
2017-11-15 15:21 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®