[PATCH] thermal/drivers/generic-adc: Register thermal zones as hwmon sensors

[PATCH] thermal/drivers/generic-adc: Register thermal zones as hwmon sensors

[Chen-Yu Tsai]

Register thermal zones as hwmon sensors to let userspace read
temperatures using standard hwmon interface.

Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
 drivers/thermal/thermal-generic-adc.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/thermal/thermal-generic-adc.c b/drivers/thermal/thermal-generic-adc.c
index 017b0ce52122..e95dc354f192 100644
--- a/drivers/thermal/thermal-generic-adc.c
+++ b/drivers/thermal/thermal-generic-adc.c
@@ -13,6 +13,8 @@
 #include <linux/slab.h>
 #include <linux/thermal.h>
 
+#include "thermal_hwmon.h"
+
 struct gadc_thermal_info {
 	struct device *dev;
 	struct thermal_zone_device *tz_dev;
@@ -153,6 +155,12 @@ static int gadc_thermal_probe(struct platform_device *pdev)
 		return ret;
 	}
 
+	ret = devm_thermal_add_hwmon_sysfs(&pdev->dev, gti->tz_dev);
+	if (ret) {
+		dev_err(&pdev->dev, "Failed to add hwmon sysfs attributes\n");
+		return ret;
+	}
+
 	return 0;
 }
 
-- 
2.41.0.162.gfafddb0af9-goog

Re: [PATCH] thermal/drivers/generic-adc: Register thermal zones as hwmon sensors

[Daniel Lezcano]

On 13/06/2023 11:30, Chen-Yu Tsai wrote:
> Register thermal zones as hwmon sensors to let userspace read
> temperatures using standard hwmon interface.
> 
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
> ---
>   drivers/thermal/thermal-generic-adc.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/thermal/thermal-generic-adc.c b/drivers/thermal/thermal-generic-adc.c
> index 017b0ce52122..e95dc354f192 100644
> --- a/drivers/thermal/thermal-generic-adc.c
> +++ b/drivers/thermal/thermal-generic-adc.c
> @@ -13,6 +13,8 @@
>   #include <linux/slab.h>
>   #include <linux/thermal.h>
>   
> +#include "thermal_hwmon.h"
> +
>   struct gadc_thermal_info {
>   	struct device *dev;
>   	struct thermal_zone_device *tz_dev;
> @@ -153,6 +155,12 @@ static int gadc_thermal_probe(struct platform_device *pdev)
>   		return ret;
>   	}
>   
> +	ret = devm_thermal_add_hwmon_sysfs(&pdev->dev, gti->tz_dev);
> +	if (ret) {
> +		dev_err(&pdev->dev, "Failed to add hwmon sysfs attributes\n");
> +		return ret;
> +	}

Usually, if the hwmon registering fails this is not fatal.

> +
>   	return 0;
>   }
>   

-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

Re: [PATCH] thermal/drivers/generic-adc: Register thermal zones as hwmon sensors

[Chen-Yu Tsai]

On Tue, Jun 13, 2023 at 5:44 PM Daniel Lezcano
<daniel.lezcano@linaro.org> wrote:
>
> On 13/06/2023 11:30, Chen-Yu Tsai wrote:
> > Register thermal zones as hwmon sensors to let userspace read
> > temperatures using standard hwmon interface.
> >
> > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
> > ---
> >   drivers/thermal/thermal-generic-adc.c | 8 ++++++++
> >   1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/thermal/thermal-generic-adc.c b/drivers/thermal/thermal-generic-adc.c
> > index 017b0ce52122..e95dc354f192 100644
> > --- a/drivers/thermal/thermal-generic-adc.c
> > +++ b/drivers/thermal/thermal-generic-adc.c
> > @@ -13,6 +13,8 @@
> >   #include <linux/slab.h>
> >   #include <linux/thermal.h>
> >
> > +#include "thermal_hwmon.h"
> > +
> >   struct gadc_thermal_info {
> >       struct device *dev;
> >       struct thermal_zone_device *tz_dev;
> > @@ -153,6 +155,12 @@ static int gadc_thermal_probe(struct platform_device *pdev)
> >               return ret;
> >       }
> >
> > +     ret = devm_thermal_add_hwmon_sysfs(&pdev->dev, gti->tz_dev);
> > +     if (ret) {
> > +             dev_err(&pdev->dev, "Failed to add hwmon sysfs attributes\n");
> > +             return ret;
> > +     }
>
> Usually, if the hwmon registering fails this is not fatal.

Ack. I'll change it to dev_warn.

ChenYu