* [PATCH] thermal/drivers/generic-adc: Register thermal zones as hwmon sensors
@ 2023-06-13 9:30 Chen-Yu Tsai
2023-06-13 9:44 ` Daniel Lezcano
0 siblings, 1 reply; 3+ messages in thread
From: Chen-Yu Tsai @ 2023-06-13 9:30 UTC (permalink / raw)
To: Rafael J. Wysocki, Daniel Lezcano, Amit Kucheria, Zhang Rui
Cc: Chen-Yu Tsai, linux-pm, linux-kernel, AngeloGioacchino Del Regno
Register thermal zones as hwmon sensors to let userspace read
temperatures using standard hwmon interface.
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
drivers/thermal/thermal-generic-adc.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/thermal/thermal-generic-adc.c b/drivers/thermal/thermal-generic-adc.c
index 017b0ce52122..e95dc354f192 100644
--- a/drivers/thermal/thermal-generic-adc.c
+++ b/drivers/thermal/thermal-generic-adc.c
@@ -13,6 +13,8 @@
#include <linux/slab.h>
#include <linux/thermal.h>
+#include "thermal_hwmon.h"
+
struct gadc_thermal_info {
struct device *dev;
struct thermal_zone_device *tz_dev;
@@ -153,6 +155,12 @@ static int gadc_thermal_probe(struct platform_device *pdev)
return ret;
}
+ ret = devm_thermal_add_hwmon_sysfs(&pdev->dev, gti->tz_dev);
+ if (ret) {
+ dev_err(&pdev->dev, "Failed to add hwmon sysfs attributes\n");
+ return ret;
+ }
+
return 0;
}
--
2.41.0.162.gfafddb0af9-goog
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] thermal/drivers/generic-adc: Register thermal zones as hwmon sensors
2023-06-13 9:30 [PATCH] thermal/drivers/generic-adc: Register thermal zones as hwmon sensors Chen-Yu Tsai
@ 2023-06-13 9:44 ` Daniel Lezcano
2023-06-13 9:45 ` Chen-Yu Tsai
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Lezcano @ 2023-06-13 9:44 UTC (permalink / raw)
To: Chen-Yu Tsai, Rafael J. Wysocki, Amit Kucheria, Zhang Rui
Cc: linux-pm, linux-kernel, AngeloGioacchino Del Regno
On 13/06/2023 11:30, Chen-Yu Tsai wrote:
> Register thermal zones as hwmon sensors to let userspace read
> temperatures using standard hwmon interface.
>
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
> ---
> drivers/thermal/thermal-generic-adc.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/thermal/thermal-generic-adc.c b/drivers/thermal/thermal-generic-adc.c
> index 017b0ce52122..e95dc354f192 100644
> --- a/drivers/thermal/thermal-generic-adc.c
> +++ b/drivers/thermal/thermal-generic-adc.c
> @@ -13,6 +13,8 @@
> #include <linux/slab.h>
> #include <linux/thermal.h>
>
> +#include "thermal_hwmon.h"
> +
> struct gadc_thermal_info {
> struct device *dev;
> struct thermal_zone_device *tz_dev;
> @@ -153,6 +155,12 @@ static int gadc_thermal_probe(struct platform_device *pdev)
> return ret;
> }
>
> + ret = devm_thermal_add_hwmon_sysfs(&pdev->dev, gti->tz_dev);
> + if (ret) {
> + dev_err(&pdev->dev, "Failed to add hwmon sysfs attributes\n");
> + return ret;
> + }
Usually, if the hwmon registering fails this is not fatal.
> +
> return 0;
> }
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] thermal/drivers/generic-adc: Register thermal zones as hwmon sensors
2023-06-13 9:44 ` Daniel Lezcano
@ 2023-06-13 9:45 ` Chen-Yu Tsai
0 siblings, 0 replies; 3+ messages in thread
From: Chen-Yu Tsai @ 2023-06-13 9:45 UTC (permalink / raw)
To: Daniel Lezcano
Cc: Rafael J. Wysocki, Amit Kucheria, Zhang Rui, linux-pm,
linux-kernel, AngeloGioacchino Del Regno
On Tue, Jun 13, 2023 at 5:44 PM Daniel Lezcano
<daniel.lezcano@linaro.org> wrote:
>
> On 13/06/2023 11:30, Chen-Yu Tsai wrote:
> > Register thermal zones as hwmon sensors to let userspace read
> > temperatures using standard hwmon interface.
> >
> > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
> > ---
> > drivers/thermal/thermal-generic-adc.c | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/drivers/thermal/thermal-generic-adc.c b/drivers/thermal/thermal-generic-adc.c
> > index 017b0ce52122..e95dc354f192 100644
> > --- a/drivers/thermal/thermal-generic-adc.c
> > +++ b/drivers/thermal/thermal-generic-adc.c
> > @@ -13,6 +13,8 @@
> > #include <linux/slab.h>
> > #include <linux/thermal.h>
> >
> > +#include "thermal_hwmon.h"
> > +
> > struct gadc_thermal_info {
> > struct device *dev;
> > struct thermal_zone_device *tz_dev;
> > @@ -153,6 +155,12 @@ static int gadc_thermal_probe(struct platform_device *pdev)
> > return ret;
> > }
> >
> > + ret = devm_thermal_add_hwmon_sysfs(&pdev->dev, gti->tz_dev);
> > + if (ret) {
> > + dev_err(&pdev->dev, "Failed to add hwmon sysfs attributes\n");
> > + return ret;
> > + }
>
> Usually, if the hwmon registering fails this is not fatal.
Ack. I'll change it to dev_warn.
ChenYu
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-06-13 9:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-13 9:30 [PATCH] thermal/drivers/generic-adc: Register thermal zones as hwmon sensors Chen-Yu Tsai
2023-06-13 9:44 ` Daniel Lezcano
2023-06-13 9:45 ` Chen-Yu Tsai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®