* [PATCH net-next] dt-bindings: net: Use consistent indentation in the example
@ 2026-09-13 12:29 Krzysztof Kozlowski
2026-09-14 9:14 ` Claudiu Manoil
2026-09-14 12:50 ` netdev-bot+sashiko
0 siblings, 2 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2026-09-13 12:29 UTC (permalink / raw)
To: Rob Clark, Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang,
Sean Paul, Marijn Suijten, David Airlie, Simona Vetter,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Justin Chen, Florian Fainelli,
Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Hans Ulli Kroll, Linus Walleij,
Clément Léger, Vladimir Oltean, Heiner Kallweit,
Russell King, Kunihiko Hayashi, Masami Hiramatsu, Felix Fietkau,
Lorenzo Bianconi, Ryder Lee, Shayne Chen, Sean Wang,
Johannes Berg, Matthias Brugger, AngeloGioacchino Del Regno,
Jeff Johnson, Richard Cochran, Geert Uytterhoeven, Magnus Damm,
Yongxing Mou, Robert Foss, Abel Vesa, G. Jaya Kumaran,
Claudiu Manoil, Alexandre Belloni, Alex Elder,
Siddharth Vadapalli, Roger Quadros, linux-arm-msm, dri-devel,
freedreno, devicetree, linux-kernel, bcm-kernel-feedback-list,
netdev, linux-arm-kernel, linux-renesas-soc, linux-wireless,
linux-mediatek, ath10k
Cc: Krzysztof Kozlowski
Correct indentation in the examples to consistent 2- or 4-spaces
indentation to fix dt-check-style warnings ("example 0
[indent-consistent] indent mismatch ..."). Preferred is 4-spaces, but
re-indenting entire example just for that is too much churn.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
.../bindings/net/brcm,asp-v2.0.yaml | 2 +-
.../bindings/net/cortina,gemini-ethernet.yaml | 52 ++++++--------
.../bindings/net/dsa/renesas,rzn1-a5psw.yaml | 4 +-
.../bindings/net/intel,dwmac-plat.yaml | 6 +-
.../devicetree/bindings/net/mdio-gpio.yaml | 16 ++---
.../bindings/net/mscc,vsc7514-switch.yaml | 8 +--
.../devicetree/bindings/net/qcom,ipa.yaml | 10 +--
.../bindings/net/realtek,rtl82xx.yaml | 6 +-
.../bindings/net/socionext,uniphier-ave4.yaml | 32 ++++-----
.../bindings/net/ti,cpsw-switch.yaml | 70 +++++++++----------
.../bindings/net/wireless/mediatek,mt76.yaml | 32 ++++-----
.../bindings/net/wireless/qcom,ath10k.yaml | 2 +-
12 files changed, 114 insertions(+), 126 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml b/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
index a3db6d594c8c..7fcc564e820c 100644
--- a/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
+++ b/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
@@ -123,7 +123,7 @@ examples:
phy0: ethernet-phy@1 {
reg = <1>;
};
- };
+ };
mdio@ce14 {
compatible = "brcm,asp-v2.1-mdio";
diff --git a/Documentation/devicetree/bindings/net/cortina,gemini-ethernet.yaml b/Documentation/devicetree/bindings/net/cortina,gemini-ethernet.yaml
index f0b5bea2458d..da9bc170cd54 100644
--- a/Documentation/devicetree/bindings/net/cortina,gemini-ethernet.yaml
+++ b/Documentation/devicetree/bindings/net/cortina,gemini-ethernet.yaml
@@ -87,18 +87,6 @@ examples:
#include <dt-bindings/interrupt-controller/irq.h>
#include <dt-bindings/clock/cortina,gemini-clock.h>
#include <dt-bindings/reset/cortina,gemini-reset.h>
- mdio0: mdio {
- #address-cells = <1>;
- #size-cells = <0>;
- phy0: ethernet-phy@1 {
- reg = <1>;
- device_type = "ethernet-phy";
- };
- phy1: ethernet-phy@3 {
- reg = <3>;
- device_type = "ethernet-phy";
- };
- };
ethernet@60000000 {
compatible = "cortina,gemini-ethernet";
@@ -110,28 +98,28 @@ examples:
ranges;
gmac0: ethernet-port@0 {
- compatible = "cortina,gemini-ethernet-port";
- reg = <0x60008000 0x2000>, /* Port 0 DMA/TOE */
- <0x6000a000 0x2000>; /* Port 0 GMAC */
- interrupt-parent = <&intcon>;
- interrupts = <1 IRQ_TYPE_LEVEL_HIGH>;
- resets = <&syscon GEMINI_RESET_GMAC0>;
- clocks = <&syscon GEMINI_CLK_GATE_GMAC0>;
- clock-names = "PCLK";
- phy-mode = "rgmii";
- phy-handle = <&phy0>;
+ compatible = "cortina,gemini-ethernet-port";
+ reg = <0x60008000 0x2000>, /* Port 0 DMA/TOE */
+ <0x6000a000 0x2000>; /* Port 0 GMAC */
+ interrupt-parent = <&intcon>;
+ interrupts = <1 IRQ_TYPE_LEVEL_HIGH>;
+ resets = <&syscon GEMINI_RESET_GMAC0>;
+ clocks = <&syscon GEMINI_CLK_GATE_GMAC0>;
+ clock-names = "PCLK";
+ phy-mode = "rgmii";
+ phy-handle = <&phy0>;
};
gmac1: ethernet-port@1 {
- compatible = "cortina,gemini-ethernet-port";
- reg = <0x6000c000 0x2000>, /* Port 1 DMA/TOE */
- <0x6000e000 0x2000>; /* Port 1 GMAC */
- interrupt-parent = <&intcon>;
- interrupts = <2 IRQ_TYPE_LEVEL_HIGH>;
- resets = <&syscon GEMINI_RESET_GMAC1>;
- clocks = <&syscon GEMINI_CLK_GATE_GMAC1>;
- clock-names = "PCLK";
- phy-mode = "rgmii";
- phy-handle = <&phy1>;
+ compatible = "cortina,gemini-ethernet-port";
+ reg = <0x6000c000 0x2000>, /* Port 1 DMA/TOE */
+ <0x6000e000 0x2000>; /* Port 1 GMAC */
+ interrupt-parent = <&intcon>;
+ interrupts = <2 IRQ_TYPE_LEVEL_HIGH>;
+ resets = <&syscon GEMINI_RESET_GMAC1>;
+ clocks = <&syscon GEMINI_CLK_GATE_GMAC1>;
+ clock-names = "PCLK";
+ phy-mode = "rgmii";
+ phy-handle = <&phy1>;
};
};
diff --git a/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml b/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml
index ea285ef3e64f..fab6aa6237e9 100644
--- a/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml
+++ b/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml
@@ -127,8 +127,8 @@ examples:
phy-mode = "internal";
fixed-link {
- speed = <1000>;
- full-duplex;
+ speed = <1000>;
+ full-duplex;
};
};
};
diff --git a/Documentation/devicetree/bindings/net/intel,dwmac-plat.yaml b/Documentation/devicetree/bindings/net/intel,dwmac-plat.yaml
index 62c1da36a2b5..d1522216d32b 100644
--- a/Documentation/devicetree/bindings/net/intel,dwmac-plat.yaml
+++ b/Documentation/devicetree/bindings/net/intel,dwmac-plat.yaml
@@ -91,9 +91,9 @@ examples:
snps,tx-queues-to-use = <2>;
snps,tx-sched-wrr;
queue0 {
- snps,weight = <0x10>;
- snps,dcb-algorithm;
- snps,priority = <0x0>;
+ snps,weight = <0x10>;
+ snps,dcb-algorithm;
+ snps,priority = <0x0>;
};
queue1 {
diff --git a/Documentation/devicetree/bindings/net/mdio-gpio.yaml b/Documentation/devicetree/bindings/net/mdio-gpio.yaml
index eb4171a1940e..36e51aaae9c0 100644
--- a/Documentation/devicetree/bindings/net/mdio-gpio.yaml
+++ b/Documentation/devicetree/bindings/net/mdio-gpio.yaml
@@ -45,13 +45,13 @@ examples:
};
mdio0: mdio {
- compatible = "virtual,mdio-gpio";
- #address-cells = <1>;
- #size-cells = <0>;
- gpios = <&qe_pio_a 11>,
- <&qe_pio_c 6>;
- ethphy0: ethernet-phy@0 {
- reg = <0>;
- };
+ compatible = "virtual,mdio-gpio";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ gpios = <&qe_pio_a 11>,
+ <&qe_pio_c 6>;
+ ethphy0: ethernet-phy@0 {
+ reg = <0>;
+ };
};
...
diff --git a/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml b/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml
index 86a9c3fc76c8..d825130b54b4 100644
--- a/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml
+++ b/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml
@@ -197,10 +197,10 @@ examples:
<0x71040000 0x10000>,
<0x71050000 0x10000>,
<0x71060000 0x10000>;
- reg-names = "sys", "rew", "qs", "ptp", "port0", "port1",
- "port2", "port3", "port4", "port5", "port6",
- "port7", "port8", "port9", "port10", "qsys",
- "ana", "s0", "s1", "s2";
+ reg-names = "sys", "rew", "qs", "ptp", "port0", "port1",
+ "port2", "port3", "port4", "port5", "port6",
+ "port7", "port8", "port9", "port10", "qsys",
+ "ana", "s0", "s1", "s2";
ethernet-ports {
#address-cells = <1>;
diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
index 68ec76fe4473..38e3830512fe 100644
--- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml
+++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
@@ -246,14 +246,14 @@ examples:
qcom,remote-pid = <5>;
ipa_smp2p_out: ipa-ap-to-modem {
- qcom,entry-name = "ipa";
- #qcom,smem-state-cells = <1>;
+ qcom,entry-name = "ipa";
+ #qcom,smem-state-cells = <1>;
};
ipa_smp2p_in: ipa-modem-to-ap {
- qcom,entry-name = "ipa";
- interrupt-controller;
- #interrupt-cells = <2>;
+ qcom,entry-name = "ipa";
+ interrupt-controller;
+ #interrupt-cells = <2>;
};
};
diff --git a/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml b/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml
index 45033c31a2d5..07b39ef1fc62 100644
--- a/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml
+++ b/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml
@@ -91,8 +91,8 @@ examples:
#size-cells = <0>;
ethphy1: ethernet-phy@1 {
- reg = <1>;
- realtek,clkout-disable;
- realtek,aldps-enable;
+ reg = <1>;
+ realtek,clkout-disable;
+ realtek,aldps-enable;
};
};
diff --git a/Documentation/devicetree/bindings/net/socionext,uniphier-ave4.yaml b/Documentation/devicetree/bindings/net/socionext,uniphier-ave4.yaml
index 4eb63b303cff..8c8622160abb 100644
--- a/Documentation/devicetree/bindings/net/socionext,uniphier-ave4.yaml
+++ b/Documentation/devicetree/bindings/net/socionext,uniphier-ave4.yaml
@@ -121,22 +121,22 @@ examples:
- |
ether: ethernet@65000000 {
compatible = "socionext,uniphier-ld20-ave4";
- reg = <0x65000000 0x8500>;
- interrupts = <0 66 4>;
- phy-mode = "rgmii";
- phy-handle = <ðphy>;
- clock-names = "ether";
- clocks = <&sys_clk 6>;
- reset-names = "ether";
- resets = <&sys_rst 6>;
- socionext,syscon-phy-mode = <&soc_glue 0>;
+ reg = <0x65000000 0x8500>;
+ interrupts = <0 66 4>;
+ phy-mode = "rgmii";
+ phy-handle = <ðphy>;
+ clock-names = "ether";
+ clocks = <&sys_clk 6>;
+ reset-names = "ether";
+ resets = <&sys_rst 6>;
+ socionext,syscon-phy-mode = <&soc_glue 0>;
- mdio {
- #address-cells = <1>;
- #size-cells = <0>;
+ mdio {
+ #address-cells = <1>;
+ #size-cells = <0>;
- ethphy: ethernet-phy@1 {
- reg = <1>;
- };
- };
+ ethphy: ethernet-phy@1 {
+ reg = <1>;
+ };
};
+ };
diff --git a/Documentation/devicetree/bindings/net/ti,cpsw-switch.yaml b/Documentation/devicetree/bindings/net/ti,cpsw-switch.yaml
index 8b5da602a2e8..4d24dadfaa5d 100644
--- a/Documentation/devicetree/bindings/net/ti,cpsw-switch.yaml
+++ b/Documentation/devicetree/bindings/net/ti,cpsw-switch.yaml
@@ -192,50 +192,50 @@ examples:
interrupt-names = "rx_thresh", "rx", "tx", "misc";
ethernet-ports {
- #address-cells = <1>;
- #size-cells = <0>;
+ #address-cells = <1>;
+ #size-cells = <0>;
- cpsw_port1: port@1 {
- reg = <1>;
- label = "port1";
- mac-address = [ 00 00 00 00 00 00 ];
- phys = <&phy_gmii_sel 1>;
- phy-handle = <ðphy0_sw>;
- phy-mode = "rgmii";
- ti,dual-emac-pvid = <1>;
- };
+ cpsw_port1: port@1 {
+ reg = <1>;
+ label = "port1";
+ mac-address = [ 00 00 00 00 00 00 ];
+ phys = <&phy_gmii_sel 1>;
+ phy-handle = <ðphy0_sw>;
+ phy-mode = "rgmii";
+ ti,dual-emac-pvid = <1>;
+ };
- cpsw_port2: port@2 {
- reg = <2>;
- label = "wan";
- mac-address = [ 00 00 00 00 00 00 ];
- phys = <&phy_gmii_sel 2>;
- phy-handle = <ðphy1_sw>;
- phy-mode = "rgmii";
- ti,dual-emac-pvid = <2>;
- };
+ cpsw_port2: port@2 {
+ reg = <2>;
+ label = "wan";
+ mac-address = [ 00 00 00 00 00 00 ];
+ phys = <&phy_gmii_sel 2>;
+ phy-handle = <ðphy1_sw>;
+ phy-mode = "rgmii";
+ ti,dual-emac-pvid = <2>;
+ };
};
davinci_mdio_sw: mdio@1000 {
- compatible = "ti,cpsw-mdio","ti,davinci_mdio";
- reg = <0x1000 0x100>;
- clocks = <&gmac_clkctrl DRA7_GMAC_GMAC_CLKCTRL 0>;
- clock-names = "fck";
- #address-cells = <1>;
- #size-cells = <0>;
- bus_freq = <1000000>;
+ compatible = "ti,cpsw-mdio","ti,davinci_mdio";
+ reg = <0x1000 0x100>;
+ clocks = <&gmac_clkctrl DRA7_GMAC_GMAC_CLKCTRL 0>;
+ clock-names = "fck";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ bus_freq = <1000000>;
- ethphy0_sw: ethernet-phy@0 {
- reg = <0>;
- };
+ ethphy0_sw: ethernet-phy@0 {
+ reg = <0>;
+ };
- ethphy1_sw: ethernet-phy@1 {
- reg = <1>;
- };
+ ethphy1_sw: ethernet-phy@1 {
+ reg = <1>;
+ };
};
cpts {
- clocks = <&gmac_clkctrl DRA7_GMAC_GMAC_CLKCTRL 25>;
- clock-names = "cpts";
+ clocks = <&gmac_clkctrl DRA7_GMAC_GMAC_CLKCTRL 25>;
+ clock-names = "cpts";
};
};
diff --git a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
index ae6b97cdc44b..bf4116b057d2 100644
--- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
@@ -325,22 +325,22 @@ examples:
r0 {
regdomain = "FCC";
txpower-5g {
- b0 {
- channels = <36 48>;
- rates-ofdm = /bits/ 8 <23 23 23 23 23 23 23 23>;
- rates-mcs = /bits/ 8 <1 23 23 23 23 23 23 23 23 23 23>,
- /bits/ 8 <3 22 22 22 22 22 22 22 22 22 22>;
- rates-ru = /bits/ 8 <3 22 22 22 22 22 22 22 22 22 22 22 22>,
- /bits/ 8 <4 20 20 20 20 20 20 20 20 20 20 20 20>;
- };
- b1 {
- channels = <100 181>;
- rates-ofdm = /bits/ 8 <14 14 14 14 14 14 14 14>;
- rates-mcs = /bits/ 8 <4 14 14 14 14 14 14 14 14 14 14>;
- txs-delta = <12 9 6>;
- rates-ru = /bits/ 8 <7 14 14 14 14 14 14 14 14 14 14 14 14>;
- };
- };
+ b0 {
+ channels = <36 48>;
+ rates-ofdm = /bits/ 8 <23 23 23 23 23 23 23 23>;
+ rates-mcs = /bits/ 8 <1 23 23 23 23 23 23 23 23 23 23>,
+ /bits/ 8 <3 22 22 22 22 22 22 22 22 22 22>;
+ rates-ru = /bits/ 8 <3 22 22 22 22 22 22 22 22 22 22 22 22>,
+ /bits/ 8 <4 20 20 20 20 20 20 20 20 20 20 20 20>;
+ };
+ b1 {
+ channels = <100 181>;
+ rates-ofdm = /bits/ 8 <14 14 14 14 14 14 14 14>;
+ rates-mcs = /bits/ 8 <4 14 14 14 14 14 14 14 14 14 14>;
+ txs-delta = <12 9 6>;
+ rates-ru = /bits/ 8 <7 14 14 14 14 14 14 14 14 14 14 14 14>;
+ };
+ };
};
};
};
diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml
index e667d78b3ab3..a52cb8a0d409 100644
--- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml
+++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml
@@ -408,4 +408,4 @@ examples:
"msi15",
"legacy";
ieee80211-freq-limit = <5470000 5875000>;
- };
+ };
--
2.53.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH net-next] dt-bindings: net: Use consistent indentation in the example
2026-09-13 12:29 [PATCH net-next] dt-bindings: net: Use consistent indentation in the example Krzysztof Kozlowski
@ 2026-09-14 9:14 ` Claudiu Manoil
2026-09-14 9:17 ` Krzysztof Kozlowski
2026-09-14 12:50 ` netdev-bot+sashiko
1 sibling, 1 reply; 5+ messages in thread
From: Claudiu Manoil @ 2026-09-14 9:14 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Clark, Dmitry Baryshkov, Abhinav Kumar,
Jessica Zhang, Sean Paul, Marijn Suijten, David Airlie,
Simona Vetter, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Justin Chen, Florian Fainelli, Andrew Lunn,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Hans Ulli Kroll, Linus Walleij, Clément Léger,
Vladimir Oltean, Heiner Kallweit, Russell King, Kunihiko Hayashi,
Masami Hiramatsu, Felix Fietkau, Lorenzo Bianconi, Ryder Lee,
Shayne Chen, Sean Wang, Johannes Berg, Matthias Brugger,
AngeloGioacchino Del Regno, Jeff Johnson, Richard Cochran,
Geert Uytterhoeven, Magnus Damm, Yongxing Mou, Robert Foss,
Abel Vesa, G. Jaya Kumaran, Alexandre Belloni, Alex Elder,
Siddharth Vadapalli, Roger Quadros, linux-arm-msm, dri-devel,
freedreno, devicetree, linux-kernel, bcm-kernel-feedback-list,
netdev, linux-arm-kernel, linux-renesas-soc, linux-wireless,
linux-mediatek, ath10k
NXP Confidential
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> Sent: Sunday, September 13, 2026 3:29 PM
> To: Rob Clark <robin.clark@oss.qualcomm.com>; Dmitry Baryshkov
> <lumag@kernel.org>; Abhinav Kumar <abhinav.kumar@linux.dev>; Jessica
> Zhang <jesszhan0024@gmail.com>; Sean Paul <sean@poorly.run>; Marijn
> Suijten <marijn.suijten@somainline.org>; David Airlie <airlied@gmail.com>;
> Simona Vetter <simona@ffwll.ch>; Maarten Lankhorst
> <maarten.lankhorst@linux.intel.com>; Maxime Ripard <mripard@kernel.org>;
> Thomas Zimmermann <tzimmermann@suse.de>; Rob Herring
> <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley
> <conor+dt@kernel.org>; Justin Chen <justin.chen@broadcom.com>; Florian
> Fainelli <florian.fainelli@broadcom.com>; Andrew Lunn
> <andrew+netdev@lunn.ch>; David S. Miller <davem@davemloft.net>; Eric
> Dumazet <edumazet@google.com>; Jakub Kicinski <kuba@kernel.org>; Paolo
> Abeni <pabeni@redhat.com>; Hans Ulli Kroll <ulli.kroll@googlemail.com>;
> Linus Walleij <linusw@kernel.org>; Clément Léger
> <clement.leger@bootlin.com>; Vladimir Oltean <olteanv@gmail.com>; Heiner
> Kallweit <hkallweit1@gmail.com>; Russell King <linux@armlinux.org.uk>;
> Kunihiko Hayashi <hayashi.kunihiko@socionext.com>; Masami Hiramatsu
> <mhiramat@kernel.org>; Felix Fietkau <nbd@nbd.name>; Lorenzo Bianconi
> <lorenzo@kernel.org>; Ryder Lee <ryder.lee@mediatek.com>; Shayne Chen
> <shayne.chen@mediatek.com>; Sean Wang <sean.wang@mediatek.com>;
> Johannes Berg <johannes@sipsolutions.net>; Matthias Brugger
> <matthias.bgg@gmail.com>; AngeloGioacchino Del Regno
> <angelogioacchino.delregno@collabora.com>; Jeff Johnson
> <jjohnson@kernel.org>; Richard Cochran <richardcochran@gmail.com>; Geert
> Uytterhoeven <geert+renesas@glider.be>; Magnus Damm
> <magnus.damm@gmail.com>; Yongxing Mou
> <yongxing.mou@oss.qualcomm.com>; Robert Foss <rfoss@kernel.org>; Abel
> Vesa <abelvesa@kernel.org>; G. Jaya Kumaran
> <vineetha.g.jaya.kumaran@intel.com>; Claudiu Manoil
> <claudiu.manoil@nxp.com>; Alexandre Belloni
> <alexandre.belloni@bootlin.com>; Alex Elder <elder@kernel.org>; Siddharth
> Vadapalli <s-vadapalli@ti.com>; Roger Quadros <rogerq@kernel.org>; linux-
> arm-msm@vger.kernel.org; dri-devel@lists.freedesktop.org;
> freedreno@lists.freedesktop.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; bcm-kernel-feedback-list@broadcom.com;
> netdev@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-renesas-
> soc@vger.kernel.org; linux-wireless@vger.kernel.org; linux-
> mediatek@lists.infradead.org; ath10k@lists.infradead.org
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> Subject: [PATCH net-next] dt-bindings: net: Use consistent indentation in the
> example
>
> Correct indentation in the examples to consistent 2- or 4-spaces
> indentation to fix dt-check-style warnings ("example 0
> [indent-consistent] indent mismatch ..."). Preferred is 4-spaces, but
> re-indenting entire example just for that is too much churn.
>
> Signed-off-by: Krzysztof Kozlowski
> <krzysztof.kozlowski@oss.qualcomm.com>
> ---
> .../bindings/net/brcm,asp-v2.0.yaml | 2 +-
> .../bindings/net/cortina,gemini-ethernet.yaml | 52 ++++++--------
> .../bindings/net/dsa/renesas,rzn1-a5psw.yaml | 4 +-
> .../bindings/net/intel,dwmac-plat.yaml | 6 +-
> .../devicetree/bindings/net/mdio-gpio.yaml | 16 ++---
> .../bindings/net/mscc,vsc7514-switch.yaml | 8 +--
> .../devicetree/bindings/net/qcom,ipa.yaml | 10 +--
> .../bindings/net/realtek,rtl82xx.yaml | 6 +-
> .../bindings/net/socionext,uniphier-ave4.yaml | 32 ++++-----
> .../bindings/net/ti,cpsw-switch.yaml | 70 +++++++++----------
> .../bindings/net/wireless/mediatek,mt76.yaml | 32 ++++-----
> .../bindings/net/wireless/qcom,ath10k.yaml | 2 +-
> 12 files changed, 114 insertions(+), 126 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
> b/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
> index a3db6d594c8c..7fcc564e820c 100644
> --- a/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
> +++ b/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
> @@ -123,7 +123,7 @@ examples:
> phy0: ethernet-phy@1 {
> reg = <1>;
> };
> - };
> + };
>
> mdio@ce14 {
> compatible = "brcm,asp-v2.1-mdio";
> diff --git a/Documentation/devicetree/bindings/net/cortina,gemini-
> ethernet.yaml b/Documentation/devicetree/bindings/net/cortina,gemini-
> ethernet.yaml
> index f0b5bea2458d..da9bc170cd54 100644
> --- a/Documentation/devicetree/bindings/net/cortina,gemini-ethernet.yaml
> +++ b/Documentation/devicetree/bindings/net/cortina,gemini-ethernet.yaml
> @@ -87,18 +87,6 @@ examples:
> #include <dt-bindings/interrupt-controller/irq.h>
> #include <dt-bindings/clock/cortina,gemini-clock.h>
> #include <dt-bindings/reset/cortina,gemini-reset.h>
> - mdio0: mdio {
> - #address-cells = <1>;
> - #size-cells = <0>;
> - phy0: ethernet-phy@1 {
> - reg = <1>;
> - device_type = "ethernet-phy";
> - };
> - phy1: ethernet-phy@3 {
> - reg = <3>;
> - device_type = "ethernet-phy";
> - };
> - };
>
> ethernet@60000000 {
> compatible = "cortina,gemini-ethernet";
> @@ -110,28 +98,28 @@ examples:
> ranges;
>
> gmac0: ethernet-port@0 {
> - compatible = "cortina,gemini-ethernet-port";
> - reg = <0x60008000 0x2000>, /* Port 0 DMA/TOE */
> - <0x6000a000 0x2000>; /* Port 0 GMAC */
> - interrupt-parent = <&intcon>;
> - interrupts = <1 IRQ_TYPE_LEVEL_HIGH>;
> - resets = <&syscon GEMINI_RESET_GMAC0>;
> - clocks = <&syscon GEMINI_CLK_GATE_GMAC0>;
> - clock-names = "PCLK";
> - phy-mode = "rgmii";
> - phy-handle = <&phy0>;
> + compatible = "cortina,gemini-ethernet-port";
> + reg = <0x60008000 0x2000>, /* Port 0 DMA/TOE */
> + <0x6000a000 0x2000>; /* Port 0 GMAC */
> + interrupt-parent = <&intcon>;
> + interrupts = <1 IRQ_TYPE_LEVEL_HIGH>;
> + resets = <&syscon GEMINI_RESET_GMAC0>;
> + clocks = <&syscon GEMINI_CLK_GATE_GMAC0>;
> + clock-names = "PCLK";
> + phy-mode = "rgmii";
> + phy-handle = <&phy0>;
> };
>
> gmac1: ethernet-port@1 {
> - compatible = "cortina,gemini-ethernet-port";
> - reg = <0x6000c000 0x2000>, /* Port 1 DMA/TOE */
> - <0x6000e000 0x2000>; /* Port 1 GMAC */
> - interrupt-parent = <&intcon>;
> - interrupts = <2 IRQ_TYPE_LEVEL_HIGH>;
> - resets = <&syscon GEMINI_RESET_GMAC1>;
> - clocks = <&syscon GEMINI_CLK_GATE_GMAC1>;
> - clock-names = "PCLK";
> - phy-mode = "rgmii";
> - phy-handle = <&phy1>;
> + compatible = "cortina,gemini-ethernet-port";
> + reg = <0x6000c000 0x2000>, /* Port 1 DMA/TOE */
> + <0x6000e000 0x2000>; /* Port 1 GMAC */
> + interrupt-parent = <&intcon>;
> + interrupts = <2 IRQ_TYPE_LEVEL_HIGH>;
> + resets = <&syscon GEMINI_RESET_GMAC1>;
> + clocks = <&syscon GEMINI_CLK_GATE_GMAC1>;
> + clock-names = "PCLK";
> + phy-mode = "rgmii";
> + phy-handle = <&phy1>;
> };
> };
> diff --git a/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-
> a5psw.yaml b/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-
> a5psw.yaml
> index ea285ef3e64f..fab6aa6237e9 100644
> --- a/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml
> +++ b/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-
> a5psw.yaml
> @@ -127,8 +127,8 @@ examples:
> phy-mode = "internal";
>
> fixed-link {
> - speed = <1000>;
> - full-duplex;
> + speed = <1000>;
> + full-duplex;
> };
> };
> };
> diff --git a/Documentation/devicetree/bindings/net/intel,dwmac-plat.yaml
> b/Documentation/devicetree/bindings/net/intel,dwmac-plat.yaml
> index 62c1da36a2b5..d1522216d32b 100644
> --- a/Documentation/devicetree/bindings/net/intel,dwmac-plat.yaml
> +++ b/Documentation/devicetree/bindings/net/intel,dwmac-plat.yaml
> @@ -91,9 +91,9 @@ examples:
> snps,tx-queues-to-use = <2>;
> snps,tx-sched-wrr;
> queue0 {
> - snps,weight = <0x10>;
> - snps,dcb-algorithm;
> - snps,priority = <0x0>;
> + snps,weight = <0x10>;
> + snps,dcb-algorithm;
> + snps,priority = <0x0>;
> };
>
> queue1 {
> diff --git a/Documentation/devicetree/bindings/net/mdio-gpio.yaml
> b/Documentation/devicetree/bindings/net/mdio-gpio.yaml
> index eb4171a1940e..36e51aaae9c0 100644
> --- a/Documentation/devicetree/bindings/net/mdio-gpio.yaml
> +++ b/Documentation/devicetree/bindings/net/mdio-gpio.yaml
> @@ -45,13 +45,13 @@ examples:
> };
>
> mdio0: mdio {
> - compatible = "virtual,mdio-gpio";
> - #address-cells = <1>;
> - #size-cells = <0>;
> - gpios = <&qe_pio_a 11>,
> - <&qe_pio_c 6>;
> - ethphy0: ethernet-phy@0 {
> - reg = <0>;
> - };
> + compatible = "virtual,mdio-gpio";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + gpios = <&qe_pio_a 11>,
> + <&qe_pio_c 6>;
> + ethphy0: ethernet-phy@0 {
> + reg = <0>;
> + };
> };
> ...
> diff --git a/Documentation/devicetree/bindings/net/mscc,vsc7514-
> switch.yaml b/Documentation/devicetree/bindings/net/mscc,vsc7514-
> switch.yaml
> index 86a9c3fc76c8..d825130b54b4 100644
> --- a/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml
> +++ b/Documentation/devicetree/bindings/net/mscc,vsc7514-switch.yaml
> @@ -197,10 +197,10 @@ examples:
> <0x71040000 0x10000>,
> <0x71050000 0x10000>,
> <0x71060000 0x10000>;
> - reg-names = "sys", "rew", "qs", "ptp", "port0", "port1",
> - "port2", "port3", "port4", "port5", "port6",
> - "port7", "port8", "port9", "port10", "qsys",
> - "ana", "s0", "s1", "s2";
> + reg-names = "sys", "rew", "qs", "ptp", "port0", "port1",
> + "port2", "port3", "port4", "port5", "port6",
> + "port7", "port8", "port9", "port10", "qsys",
> + "ana", "s0", "s1", "s2";
>
> ethernet-ports {
> #address-cells = <1>;
> diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> index 68ec76fe4473..38e3830512fe 100644
> --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> @@ -246,14 +246,14 @@ examples:
> qcom,remote-pid = <5>;
>
> ipa_smp2p_out: ipa-ap-to-modem {
> - qcom,entry-name = "ipa";
> - #qcom,smem-state-cells = <1>;
> + qcom,entry-name = "ipa";
> + #qcom,smem-state-cells = <1>;
> };
>
> ipa_smp2p_in: ipa-modem-to-ap {
> - qcom,entry-name = "ipa";
> - interrupt-controller;
> - #interrupt-cells = <2>;
> + qcom,entry-name = "ipa";
> + interrupt-controller;
> + #interrupt-cells = <2>;
> };
> };
>
> diff --git a/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml
> b/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml
> index 45033c31a2d5..07b39ef1fc62 100644
> --- a/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml
> +++ b/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml
> @@ -91,8 +91,8 @@ examples:
> #size-cells = <0>;
>
> ethphy1: ethernet-phy@1 {
> - reg = <1>;
> - realtek,clkout-disable;
> - realtek,aldps-enable;
> + reg = <1>;
> + realtek,clkout-disable;
> + realtek,aldps-enable;
> };
> };
> diff --git a/Documentation/devicetree/bindings/net/socionext,uniphier-
> ave4.yaml b/Documentation/devicetree/bindings/net/socionext,uniphier-
> ave4.yaml
> index 4eb63b303cff..8c8622160abb 100644
> --- a/Documentation/devicetree/bindings/net/socionext,uniphier-ave4.yaml
> +++ b/Documentation/devicetree/bindings/net/socionext,uniphier-ave4.yaml
> @@ -121,22 +121,22 @@ examples:
> - |
> ether: ethernet@65000000 {
> compatible = "socionext,uniphier-ld20-ave4";
> - reg = <0x65000000 0x8500>;
> - interrupts = <0 66 4>;
> - phy-mode = "rgmii";
> - phy-handle = <ðphy>;
> - clock-names = "ether";
> - clocks = <&sys_clk 6>;
> - reset-names = "ether";
> - resets = <&sys_rst 6>;
> - socionext,syscon-phy-mode = <&soc_glue 0>;
> + reg = <0x65000000 0x8500>;
> + interrupts = <0 66 4>;
> + phy-mode = "rgmii";
> + phy-handle = <ðphy>;
> + clock-names = "ether";
> + clocks = <&sys_clk 6>;
> + reset-names = "ether";
> + resets = <&sys_rst 6>;
> + socionext,syscon-phy-mode = <&soc_glue 0>;
>
> - mdio {
> - #address-cells = <1>;
> - #size-cells = <0>;
> + mdio {
> + #address-cells = <1>;
> + #size-cells = <0>;
>
> - ethphy: ethernet-phy@1 {
> - reg = <1>;
> - };
> - };
> + ethphy: ethernet-phy@1 {
> + reg = <1>;
> + };
> };
> + };
> diff --git a/Documentation/devicetree/bindings/net/ti,cpsw-switch.yaml
> b/Documentation/devicetree/bindings/net/ti,cpsw-switch.yaml
> index 8b5da602a2e8..4d24dadfaa5d 100644
> --- a/Documentation/devicetree/bindings/net/ti,cpsw-switch.yaml
> +++ b/Documentation/devicetree/bindings/net/ti,cpsw-switch.yaml
> @@ -192,50 +192,50 @@ examples:
> interrupt-names = "rx_thresh", "rx", "tx", "misc";
>
> ethernet-ports {
> - #address-cells = <1>;
> - #size-cells = <0>;
> + #address-cells = <1>;
> + #size-cells = <0>;
>
> - cpsw_port1: port@1 {
> - reg = <1>;
> - label = "port1";
> - mac-address = [ 00 00 00 00 00 00 ];
> - phys = <&phy_gmii_sel 1>;
> - phy-handle = <ðphy0_sw>;
> - phy-mode = "rgmii";
> - ti,dual-emac-pvid = <1>;
> - };
> + cpsw_port1: port@1 {
> + reg = <1>;
> + label = "port1";
> + mac-address = [ 00 00 00 00 00 00 ];
> + phys = <&phy_gmii_sel 1>;
> + phy-handle = <ðphy0_sw>;
> + phy-mode = "rgmii";
> + ti,dual-emac-pvid = <1>;
> + };
>
> - cpsw_port2: port@2 {
> - reg = <2>;
> - label = "wan";
> - mac-address = [ 00 00 00 00 00 00 ];
> - phys = <&phy_gmii_sel 2>;
> - phy-handle = <ðphy1_sw>;
> - phy-mode = "rgmii";
> - ti,dual-emac-pvid = <2>;
> - };
> + cpsw_port2: port@2 {
> + reg = <2>;
> + label = "wan";
> + mac-address = [ 00 00 00 00 00 00 ];
> + phys = <&phy_gmii_sel 2>;
> + phy-handle = <ðphy1_sw>;
> + phy-mode = "rgmii";
> + ti,dual-emac-pvid = <2>;
> + };
> };
>
> davinci_mdio_sw: mdio@1000 {
> - compatible = "ti,cpsw-mdio","ti,davinci_mdio";
> - reg = <0x1000 0x100>;
> - clocks = <&gmac_clkctrl DRA7_GMAC_GMAC_CLKCTRL 0>;
> - clock-names = "fck";
> - #address-cells = <1>;
> - #size-cells = <0>;
> - bus_freq = <1000000>;
> + compatible = "ti,cpsw-mdio","ti,davinci_mdio";
> + reg = <0x1000 0x100>;
> + clocks = <&gmac_clkctrl DRA7_GMAC_GMAC_CLKCTRL 0>;
> + clock-names = "fck";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + bus_freq = <1000000>;
>
> - ethphy0_sw: ethernet-phy@0 {
> - reg = <0>;
> - };
> + ethphy0_sw: ethernet-phy@0 {
> + reg = <0>;
> + };
>
> - ethphy1_sw: ethernet-phy@1 {
> - reg = <1>;
> - };
> + ethphy1_sw: ethernet-phy@1 {
> + reg = <1>;
> + };
> };
>
> cpts {
> - clocks = <&gmac_clkctrl DRA7_GMAC_GMAC_CLKCTRL 25>;
> - clock-names = "cpts";
> + clocks = <&gmac_clkctrl DRA7_GMAC_GMAC_CLKCTRL 25>;
> + clock-names = "cpts";
> };
> };
> diff --git
> a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> index ae6b97cdc44b..bf4116b057d2 100644
> --- a/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/mediatek,mt76.yaml
> @@ -325,22 +325,22 @@ examples:
> r0 {
> regdomain = "FCC";
> txpower-5g {
> - b0 {
> - channels = <36 48>;
> - rates-ofdm = /bits/ 8 <23 23 23 23 23 23 23 23>;
> - rates-mcs = /bits/ 8 <1 23 23 23 23 23 23 23 23 23 23>,
> - /bits/ 8 <3 22 22 22 22 22 22 22 22 22 22>;
> - rates-ru = /bits/ 8 <3 22 22 22 22 22 22 22 22 22 22 22 22>,
> - /bits/ 8 <4 20 20 20 20 20 20 20 20 20 20 20 20>;
> - };
> - b1 {
> - channels = <100 181>;
> - rates-ofdm = /bits/ 8 <14 14 14 14 14 14 14 14>;
> - rates-mcs = /bits/ 8 <4 14 14 14 14 14 14 14 14 14 14>;
> - txs-delta = <12 9 6>;
> - rates-ru = /bits/ 8 <7 14 14 14 14 14 14 14 14 14 14 14 14>;
> - };
> - };
> + b0 {
> + channels = <36 48>;
> + rates-ofdm = /bits/ 8 <23 23 23 23 23 23 23 23>;
> + rates-mcs = /bits/ 8 <1 23 23 23 23 23 23 23 23 23 23>,
> + /bits/ 8 <3 22 22 22 22 22 22 22 22 22 22>;
> + rates-ru = /bits/ 8 <3 22 22 22 22 22 22 22 22 22 22 22 22>,
> + /bits/ 8 <4 20 20 20 20 20 20 20 20 20 20 20 20>;
> + };
> + b1 {
> + channels = <100 181>;
> + rates-ofdm = /bits/ 8 <14 14 14 14 14 14 14 14>;
> + rates-mcs = /bits/ 8 <4 14 14 14 14 14 14 14 14 14 14>;
> + txs-delta = <12 9 6>;
> + rates-ru = /bits/ 8 <7 14 14 14 14 14 14 14 14 14 14 14 14>;
> + };
> + };
> };
> };
> };
> diff --git
> a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml
> b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml
> index e667d78b3ab3..a52cb8a0d409 100644
> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml
> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.yaml
> @@ -408,4 +408,4 @@ examples:
> "msi15",
> "legacy";
> ieee80211-freq-limit = <5470000 5875000>;
> - };
> + };
> --
> 2.53.0
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] dt-bindings: net: Use consistent indentation in the example
2026-09-14 9:14 ` Claudiu Manoil
@ 2026-09-14 9:17 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2026-09-14 9:17 UTC (permalink / raw)
To: Claudiu Manoil, Krzysztof Kozlowski, Rob Clark, Dmitry Baryshkov,
Abhinav Kumar, Jessica Zhang, Sean Paul, Marijn Suijten,
David Airlie, Simona Vetter, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Justin Chen, Florian Fainelli, Andrew Lunn,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Hans Ulli Kroll, Linus Walleij, Clément Léger,
Vladimir Oltean, Heiner Kallweit, Russell King, Kunihiko Hayashi,
Masami Hiramatsu, Felix Fietkau, Lorenzo Bianconi, Ryder Lee,
Shayne Chen, Sean Wang, Johannes Berg, Matthias Brugger,
AngeloGioacchino Del Regno, Jeff Johnson, Richard Cochran,
Geert Uytterhoeven, Magnus Damm, Yongxing Mou, Robert Foss,
Abel Vesa, G. Jaya Kumaran, Alexandre Belloni, Alex Elder,
Siddharth Vadapalli, Roger Quadros, linux-arm-msm, dri-devel,
freedreno, devicetree, linux-kernel, bcm-kernel-feedback-list,
netdev, linux-arm-kernel, linux-renesas-soc, linux-wireless,
linux-mediatek, ath10k
On 14/09/2026 11:14, Claudiu Manoil wrote:
>
>
>
> NXP Confidential
No. Please fix your corpo systems or switch kindly to @linux.dev
https://korg.docs.kernel.org/linuxdev.html
You just top-posted with "confidential" and then quoted entire email.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] dt-bindings: net: Use consistent indentation in the example
2026-09-13 12:29 [PATCH net-next] dt-bindings: net: Use consistent indentation in the example Krzysztof Kozlowski
2026-09-14 9:14 ` Claudiu Manoil
@ 2026-09-14 12:50 ` netdev-bot+sashiko
2026-09-14 15:52 ` Krzysztof Kozlowski
1 sibling, 1 reply; 5+ messages in thread
From: netdev-bot+sashiko @ 2026-09-14 12:50 UTC (permalink / raw)
To: krzysztof.kozlowski
Cc: robin.clark, lumag, abhinav.kumar, jesszhan0024, sean,
marijn.suijten, airlied, simona, maarten.lankhorst, mripard,
tzimmermann, robh, krzk+dt, conor+dt, justin.chen,
florian.fainelli, andrew+netdev, davem, edumazet, kuba, pabeni,
ulli.kroll, linusw, clement.leger, olteanv, hkallweit1, linux,
hayashi.kunihiko, mhiramat, nbd, lorenzo, ryder.lee, shayne.chen,
sean.wang, johannes, matthias.bgg, angelogioacchino.delregno,
jjohnson, richardcochran, geert+renesas, magnus.damm,
yongxing.mou, rfoss, abelvesa, vineetha.g.jaya.kumaran,
claudiu.manoil, alexandre.belloni, elder, s-vadapalli, rogerq,
linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel,
bcm-kernel-feedback-list, netdev, linux-arm-kernel,
linux-renesas-soc, linux-wireless, linux-mediatek, ath10k
Thank you for your contribution! Sashiko AI review found 1 potential
issue(s) to consider:
Critical: 0 · High: 0 · Medium: 1 · Low: 0
- [Medium] In Documentation/devicetree/bindings/net/cortina,gemini-
ethernet.yaml the patch does more than re-indent: it deletes the whole…
--
dt-bindings: net: Use consistent indentation in the example
This reindents the DT binding examples under Documentation/devicetree/
bindings/net/ to consistent 2- or 4-space indentation so that
dt-check-style stops reporting "indent mismatch" warnings. Twelve
binding files are touched.
> diff --git a/Documentation/devicetree/bindings/net/cortina,gemini-ethernet.yaml b/Documentation/devicetree/bindings/net/cortina,gemini-ethernet.yaml
> index f0b5bea2458d5..da9bc170cd543 100644
> --- a/Documentation/devicetree/bindings/net/cortina,gemini-ethernet.yaml
> +++ b/Documentation/devicetree/bindings/net/cortina,gemini-ethernet.yaml
> @@ -87,18 +87,6 @@ examples:
> #include <dt-bindings/interrupt-controller/irq.h>
> #include <dt-bindings/clock/cortina,gemini-clock.h>
> #include <dt-bindings/reset/cortina,gemini-reset.h>
> - mdio0: mdio {
> - #address-cells = <1>;
> - #size-cells = <0>;
> - phy0: ethernet-phy@1 {
> - reg = <1>;
> - device_type = "ethernet-phy";
> - };
> - phy1: ethernet-phy@3 {
> - reg = <3>;
> - device_type = "ethernet-phy";
> - };
> - };
[Severity: Medium]
Is this deletion intended? The commit message says only:
Correct indentation in the examples to consistent 2- or 4-spaces
indentation to fix dt-check-style warnings
Every other hunk in the series is a pure whitespace shift with the brace
nesting preserved, but here the whole mdio0 node with phy0 and phy1 is
removed and nothing is added back.
Wouldn't re-indenting the mdio0 node to 4 spaces achieve the stated goal
without dropping the example content?
>
> ethernet@60000000 {
> compatible = "cortina,gemini-ethernet";
> @@ -110,28 +98,28 @@ examples:
> ranges;
>
> gmac0: ethernet-port@0 {
[ ... ]
> + phy-mode = "rgmii";
> + phy-handle = <&phy0>;
> };
[Severity: Medium]
Do the surviving phy-handle properties in gmac0 and gmac1 now reference
labels that no longer exist in the file? After this patch the file
contains:
gmac0: ethernet-port@0 {
...
phy-handle = <&phy0>;
};
gmac1: ethernet-port@1 {
...
phy-handle = <&phy1>;
};
but there is no longer any definition of phy0 or phy1 anywhere in
cortina,gemini-ethernet.yaml, and the example no longer shows the MDIO bus
and PHY topology it used to illustrate.
If the mdio0 removal is deliberate, could it go into a separate patch that
also updates the phy-handle references?
>
> gmac1: ethernet-port@1 {
[ ... ]
> + phy-mode = "rgmii";
> + phy-handle = <&phy1>;
> };
> };
[ ... remaining files snipped, no comments ... ]
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260913122910.99457-3-krzysztof.kozlowski%40oss.qualcomm.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] dt-bindings: net: Use consistent indentation in the example
2026-09-14 12:50 ` netdev-bot+sashiko
@ 2026-09-14 15:52 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2026-09-14 15:52 UTC (permalink / raw)
To: netdev-bot+sashiko
Cc: robin.clark, lumag, abhinav.kumar, jesszhan0024, sean,
marijn.suijten, airlied, simona, maarten.lankhorst, mripard,
tzimmermann, robh, krzk+dt, conor+dt, justin.chen,
florian.fainelli, andrew+netdev, davem, edumazet, kuba, pabeni,
ulli.kroll, linusw, clement.leger, olteanv, hkallweit1, linux,
hayashi.kunihiko, mhiramat, nbd, lorenzo, ryder.lee, shayne.chen,
sean.wang, johannes, matthias.bgg, angelogioacchino.delregno,
jjohnson, richardcochran, geert+renesas, magnus.damm,
yongxing.mou, rfoss, abelvesa, vineetha.g.jaya.kumaran,
claudiu.manoil, alexandre.belloni, elder, s-vadapalli, rogerq,
linux-arm-msm, dri-devel, freedreno, devicetree, linux-kernel,
bcm-kernel-feedback-list, netdev, linux-arm-kernel,
linux-renesas-soc, linux-wireless, linux-mediatek, ath10k
On 14/09/2026 14:50, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue(s) to consider:
>
> Critical: 0 · High: 0 · Medium: 1 · Low: 0
>
> - [Medium] In Documentation/devicetree/bindings/net/cortina,gemini-
> ethernet.yaml the patch does more than re-indent: it deletes the whole…
Overly long, it's like use the most words to explain something to waste
other people time... I really dislike this approach but did complain and
people disagreed.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-09-14 15:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-13 12:29 [PATCH net-next] dt-bindings: net: Use consistent indentation in the example Krzysztof Kozlowski
2026-09-14 9:14 ` Claudiu Manoil
2026-09-14 9:17 ` Krzysztof Kozlowski
2026-09-14 12:50 ` netdev-bot+sashiko
2026-09-14 15:52 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®