* [RFC/PATCH] sched/fair: Remove unnecessary judgment in pick_next_task_fair()
@ 2024-09-09 5:13 Benjamin Tang
2024-09-09 11:26 ` Christian Loehle
0 siblings, 1 reply; 2+ messages in thread
From: Benjamin Tang @ 2024-09-09 5:13 UTC (permalink / raw)
To: Peter Zijlstra, Ingo Molnar
Cc: Vincent Guittot, Dietmar Eggemann, Juri Lelli, linux-kernel,
Benjamin Tang
sched/fair: Remove unnecessary judgment in pick_next_task_fair()
Since 'curr' argument is no longer needed in pick_next_entity(),
remove unnecessary judgment.
Signed-off-by: Benjamin Tang <tangsong8264@gmail.com>
---
kernel/sched/fair.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 9057584ec06d..92f8ad778205 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -8492,8 +8492,6 @@ pick_next_task_fair(struct rq *rq, struct
task_struct *prev, struct rq_flags *rf
if (curr) {
if (curr->on_rq)
update_curr(cfs_rq);
- else
- curr = NULL;
/*
* This call to check_cfs_rq_runtime() will do the
--
2.11.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [RFC/PATCH] sched/fair: Remove unnecessary judgment in pick_next_task_fair()
2024-09-09 5:13 [RFC/PATCH] sched/fair: Remove unnecessary judgment in pick_next_task_fair() Benjamin Tang
@ 2024-09-09 11:26 ` Christian Loehle
0 siblings, 0 replies; 2+ messages in thread
From: Christian Loehle @ 2024-09-09 11:26 UTC (permalink / raw)
To: Benjamin Tang, Peter Zijlstra, Ingo Molnar
Cc: Vincent Guittot, Dietmar Eggemann, Juri Lelli, linux-kernel
On 9/9/24 06:13, Benjamin Tang wrote:
> sched/fair: Remove unnecessary judgment in pick_next_task_fair()
>
> Since 'curr' argument is no longer needed in pick_next_entity(),
> remove unnecessary judgment.
>
> Signed-off-by: Benjamin Tang <tangsong8264@gmail.com>
> ---
> kernel/sched/fair.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 9057584ec06d..92f8ad778205 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -8492,8 +8492,6 @@ pick_next_task_fair(struct rq *rq, struct task_struct *prev, struct rq_flags *rf
> if (curr) {
> if (curr->on_rq)
> update_curr(cfs_rq);
> - else
> - curr = NULL;
>
> /*
> * This call to check_cfs_rq_runtime() will do the
This has been reworked on tip/sched/core and is no longer needed:
[PATCH 05/24] sched/fair: Unify pick_{,next_}_task_fair()
https://lore.kernel.org/all/20240727105028.725062368@infradead.org/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-09 11:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-09 5:13 [RFC/PATCH] sched/fair: Remove unnecessary judgment in pick_next_task_fair() Benjamin Tang
2024-09-09 11:26 ` Christian Loehle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®