From: Daniel Bristot de Oliveira <bristot@kernel.org>
To: Daniel Bristot de Oliveira <bristot@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>,
Joel Fernandes <joel@joelfernandes.org>
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
linux-kernel@vger.kernel.org,
Luca Abeni <luca.abeni@santannapisa.it>,
Tommaso Cucinotta <tommaso.cucinotta@santannapisa.it>,
Thomas Gleixner <tglx@linutronix.de>,
Vineeth Pillai <vineeth@bitbyteword.org>,
Shuah Khan <skhan@linuxfoundation.org>,
Phil Auld <pauld@redhat.com>
Subject: Re: [PATCH v5 6/7] sched/deadline: Deferrable dl server
Date: Tue, 7 Nov 2023 19:50:28 +0100 [thread overview]
Message-ID: <3e58fad7-7f66-4e48-adcc-0fda9e9d0d07@kernel.org> (raw)
In-Reply-To: <7d1ea71b-5218-4ee0-bc89-f02ee6bd5154@redhat.com>
> The code is not doing what I intended because I thought it was doing overload
> control on the replenishment, but it is not (my bad).
>
I am still testing but... it is missing something like this (famous last words).
diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index 1092ca8892e0..6e2d21c47a04 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -842,6 +842,8 @@ static inline void setup_new_dl_entity(struct sched_dl_entity *dl_se)
* runtime, or it just underestimated it during sched_setattr().
*/
static int start_dl_timer(struct sched_dl_entity *dl_se);
+static bool dl_entity_overflow(struct sched_dl_entity *dl_se, u64 t);
+
static void replenish_dl_entity(struct sched_dl_entity *dl_se)
{
struct dl_rq *dl_rq = dl_rq_of_se(dl_se);
@@ -852,9 +854,18 @@ static void replenish_dl_entity(struct sched_dl_entity *dl_se)
/*
* This could be the case for a !-dl task that is boosted.
* Just go with full inherited parameters.
+ *
+ * Or, it could be the case of a zerolax reservation that
+ * was not able to consume its runtime in background and
+ * reached this point with current u > U.
+ *
+ * In both cases, set a new period.
*/
- if (dl_se->dl_deadline == 0)
- replenish_dl_new_period(dl_se, rq);
+ if (dl_se->dl_deadline == 0 ||
+ (dl_se->dl_zerolax_armed && dl_entity_overflow(dl_se, rq_clock(rq)))) {
+ dl_se->deadline = rq_clock(rq) + pi_of(dl_se)->dl_deadline;
+ dl_se->runtime = pi_of(dl_se)->dl_runtime;
+ }
if (dl_se->dl_yielded && dl_se->runtime > 0)
dl_se->runtime = 0;
next prev parent reply other threads:[~2023-11-07 18:50 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-04 10:59 [PATCH v5 0/7] SCHED_DEADLINE server infrastructure Daniel Bristot de Oliveira
2023-11-04 10:59 ` [PATCH v5 1/7] sched: Unify runtime accounting across classes Daniel Bristot de Oliveira
2023-11-15 9:04 ` [tip: sched/core] " tip-bot2 for Peter Zijlstra
2023-11-04 10:59 ` [PATCH v5 2/7] sched/deadline: Collect sched_dl_entity initialization Daniel Bristot de Oliveira
2023-11-15 9:04 ` [tip: sched/core] " tip-bot2 for Peter Zijlstra
2023-11-04 10:59 ` [PATCH v5 3/7] sched/deadline: Move bandwidth accounting into {en,de}queue_dl_entity Daniel Bristot de Oliveira
2023-11-15 9:04 ` [tip: sched/core] " tip-bot2 for Peter Zijlstra
2023-11-04 10:59 ` [PATCH v5 4/7] sched/deadline: Introduce deadline servers Daniel Bristot de Oliveira
2023-11-15 9:04 ` [tip: sched/core] " tip-bot2 for Peter Zijlstra
2023-11-04 10:59 ` [PATCH v5 5/7] sched/fair: Add trivial fair server Daniel Bristot de Oliveira
2023-11-06 14:24 ` Peter Zijlstra
2023-11-06 14:26 ` Daniel Bristot de Oliveira
2023-11-04 10:59 ` [PATCH v5 6/7] sched/deadline: Deferrable dl server Daniel Bristot de Oliveira
2023-11-06 14:55 ` Peter Zijlstra
2023-11-06 17:05 ` Daniel Bristot de Oliveira
2023-11-06 19:32 ` Joel Fernandes
2023-11-06 21:32 ` Joel Fernandes
2023-11-06 21:37 ` Joel Fernandes
2023-11-07 11:58 ` Daniel Bristot de Oliveira
2023-11-08 2:42 ` Joel Fernandes
2023-11-07 16:47 ` Steven Rostedt
2023-11-07 17:35 ` Steven Rostedt
2023-11-07 17:46 ` Steven Rostedt
2023-11-07 17:54 ` Steven Rostedt
2023-11-07 19:32 ` Steven Rostedt
2023-11-07 20:07 ` Steven Rostedt
2023-11-07 17:37 ` Daniel Bristot de Oliveira
2023-11-07 18:50 ` Daniel Bristot de Oliveira [this message]
2023-11-08 3:20 ` Joel Fernandes
2023-11-08 8:01 ` Daniel Bristot de Oliveira
2023-11-08 18:25 ` Joel Fernandes
2023-11-08 12:44 ` Peter Zijlstra
2023-11-08 12:50 ` Peter Zijlstra
2023-11-08 14:52 ` Daniel Bristot de Oliveira
2023-11-08 13:46 ` Daniel Bristot de Oliveira
2023-11-08 13:58 ` Daniel Bristot de Oliveira
2023-11-08 15:14 ` Juri Lelli
2023-11-08 16:57 ` Peter Zijlstra
2023-11-08 2:37 ` Joel Fernandes
2023-11-07 7:30 ` Daniel Bristot de Oliveira
2023-11-07 16:37 ` Steven Rostedt
2023-11-13 15:05 ` kernel test robot
2024-03-20 0:03 ` Joel Fernandes
2024-03-20 19:24 ` Daniel Bristot de Oliveira
2024-03-21 16:15 ` Joel Fernandes
2024-03-23 14:37 ` Joel Fernandes
2024-04-05 14:35 ` Daniel Bristot de Oliveira
2024-04-08 17:11 ` Steven Rostedt
2023-11-04 10:59 ` [PATCH v5 7/7] sched/fair: Fair server interface Daniel Bristot de Oliveira
2023-11-04 15:18 ` kernel test robot
2023-11-05 0:55 ` kernel test robot
2023-11-06 15:40 ` Peter Zijlstra
2023-11-06 16:29 ` Daniel Bristot de Oliveira
2023-11-07 8:16 ` Peter Zijlstra
2023-11-07 14:06 ` Daniel Bristot de Oliveira
2023-11-07 14:44 ` Peter Zijlstra
2023-11-07 12:38 ` Peter Zijlstra
2023-11-07 13:24 ` Daniel Bristot de Oliveira
2024-01-19 1:49 ` Joel Fernandes
2024-01-19 1:55 ` Joel Fernandes
2024-01-22 14:14 ` Daniel Bristot de Oliveira
2024-01-23 15:39 ` Joel Fernandes
2024-01-23 15:44 ` Joel Fernandes
2024-02-13 2:13 ` Joel Fernandes
2024-02-13 2:21 ` Joel Fernandes
2024-02-14 14:23 ` Daniel Bristot de Oliveira
2024-02-15 13:57 ` Joel Fernandes
2024-02-15 17:27 ` Daniel Bristot de Oliveira
2024-02-15 17:41 ` Joel Fernandes
2024-04-04 17:43 ` Daniel Bristot de Oliveira
2023-12-08 21:47 ` [PATCH v5 0/7] SCHED_DEADLINE server infrastructure Joel Fernandes
2024-02-19 7:33 ` Huang, Ying
2024-02-19 10:23 ` Daniel Bristot de Oliveira
2024-02-20 3:28 ` Huang, Ying
2024-02-20 8:31 ` Daniel Bristot de Oliveira
2024-02-20 8:41 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e58fad7-7f66-4e48-adcc-0fda9e9d0d07@kernel.org \
--to=bristot@kernel.org \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=joel@joelfernandes.org \
--cc=juri.lelli@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.abeni@santannapisa.it \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=pauld@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=skhan@linuxfoundation.org \
--cc=tglx@linutronix.de \
--cc=tommaso.cucinotta@santannapisa.it \
--cc=vincent.guittot@linaro.org \
--cc=vineeth@bitbyteword.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome