* [PATCH] wifi: brcmfmac: wcc: Add debug messages
@ 2023-05-09 10:04 matthias.bgg
2023-05-09 10:27 ` Hans de Goede
2023-05-15 18:25 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: matthias.bgg @ 2023-05-09 10:04 UTC (permalink / raw)
To: Arend van Spriel, Franky Lin, Hante Meuleman, Kalle Valo, Paolo Abeni
Cc: brcm80211-dev-list.pdl, netdev, linux-wireless, linux-kernel,
Hans de Goede, SHA-cyfmac-dev-list, Pieter-Paul Giesberts,
Matthias Brugger, David S. Miller, Eric Dumazet, Jakub Kicinski
From: Matthias Brugger <mbrugger@suse.com>
The message is attach and detach function are merly for debugging,
change them from pr_err to pr_debug.
Signed-off-by: Matthias Brugger <mbrugger@suse.com>
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/core.c
index 02de99818efa..5573a47766ad 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/core.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/core.c
@@ -12,13 +12,13 @@
static int brcmf_wcc_attach(struct brcmf_pub *drvr)
{
- pr_err("%s: executing\n", __func__);
+ pr_debug("%s: executing\n", __func__);
return 0;
}
static void brcmf_wcc_detach(struct brcmf_pub *drvr)
{
- pr_err("%s: executing\n", __func__);
+ pr_debug("%s: executing\n", __func__);
}
const struct brcmf_fwvid_ops brcmf_wcc_ops = {
--
2.40.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] wifi: brcmfmac: wcc: Add debug messages
2023-05-09 10:04 [PATCH] wifi: brcmfmac: wcc: Add debug messages matthias.bgg
@ 2023-05-09 10:27 ` Hans de Goede
2023-05-15 18:25 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2023-05-09 10:27 UTC (permalink / raw)
To: matthias.bgg, Arend van Spriel, Franky Lin, Hante Meuleman,
Kalle Valo, Paolo Abeni
Cc: brcm80211-dev-list.pdl, netdev, linux-wireless, linux-kernel,
SHA-cyfmac-dev-list, Pieter-Paul Giesberts, Matthias Brugger,
David S. Miller, Eric Dumazet, Jakub Kicinski
Hi,
On 5/9/23 12:04, matthias.bgg@kernel.org wrote:
> From: Matthias Brugger <mbrugger@suse.com>
>
> The message is attach and detach function are merly for debugging,
> change them from pr_err to pr_debug.
>
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
Thank you, I had writing this same patch on my own TODO list :)
Patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
>
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/core.c
> index 02de99818efa..5573a47766ad 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/core.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/wcc/core.c
> @@ -12,13 +12,13 @@
>
> static int brcmf_wcc_attach(struct brcmf_pub *drvr)
> {
> - pr_err("%s: executing\n", __func__);
> + pr_debug("%s: executing\n", __func__);
> return 0;
> }
>
> static void brcmf_wcc_detach(struct brcmf_pub *drvr)
> {
> - pr_err("%s: executing\n", __func__);
> + pr_debug("%s: executing\n", __func__);
> }
>
> const struct brcmf_fwvid_ops brcmf_wcc_ops = {
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: wifi: brcmfmac: wcc: Add debug messages
2023-05-09 10:04 [PATCH] wifi: brcmfmac: wcc: Add debug messages matthias.bgg
2023-05-09 10:27 ` Hans de Goede
@ 2023-05-15 18:25 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2023-05-15 18:25 UTC (permalink / raw)
To: matthias.bgg
Cc: Arend van Spriel, Franky Lin, Hante Meuleman, Paolo Abeni,
brcm80211-dev-list.pdl, netdev, linux-wireless, linux-kernel,
Hans de Goede, SHA-cyfmac-dev-list, Pieter-Paul Giesberts,
Matthias Brugger, David S. Miller, Eric Dumazet, Jakub Kicinski
matthias.bgg@kernel.org wrote:
> From: Matthias Brugger <mbrugger@suse.com>
>
> The message is attach and detach function are merly for debugging,
> change them from pr_err to pr_debug.
>
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Patch applied to wireless-next.git, thanks.
87807f77a03d wifi: brcmfmac: wcc: Add debug messages
--
https://patchwork.kernel.org/project/linux-wireless/patch/20230509100420.26094-1-matthias.bgg@kernel.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-15 18:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-09 10:04 [PATCH] wifi: brcmfmac: wcc: Add debug messages matthias.bgg
2023-05-09 10:27 ` Hans de Goede
2023-05-15 18:25 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®