Re: [PATCH 1/8] dt-bindings: mailbox: mediatek: Add GCE header file for MT8196

["Jason-JH Lin (林睿祥)" <Jason-JH.Lin@mediatek.com>]

Hi Krzysztof,

Thanks for the reviews.

On Thu, 2024-11-21 at 09:42 +0100, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> On Thu, Nov 21, 2024 at 12:25:55PM +0800, Jason-JH.Lin wrote:
> > Add the Global Command Engine (GCE) header file to define the GCE
> > thread priority, GCE subsys ID, GCE events, and various constants
> > for MT8196.
> 
> NAK, various constants are not bindings.
> 

OK, I'll drop the constants.

> > 
> > Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
> > ---
> >  .../dt-bindings/mailbox/mediatek,mt8196-gce.h | 1449
> > +++++++++++++++++
> >  1 file changed, 1449 insertions(+)
> >  create mode 100755 include/dt-bindings/mailbox/mediatek,mt8196-
> > gce.h
> 
> Please run scripts/checkpatch.pl and fix reported warnings. Then
> please
> run 'scripts/checkpatch.pl --strict' and (probably) fix more
> warnings.
> Some warnings can be ignored, especially from --strict run, but the
> code
> here looks like it needs a fix. Feel free to get in touch if the
> warning
> is not clear.
> 
> This goes with the binding.
> 

I thought I have done that, but I found a whitespace warning at #1328
now. I'll fix that at the next version.
Thanks for the reminder.

Regards,
Jason-JH.Lin


> Best regards,
> Krzysztof
>