From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Jason-JH Lin (林睿祥)" <Jason-JH.Lin@mediatek.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"Singo Chang (張興國)" <Singo.Chang@mediatek.com>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"chunkuang.hu@kernel.org" <chunkuang.hu@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"simona@ffwll.ch" <simona@ffwll.ch>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"Moudy Ho (何宗原)" <Moudy.Ho@mediatek.com>,
"Nancy Lin (林欣螢)" <Nancy.Lin@mediatek.com>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"robh@kernel.org" <robh@kernel.org>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
"airlied@gmail.com" <airlied@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"jassisinghbrar@gmail.com" <jassisinghbrar@gmail.com>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>
Subject: Re: [PATCH 1/8] dt-bindings: mailbox: mediatek: Add GCE header file for MT8196
Date: Thu, 21 Nov 2024 12:48:40 +0100 [thread overview]
Message-ID: <c3f52576-918d-4e0f-8247-46cb468e5c77@kernel.org> (raw)
In-Reply-To: <40971559285bb60cbab476135ba81d364505113c.camel@mediatek.com>
On 21/11/2024 11:51, Jason-JH Lin (林睿祥) wrote:
>>> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
>>> ---
>>> .../dt-bindings/mailbox/mediatek,mt8196-gce.h | 1449
>>> +++++++++++++++++
>>> 1 file changed, 1449 insertions(+)
>>> create mode 100755 include/dt-bindings/mailbox/mediatek,mt8196-
>>> gce.h
>>
>> Please run scripts/checkpatch.pl and fix reported warnings. Then
>> please
>> run 'scripts/checkpatch.pl --strict' and (probably) fix more
>> warnings.
>> Some warnings can be ignored, especially from --strict run, but the
>> code
>> here looks like it needs a fix. Feel free to get in touch if the
>> warning
>> is not clear.
>>
>> This goes with the binding.
>>
>
> I thought I have done that, but I found a whitespace warning at #1328
> now. I'll fix that at the next version.
> Thanks for the reminder.
There are multiple errors, including executable permission. I don't
believe you run checkpatch.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-11-21 11:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-21 4:25 [PATCH 0/8] Add GCE support " Jason-JH.Lin
2024-11-21 4:25 ` [PATCH 1/8] dt-bindings: mailbox: mediatek: Add GCE header file " Jason-JH.Lin
2024-11-21 8:42 ` Krzysztof Kozlowski
2024-11-21 10:51 ` Jason-JH Lin (林睿祥)
2024-11-21 11:48 ` Krzysztof Kozlowski [this message]
2024-11-21 15:47 ` Jason-JH Lin (林睿祥)
2024-11-21 4:25 ` [PATCH 2/8] dt-bindings: mailbox: mediatek: Add MT8196 support for gce-mailbox Jason-JH.Lin
2024-11-21 4:25 ` [PATCH 3/8] mailbox: mtk-cmdq: Add driver data to support for MT8196 Jason-JH.Lin
2024-11-21 4:25 ` [PATCH 4/8] soc: mediatek: mtk-cmdq: Add unsupported subsys ID programing flow Jason-JH.Lin
2024-11-21 6:38 ` CK Hu (胡俊光)
2024-11-21 7:10 ` CK Hu (胡俊光)
2024-11-21 10:41 ` Jason-JH Lin (林睿祥)
2024-11-21 4:25 ` [PATCH 5/8] soc: mediatek: mtk-cmdq: Add mminfra_offset compatibility for DRAM address Jason-JH.Lin
2024-11-21 4:26 ` [PATCH 6/8] soc: mediatek: Add pa_base due to CMDQ API change Jason-JH.Lin
2024-11-21 4:26 ` [PATCH 7/8] drm/mediatek: " Jason-JH.Lin
2024-11-21 4:26 ` [PATCH 8/8] media: mediatek: mdp3: " Jason-JH.Lin
2024-11-21 8:55 ` [PATCH 0/8] Add GCE support for MT8196 AngeloGioacchino Del Regno
2024-11-21 11:21 ` Jason-JH Lin (林睿祥)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3f52576-918d-4e0f-8247-46cb468e5c77@kernel.org \
--to=krzk@kernel.org \
--cc=Jason-JH.Lin@mediatek.com \
--cc=Moudy.Ho@mediatek.com \
--cc=Nancy.Lin@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=Singo.Chang@mediatek.com \
--cc=airlied@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jassisinghbrar@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®