Re: [PATCH 4/4] scsi: ufs: tegra: Add Tegra264 UFS host controller driver

[Kartik Rajput <kkartik@nvidia.com>]

Hi Uwe,

On 09/09/26 19:50, Uwe Kleine-König wrote:
> Hello,
> 
> On Wed, Sep 09, 2026 at 04:11:22PM +0530, Kartik Rajput wrote:
>> +#include <linux/bitfield.h>
>> +#include <linux/clk.h>
>> +#include <linux/delay.h>
>> +#include <linux/dma-mapping.h>
>> +#include <linux/mod_devicetable.h>
> 
> Please don't add new instances of includes for
> <linux/mod_devicetable.h>.  Either rely on <linux/platform_device.h> to
> provide of_device_id (my preferred way), or use <linux/device-id/of.h>
> if you want full iwyu.
> 

ACK. I will use <linux/platform_device.h>.

>> +#include <linux/of.h>
>> +#include <linux/phy/phy.h>
>> +#include <linux/platform_device.h>
>> +#include <linux/reset.h>
>> [...]
>> +static const struct of_device_id ufs_tegra_of_match[] = {
>> +	{ .compatible = "nvidia,tegra264-ufs", },
> 
> No trailing comma before a } please
> 

ACK.

>> +	{}
> 
> { } please (i.e. a space between the braces)
> 

ACK.

Thanks,
Kartik