Re: [PATCH 4/4] scsi: ufs: tegra: Add Tegra264 UFS host controller driver

[Kartik Rajput <kkartik@nvidia.com>]

On 22/09/26 15:02, Kartik Rajput wrote:
> Hi Uwe, Bart,
> 
> Thanks for reviewing the patch.
> 
> On 10/09/26 19:22, Uwe Kleine-König wrote:
>> Hello Bart,
>>
>> On Thu, Sep 10, 2026 at 06:09:30AM -0700, Bart Van Assche wrote:
>>> On 9/10/26 4:21 AM, Uwe Kleine-König wrote:
>>>> What makes you claim that {} is preferred?
>>>
>>> There are many more occurrences of " = {};" (about 7000) in the Linux
>>> kernel than of " = { };" (about 1500). Additionally, clang-format
>>> changes any occurrence of " = { };" into " = {};".
>>
>> clang-format does this due to
>>
>>     SpaceInEmptyParentheses: false
>>
>> in .clang-format which I claim we have due to prefering no space between
>> () for function calls. It seems only newer clang-format (starting with
>> version 22) can configure that individually using SpaceInEmptyBraces.
>>
>> And IMHO my statistic is more relevant because we're not talking about
>> `= {};` or `= { };`.
>>
>> But I guess this is all subjective. Having said that I feel offended
>> when seeing "= {};" and would ask to add a space there, too, when
>> spotting that during a review.
>>
>> Best regards
>> Uwe
> 
> ACK, I will use `{}` instead of `{ }`. Or if you prefer, I can use `{ /* sentinel */ }`.
> 

Apologies, `{ }` instead of `{}`

Thanks,
Kartik