Re: [PATCH 1/4] dt-bindings: ufs: Add nvidia,tegra264-ufs

[Kartik Rajput <kkartik@nvidia.com>]

Hi Krzysztof,

Thanks for reviewing the patch and apologies for the delayed response.

On 13/09/26 14:10, Krzysztof Kozlowski wrote:
> External email: Use caution opening links or attachments
> 
> 
> On Wed, Sep 09, 2026 at 04:11:19PM +0530, Kartik Rajput wrote:
>> +  clocks:
>> +    items:
>> +      - description: UFS host controller functional clock
>> +      - description: UFS host controller divider clock
>> +      - description: UFS reference clock (PLLREFUFS output)
>> +      - description: UFS device-side reference clock
>> +      - description: M-PHY reference clock (UPHY0 PLL4 digital output)
>> +
>> +  clock-names:
>> +    items:
>> +      - const: ufs
> 
> core? Names equal to block name are not really useful
> 

ACK. Will rename it to "core".

>> +      - const: div
>> +      - const: ref
>> +      - const: ref-dev
>> +      - const: phy
> 
> Shouldn't the phy take its reference clock?
> 

The name is misleading and the description is wrong, I will fix both.

The M-PHY's own reference clock and PLL are already described in the
M-PHY node ("tx-ref" and "pll"), this is a different clock, UPHY0 PLL4's
digital output, consumed by the host controller.


>> +allOf:
>> +  - $ref: ufs-common.yaml
>> +
>> +unevaluatedProperties: false
>> +
>> +examples:
>> +  - |
>> +    #include <dt-bindings/clock/nvidia,tegra264.h>
>> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
>> +    #include <dt-bindings/phy/nvidia,tegra264-mphy.h>
> 
> You need to decouple dependencies. Otherwise how is this supposed to be
> checked with tools? If applied, you just broke maintainer's tree.
> 
> 

ACK. I will drop the include and use raw cell values in the
example:

     phys = <&mphy 0>, <&mphy 1>, <&mphy 2>, <&mphy 3>;

Thanks,
Kartik