From: "Shem Multinymous" <multinymous@gmail.com>
To: "Pavel Machek" <pavel@ucw.cz>
Cc: "Darrick J. Wong" <djwong@us.ibm.com>,
"Jean Delvare" <khali@linux-fr.org>,
"Henrique de Moraes Holschuh" <hmh@hmh.eng.br>,
"Mark M. Hoffman" <mhoffman@lightlink.com>,
linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: Re: [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface
Date: Sat, 1 Sep 2007 14:05:03 -0400 [thread overview]
Message-ID: <41840b750709011105s6c434217t50d965a0b17df643@mail.gmail.com> (raw)
In-Reply-To: <20070901171048.GA3883@ucw.cz>
On 9/1/07, Pavel Machek <pavel@ucw.cz> wrote:
> > diff --git a/Documentation/hwmon/sysfs-interface b/Documentation/hwmon/sysfs-interface
> > index b3a9e1b..da546ce 100644
> > --- a/Documentation/hwmon/sysfs-interface
> > +++ b/Documentation/hwmon/sysfs-interface
> > @@ -304,6 +304,21 @@ curr[1-*]_input Current input value
> > Unit: milliampere
> > RO
> >
> > +*********
> > +* Power *
> > +*********
> > +
> > +power[1-*]_input Current power use
> > + Unit: milliWatt
> > + RO
> > +
> > +power[1-*]_max_input Historical maximum power use
> > + Unit: milliWatt
> > + RO
> > +
> > +power[1-*]_min_input Historical minimum power use
> > + Unit: milliWatt
> > + RO
>
> Should we add power?_10sec_avg_input? IIRC thinkpads export that,
> too.
Indeed, ThinkPads report both instantaneous power/current and a
rolling average (exponentially decaying, I think) over the last ~10
seconds. ACPI provides only the rolling average, and the out-of-tree
tp_smapi driver provides both.
More generally, linux/power_supply.h defines these attributes:
POWER_SUPPLY_PROP_VOLTAGE_NOW,
POWER_SUPPLY_PROP_VOLTAGE_AVG,
POWER_SUPPLY_PROP_CURRENT_NOW,
POWER_SUPPLY_PROP_CURRENT_AVG,
It would be nice if the power meter interface uses the same
conventions as the power supply interface, since the former is
essentially a subset of the latter. Userspace app that read power
meters via sysfs should work for power supplies too.
Shem
next prev parent reply other threads:[~2007-09-01 18:05 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-27 21:14 [PATCH] v1 of IBM power meter driver Darrick J. Wong
2007-08-28 1:50 ` Henrique de Moraes Holschuh
2007-08-28 11:19 ` [lm-sensors] " Jean Delvare
2007-08-28 16:28 ` Darrick J. Wong
2007-08-29 9:49 ` Jean Delvare
2007-08-29 12:45 ` Frank Phillips
2007-08-28 16:44 ` [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface Darrick J. Wong
2007-08-29 9:10 ` Jean Delvare
2007-08-29 14:50 ` Darrick J. Wong
2007-08-30 9:57 ` Jean Delvare
2007-09-11 16:43 ` Darrick J. Wong
2007-09-01 17:10 ` Pavel Machek
2007-09-01 18:05 ` Shem Multinymous [this message]
2007-09-01 19:44 ` [lm-sensors] " Henrique de Moraes Holschuh
2007-09-02 19:38 ` Jean Delvare
2007-09-03 2:02 ` Henrique de Moraes Holschuh
2007-09-03 16:06 ` Jean Delvare
2007-09-03 23:22 ` Henrique de Moraes Holschuh
2007-09-06 9:34 ` Jean Delvare
2007-09-06 16:29 ` Henrique de Moraes Holschuh
2007-08-28 16:49 ` [PATCH] v2 of IBM power meter driver Darrick J. Wong
2007-08-28 23:25 ` [PATCH] v3 " Darrick J. Wong
2007-09-11 13:23 ` Mark M. Hoffman
2007-09-11 13:59 ` Jean Delvare
2007-09-12 1:11 ` Darrick J. Wong
2007-09-14 19:29 ` [PATCH v2] hwmon: Update Documentation/hwmon/sysfs-interface Darrick J. Wong
2007-09-17 17:28 ` Jean Delvare
2007-09-17 18:43 ` Darrick J. Wong
2007-09-21 8:43 ` Jean Delvare
2007-09-14 19:33 ` [PATCH v4] IBM power meter driver Darrick J. Wong
2007-10-09 12:00 ` Mark M. Hoffman
2007-10-09 16:44 ` Roel Kluin
2007-10-09 20:40 ` Darrick J. Wong
2007-10-09 22:08 ` [PATCH] ibmpex: Release IPMI user if hwmon registration fails Darrick J. Wong
2007-10-11 11:45 ` Mark M. Hoffman
2007-10-13 0:29 ` [PATCH v4] IBM power meter driver Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41840b750709011105s6c434217t50d965a0b17df643@mail.gmail.com \
--to=multinymous@gmail.com \
--cc=djwong@us.ibm.com \
--cc=hmh@hmh.eng.br \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=mhoffman@lightlink.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®