From: "Jean Delvare" <khali@linux-fr.org>
To: mhoffman@lightlink.com, djwong@us.ibm.com
Cc: "Henrique de Moraes Holschuh" <hmh@hmh.eng.br>,
linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org,
haveblue@us.ibm.com
Subject: Re: [PATCH] v3 of IBM power meter driver
Date: Tue, 11 Sep 2007 15:59:31 +0200 (CEST) [thread overview]
Message-ID: <QsqPsE00.1189519171.8421320.khali@localhost> (raw)
In-Reply-To: <20070911132335.GJ31992@jupiter.solarsys.private>
On 9/11/2007, "Mark M. Hoffman" <mhoffman@lightlink.com> wrote:
>* Darrick J. Wong <djwong@us.ibm.com> [2007-08-28 16:25:05 -0700]:
>> --- a/drivers/hwmon/Kconfig
>> +++ b/drivers/hwmon/Kconfig
>> @@ -275,6 +275,18 @@ config SENSORS_CORETEMP
>> sensor inside your CPU. Supported all are all known variants
>> of Intel Core family.
>>
>> +config SENSORS_IBMPEX
>> + tristate "IBM PowerExecutive temperature/power sensors"
>> + depends on IPMI_SI
>
> Open question: can we use "select" here? As written, it took some hunting
> to even get this driver to show up as an option in menuconfig.
My 2 cents: I assume that people who have IPMI-capable hardware are aware
that they do. Thus, if you change the above to "select IPMI_SI", you
probably want to add "depends on IPMI_HANDLER" (not sure why it's not
just named CONFIG_IPMI).
--
Jean Delvare
next prev parent reply other threads:[~2007-09-11 14:00 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-27 21:14 [PATCH] v1 " Darrick J. Wong
2007-08-28 1:50 ` Henrique de Moraes Holschuh
2007-08-28 11:19 ` [lm-sensors] " Jean Delvare
2007-08-28 16:28 ` Darrick J. Wong
2007-08-29 9:49 ` Jean Delvare
2007-08-29 12:45 ` Frank Phillips
2007-08-28 16:44 ` [PATCH] hwmon: Add power meters to Documentation/hwmon/sysfs-interface Darrick J. Wong
2007-08-29 9:10 ` Jean Delvare
2007-08-29 14:50 ` Darrick J. Wong
2007-08-30 9:57 ` Jean Delvare
2007-09-11 16:43 ` Darrick J. Wong
2007-09-01 17:10 ` Pavel Machek
2007-09-01 18:05 ` Shem Multinymous
2007-09-01 19:44 ` [lm-sensors] " Henrique de Moraes Holschuh
2007-09-02 19:38 ` Jean Delvare
2007-09-03 2:02 ` Henrique de Moraes Holschuh
2007-09-03 16:06 ` Jean Delvare
2007-09-03 23:22 ` Henrique de Moraes Holschuh
2007-09-06 9:34 ` Jean Delvare
2007-09-06 16:29 ` Henrique de Moraes Holschuh
2007-08-28 16:49 ` [PATCH] v2 of IBM power meter driver Darrick J. Wong
2007-08-28 23:25 ` [PATCH] v3 " Darrick J. Wong
2007-09-11 13:23 ` Mark M. Hoffman
2007-09-11 13:59 ` Jean Delvare [this message]
2007-09-12 1:11 ` Darrick J. Wong
2007-09-14 19:29 ` [PATCH v2] hwmon: Update Documentation/hwmon/sysfs-interface Darrick J. Wong
2007-09-17 17:28 ` Jean Delvare
2007-09-17 18:43 ` Darrick J. Wong
2007-09-21 8:43 ` Jean Delvare
2007-09-14 19:33 ` [PATCH v4] IBM power meter driver Darrick J. Wong
2007-10-09 12:00 ` Mark M. Hoffman
2007-10-09 16:44 ` Roel Kluin
2007-10-09 20:40 ` Darrick J. Wong
2007-10-09 22:08 ` [PATCH] ibmpex: Release IPMI user if hwmon registration fails Darrick J. Wong
2007-10-11 11:45 ` Mark M. Hoffman
2007-10-13 0:29 ` [PATCH v4] IBM power meter driver Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=QsqPsE00.1189519171.8421320.khali@localhost \
--to=khali@linux-fr.org \
--cc=djwong@us.ibm.com \
--cc=haveblue@us.ibm.com \
--cc=hmh@hmh.eng.br \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=mhoffman@lightlink.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®