From: Marcel Holtmann <marcel@holtmann.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Michael Buesch <mb@bu3sch.de>,
David Woodhouse <dwmw2@infradead.org>,
Sam Ravnborg <sam@ravnborg.org>,
linux-kernel@vger.kernel.org, aoliva@redhat.com,
alan@lxorguk.ukuu.org.uk, Abhay Salunke <Abhay_Salunke@dell.com>,
kay.sievers@vrfy.org, Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option
Date: Sun, 25 May 2008 20:23:46 +0200 [thread overview]
Message-ID: <41FE0259-522B-4B9B-A75D-7B97A9FD723F@holtmann.org> (raw)
In-Reply-To: <1211724803.17151.36.camel@johannes.berg>
Hi Johannes,
>> No it is not. The kobject doesn't allow "/" and why should
>> request_firmware() be an exception. Also see my other comment on how
>> the kernel handles device nodes and on how udev maps them to real
>> device nodes on the filesystem.
>
> As I said, kobjects have nothing to do with it, they don't need to
> have
> a filename based on the firmware key.
our current usage is suboptimal and we should use kobjects for
representing the loading entity. Please keep in mind that when we
created request_firmware() most of the driver model developers still
thought that having class devices was a good idea. That has changed
and to represent firmware loading in a clean and race free environment
where you could load multipl firmwares at the same time for the same
driver, we need changes here.
>> And again. This is up to the userspace to handle and not the kernel.
>> In userspace you could do a general approach to support these kind of
>> testing, but you decide to only do this for your driver. You are
>> fully
>> exploiting the request_firmware() interface and making any kind of
>> userspace policy impossible. This in return actually means that if we
>> would improve the request_firmware(), we have to maintain special
>> cases for the b43 drivers, because your driver does some hacking of
>> firmware files inside the kernel. You actually proved my point that
>> we
>> should not allow this inside the kernel.
>
> That makes no sense at all.
>
> Michael is exploiting the firmware API that you are suggesting to
> change, and so far I don't see a technical reason for changing it. In
> kernel space, he's simply requesting varying firmware blobs based on
> different keys, which happen to be "b43%s/%s" because that's making
> things simpler for him on the other end.
>
> On the other hand, you're saying that we have all kinds of policy
> about
> this in userspace, so why are you saying that directory separators
> (slashes, but you seem to distinguish those on some level I do not
> understand) should be special in the firmware key?
>
> The firmware key is just that, a *key*. It's only exposed to userspace
> via an environment variable in a kobject named
> "/devices/pci0001:10/0001:10:12.0/ssb0:0/firmware/ssb0:0" or similar.
>
> The fact that userspace uses the key as a filename is maybe
> unfortunate,
> maybe fortunate, but shouldn't have anything to do with what sort of
> keys the kernel allows.
I disagree with you. The kernel should be free of these kind of
subdirectory stuff. We saw devfs failing and we have a flat device
node names in the kernel. Why do we have to duplicate information in
the firmware filenames where we have all the information already
present in the driver model. The reason that people are lazy doesn't
work for me.
> Also, you said above (quoting again):
>
>> You are fully
>> exploiting the request_firmware() interface and making any kind of
>> userspace policy impossible.
>
> That's not true at all. If you decide that the userspace policy should
> be to load $modulename/$firmwarekey then you'd maybe have something
> like /lib/firmware/b43/b43-test/ucode5.fw
> and /lib/firmware/b43/b43-osfw/ucode5.fw
> and /lib/firmware/b43/b43/ucode5.fw, this doesn't preclude the use.
>
> Now, if it had been like that from the beginning, Michael probably
> wouldn't have used the string "b43" (or "b43-*") but rather requested
> "broadcom/ucode5.fw" by default and "osfw/ucode5.fw" for the open
> source
> firmware, but since it's just a key that doesn't matter.
That something works at the moment is not a reason for me not to fix
it and improve the current framework around firmware loading. I have
been a lot of times saying that the request_firmware() should not
include "/" in the filename and driver authors followed it. Some of
them did it anyway and so these need fixing now.
Regards
Marcel
next prev parent reply other threads:[~2008-05-25 18:24 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-23 13:44 [PATCH 1/3] firmware: allow firmware files to be built into kernel image David Woodhouse
2008-05-23 13:46 ` [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option David Woodhouse
2008-05-23 13:50 ` [PATCH 2/3] firmware: convert korg1212 driver to use firmware loader exclusively David Woodhouse
2008-05-23 14:56 ` Takashi Iwai
2008-05-23 14:59 ` David Woodhouse
2008-05-23 16:41 ` [PATCH 2/3] firmware: Add CONFIG_BUILTIN_FIRMWARE option Sam Ravnborg
2008-05-23 17:13 ` David Woodhouse
2008-05-23 18:07 ` David Woodhouse
2008-05-23 18:11 ` Sam Ravnborg
2008-05-24 14:46 ` David Woodhouse
2008-05-24 15:22 ` Sam Ravnborg
2008-05-24 15:25 ` David Woodhouse
2008-05-24 15:34 ` David Woodhouse
2008-05-24 18:18 ` Marcel Holtmann
2008-05-24 19:23 ` David Woodhouse
2008-05-24 19:31 ` Marcel Holtmann
2008-05-25 9:30 ` Johannes Berg
2008-05-25 9:49 ` Michael Buesch
2008-05-25 11:54 ` Marcel Holtmann
2008-05-25 12:14 ` Michael Buesch
2008-05-25 13:16 ` Alan Cox
2008-05-25 13:46 ` David Woodhouse
2008-05-25 18:07 ` Marcel Holtmann
2008-05-25 11:49 ` Marcel Holtmann
2008-05-25 11:59 ` Johannes Berg
2008-05-25 13:12 ` Marcel Holtmann
2008-05-25 13:40 ` Johannes Berg
2008-05-25 18:12 ` Marcel Holtmann
2008-05-25 18:18 ` Michael Buesch
2008-05-25 18:28 ` Marcel Holtmann
2008-05-26 8:57 ` Johannes Berg
2008-05-25 12:05 ` Michael Buesch
2008-05-25 13:19 ` Marcel Holtmann
2008-05-25 13:45 ` Michael Buesch
2008-05-25 18:15 ` Marcel Holtmann
2008-05-25 18:27 ` Michael Buesch
2008-05-25 18:34 ` Marcel Holtmann
2008-05-25 14:13 ` Johannes Berg
2008-05-25 14:18 ` David Woodhouse
2008-05-25 14:22 ` Johannes Berg
2008-05-25 18:23 ` Marcel Holtmann [this message]
2008-05-25 18:39 ` Michael Buesch
2008-05-25 18:46 ` Marcel Holtmann
2008-05-25 18:53 ` Michael Buesch
2008-05-25 19:03 ` Marcel Holtmann
2008-05-25 19:21 ` Michael Buesch
2008-05-26 8:52 ` Johannes Berg
2008-05-25 17:17 ` Alexandre Oliva
2008-05-25 18:49 ` Marcel Holtmann
2008-05-25 19:53 ` Alan Cox
2008-05-26 3:30 ` Alexandre Oliva
2008-05-25 18:49 ` Michael Buesch
2008-05-25 19:01 ` Marcel Holtmann
2008-05-25 19:09 ` Michael Buesch
2008-05-26 3:13 ` Alexandre Oliva
2008-05-26 12:53 ` Michael Buesch
2008-05-26 13:08 ` Johannes Berg
2008-05-26 17:09 ` Alexandre Oliva
2008-05-26 17:11 ` Michael Buesch
2008-05-23 14:53 ` [PATCH 1/3] firmware: allow firmware files to be built into kernel image Takashi Iwai
2008-05-23 14:58 ` David Woodhouse
2008-05-23 15:19 ` Takashi Iwai
2008-05-23 15:25 ` David Woodhouse
2008-05-23 15:33 ` Alan Cox
2008-05-23 17:21 ` David Woodhouse
2008-05-23 19:14 ` David Woodhouse
2008-05-23 19:42 ` David Woodhouse
2008-05-23 20:31 ` Alan Cox
2008-05-23 21:04 ` David Woodhouse
2008-05-23 23:28 ` David Woodhouse
2008-05-23 14:56 ` Alan Cox
2008-05-23 15:11 ` David Woodhouse
2008-05-23 15:00 ` Clemens Ladisch
2008-05-23 15:20 ` David Woodhouse
2008-05-23 15:32 ` Alan Cox
2008-05-23 16:21 ` Sam Ravnborg
2008-05-23 16:37 ` David Dillow
2008-05-23 16:38 ` Lennart Sorensen
2008-05-23 16:44 ` Sam Ravnborg
2008-05-23 16:53 ` Rene Herman
2008-05-23 17:06 ` David Woodhouse
2008-05-23 17:49 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41FE0259-522B-4B9B-A75D-7B97A9FD723F@holtmann.org \
--to=marcel@holtmann.org \
--cc=Abhay_Salunke@dell.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=aoliva@redhat.com \
--cc=dwmw2@infradead.org \
--cc=johannes@sipsolutions.net \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mb@bu3sch.de \
--cc=sam@ravnborg.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®