From: "Andreas Färber" <afaerber@suse.de>
To: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
Cc: "p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"alex.g@adaptrum.com" <alex.g@adaptrum.com>,
"andre.przywara@arm.com" <andre.przywara@arm.com>,
"s.trumtrar@pengutronix.de" <s.trumtrar@pengutronix.de>,
"wens@csie.org" <wens@csie.org>,
"baoyou.xie@linaro.org" <baoyou.xie@linaro.org>,
"mcoquelin.stm32@gmail.com" <mcoquelin.stm32@gmail.com>,
"dinguyen@kernel.org" <dinguyen@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"alexandre.torgue@st.com" <alexandre.torgue@st.com>,
"maxime.ripard@free-electrons.com"
<maxime.ripard@free-electrons.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>
Subject: Re: [PATCH v3 3/5] reset: stm32: use the reset-simple driver
Date: Wed, 16 Aug 2017 14:55:52 +0200 [thread overview]
Message-ID: <41f0ff01-84d4-e26b-c3fe-52accb7e0443@suse.de> (raw)
In-Reply-To: <1502887920.2586.35.camel@synopsys.com>
Hi Eugeniy,
Am 16.08.2017 um 14:52 schrieb Eugeniy Paltsev:
> On Wed, 2017-08-16 at 11:46 +0200, Philipp Zabel wrote:
>> The reset-simple driver can be used without changes.
>>
>> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
>> [snip]
>>
>> --- a/drivers/reset/reset-simple.c
>> +++ b/drivers/reset/reset-simple.c
>> @@ -120,6 +120,7 @@ static const struct reset_simple_devdata
>> reset_simple_active_low = {
>>
>> static const struct of_device_id reset_simple_dt_ids[] = {
>> { .compatible = "altr,rst-mgr", .data =
>> &reset_simple_socfpga },
>> + { .compatible = "st,stm32-rcc", },
>> { .compatible = "allwinner,sun6i-a31-clock-reset",
>> .data = &reset_simple_active_low },
>> { /* sentinel */ },
>
> What about adding generic compatible strings for future use?
Please see 1/5 for the same discussion, raised by Andre and me.
Thanks,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2017-08-16 12:55 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-16 9:46 [PATCH v3 0/5] Unify simple reset drivers Philipp Zabel
2017-08-16 9:46 ` [PATCH v3 1/5] reset: add reset-simple to unify socfpga, stm32, sunxi, and zx2967 Philipp Zabel
2017-08-16 11:30 ` Andre Przywara
2017-08-16 12:12 ` Andreas Färber
2017-08-16 15:11 ` Philipp Zabel
2017-08-16 15:17 ` Andre Przywara
2017-08-16 16:41 ` Andreas Färber
2017-08-16 16:46 ` Andre Przywara
2017-08-16 20:46 ` Alexandru Gagniuc
2017-08-16 9:46 ` [PATCH v3 2/5] reset: socfpga: use the reset-simple driver Philipp Zabel
2017-08-16 20:46 ` Alexandru Gagniuc
2017-08-21 8:45 ` Philipp Zabel
2017-08-16 9:46 ` [PATCH v3 3/5] reset: stm32: " Philipp Zabel
2017-08-16 12:52 ` Eugeniy Paltsev
2017-08-16 12:55 ` Andreas Färber [this message]
2017-08-16 13:03 ` Andre Przywara
2017-08-16 20:50 ` Alexandru Gagniuc
2017-08-16 20:52 ` Andreas Färber
2017-08-16 20:55 ` Alexandru Gagniuc
2017-08-17 9:19 ` Andre Przywara
2017-08-21 8:38 ` Philipp Zabel
2017-08-29 8:39 ` [v3,3/5] " Gabriel FERNANDEZ
2017-08-16 9:47 ` [PATCH v3 4/5] reset: zx2967: " Philipp Zabel
2017-08-16 20:50 ` Alexandru Gagniuc
2017-08-16 9:47 ` [PATCH v3 5/5] reset: simple: read back to make sure changes are applied Philipp Zabel
2017-08-16 21:00 ` Alexandru Gagniuc
2017-08-21 8:21 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41f0ff01-84d4-e26b-c3fe-52accb7e0443@suse.de \
--to=afaerber@suse.de \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=alex.g@adaptrum.com \
--cc=alexandre.torgue@st.com \
--cc=andre.przywara@arm.com \
--cc=baoyou.xie@linaro.org \
--cc=dinguyen@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=s.trumtrar@pengutronix.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®