From: "Andreas Färber" <afaerber@suse.de>
To: Andre Przywara <andre.przywara@arm.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
linux-kernel@vger.kernel.org
Cc: Alexandru Gagniuc <alex.g@adaptrum.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Chen-Yu Tsai <wens@csie.org>, Baoyou Xie <baoyou.xie@linaro.org>,
Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
Steffen Trumtrar <s.trumtrar@pengutronix.de>,
Dinh Nguyen <dinguyen@kernel.org>,
linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de
Subject: Re: [PATCH v3 1/5] reset: add reset-simple to unify socfpga, stm32, sunxi, and zx2967
Date: Wed, 16 Aug 2017 14:12:32 +0200 [thread overview]
Message-ID: <d6b20df2-12f7-68b1-f7de-0c7f205eba13@suse.de> (raw)
In-Reply-To: <51db563d-d6e1-18f1-01c1-3fdcf8269773@arm.com>
Hi Andre,
Am 16.08.2017 um 13:30 schrieb Andre Przywara:
> On 16/08/17 10:46, Philipp Zabel wrote:
>> +/**
>> + * struct reset_simple_devdata - simple reset controller properties
>> + * @active_low: if true, bits are cleared to assert the reset. Otherwise, bits
>> + * are set to assert the reset.
>> + */
>> +struct reset_simple_devdata {
>> + bool active_low;
>> +};
>> +
>> +static const struct reset_simple_devdata reset_simple_active_low = {
>> + .active_low = true,
>> +};
>> +
>> +static const struct of_device_id reset_simple_dt_ids[] = {
>> + { .compatible = "allwinner,sun6i-a31-clock-reset",
>> + .data = &reset_simple_active_low },
>
> Can we have a additional generic compatible string here? New users of
> this driver then wouldn't need to explicitly enter their name into the
> driver, but could just use the generic name as a fallback. This would
> enable the driver without any Linux code change just by adding a DT node.
>
> compatible = "nexell,s5p6818-reset", "simple-reset";
>
> Whenever we need a quirk (now or in the future), we can add the specific
> name into this structure along with the required workarounds.
Same question about binding here. However the way it is done today, we
would also need some optional active-low property then or two different
compatible strings, as this is currently controlled via the DT matches.
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2017-08-16 12:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-16 9:46 [PATCH v3 0/5] Unify simple reset drivers Philipp Zabel
2017-08-16 9:46 ` [PATCH v3 1/5] reset: add reset-simple to unify socfpga, stm32, sunxi, and zx2967 Philipp Zabel
2017-08-16 11:30 ` Andre Przywara
2017-08-16 12:12 ` Andreas Färber [this message]
2017-08-16 15:11 ` Philipp Zabel
2017-08-16 15:17 ` Andre Przywara
2017-08-16 16:41 ` Andreas Färber
2017-08-16 16:46 ` Andre Przywara
2017-08-16 20:46 ` Alexandru Gagniuc
2017-08-16 9:46 ` [PATCH v3 2/5] reset: socfpga: use the reset-simple driver Philipp Zabel
2017-08-16 20:46 ` Alexandru Gagniuc
2017-08-21 8:45 ` Philipp Zabel
2017-08-16 9:46 ` [PATCH v3 3/5] reset: stm32: " Philipp Zabel
2017-08-16 12:52 ` Eugeniy Paltsev
2017-08-16 12:55 ` Andreas Färber
2017-08-16 13:03 ` Andre Przywara
2017-08-16 20:50 ` Alexandru Gagniuc
2017-08-16 20:52 ` Andreas Färber
2017-08-16 20:55 ` Alexandru Gagniuc
2017-08-17 9:19 ` Andre Przywara
2017-08-21 8:38 ` Philipp Zabel
2017-08-29 8:39 ` [v3,3/5] " Gabriel FERNANDEZ
2017-08-16 9:47 ` [PATCH v3 4/5] reset: zx2967: " Philipp Zabel
2017-08-16 20:50 ` Alexandru Gagniuc
2017-08-16 9:47 ` [PATCH v3 5/5] reset: simple: read back to make sure changes are applied Philipp Zabel
2017-08-16 21:00 ` Alexandru Gagniuc
2017-08-21 8:21 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6b20df2-12f7-68b1-f7de-0c7f205eba13@suse.de \
--to=afaerber@suse.de \
--cc=Eugeniy.Paltsev@synopsys.com \
--cc=alex.g@adaptrum.com \
--cc=alexandre.torgue@st.com \
--cc=andre.przywara@arm.com \
--cc=baoyou.xie@linaro.org \
--cc=dinguyen@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=s.trumtrar@pengutronix.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®