From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Praveen Teja Kundanala <praveen.teja.kundanala@amd.com>,
srinivas.kandagatla@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
michal.simek@amd.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] dt-bindings: nvmem: Add nodes for ZynqMP efuses
Date: Fri, 13 Oct 2023 12:31:30 +0200 [thread overview]
Message-ID: <42638b0a-2007-4c50-8046-6dfc33e45441@linaro.org> (raw)
In-Reply-To: <20231013101450.573-4-praveen.teja.kundanala@amd.com>
On 13/10/2023 12:14, Praveen Teja Kundanala wrote:
> Added nodes for ZynqMP specific purpose and PUF user efuses
Why?
>
> Signed-off-by: Praveen Teja Kundanala <praveen.teja.kundanala@amd.com>
> ---
> .../bindings/nvmem/xlnx,zynqmp-nvmem.yaml | 213 +++++++++++++++++-
> 1 file changed, 212 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/nvmem/xlnx,zynqmp-nvmem.yaml b/Documentation/devicetree/bindings/nvmem/xlnx,zynqmp-nvmem.yaml
> index e03ed8c32537..d2a036a80cda 100644
> --- a/Documentation/devicetree/bindings/nvmem/xlnx,zynqmp-nvmem.yaml
> +++ b/Documentation/devicetree/bindings/nvmem/xlnx,zynqmp-nvmem.yaml
> @@ -8,7 +8,7 @@ title: Zynq UltraScale+ MPSoC Non Volatile Memory interface
>
> description: |
> The ZynqMP MPSoC provides access to the hardware related data
> - like SOC revision, IDCODE.
> + like SOC revision, IDCODE and specific purpose efuses.
>
> maintainers:
> - Kalyani Akula <kalyani.akula@amd.com>
> @@ -43,6 +43,140 @@ patternProperties:
> required:
> - reg
>
> + "^efuse_dna@c$":
No, no underscores in node names. From where did you get this pattern?
Which upstream code has it?
All this and further parts are questionable. I don't understand why do
you do it.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-10-13 10:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 10:14 [PATCH 0/5] Add ZynqMP efuse access support Praveen Teja Kundanala
2023-10-13 10:14 ` [PATCH 1/5] firmware: xilinx: Add ZynqMP efuse access API Praveen Teja Kundanala
2023-10-13 10:14 ` [PATCH 2/5] dt-bindings: nvmem: Convert xlnx,zynqmp-nvmem.txt to yaml Praveen Teja Kundanala
2023-10-13 10:30 ` Krzysztof Kozlowski
2023-10-13 11:22 ` Michal Simek
2023-10-13 11:46 ` Krzysztof Kozlowski
2023-10-13 11:51 ` Michal Simek
2023-10-13 11:58 ` Krzysztof Kozlowski
2023-10-13 12:08 ` Michal Simek
2023-10-13 12:54 ` Krzysztof Kozlowski
2023-10-13 13:06 ` Michal Simek
2023-10-13 13:10 ` Krzysztof Kozlowski
2023-10-13 13:12 ` Michal Simek
2023-10-16 8:01 ` Michal Simek
2023-10-16 10:06 ` Kundanala, Praveen Teja
2023-10-13 11:09 ` Rob Herring
2023-10-13 16:23 ` Rob Herring
2023-10-13 10:14 ` [PATCH 3/5] dt-bindings: nvmem: Add nodes for ZynqMP efuses Praveen Teja Kundanala
2023-10-13 10:31 ` Krzysztof Kozlowski [this message]
2023-10-13 10:14 ` [PATCH 4/5] arm64: zynqmp: Add ZynqnMP nvmem nodes Praveen Teja Kundanala
2023-10-13 10:32 ` Krzysztof Kozlowski
2023-10-13 11:18 ` Michal Simek
2023-10-13 10:14 ` [PATCH 5/5] nvmem: zynqmp_nvmem: Add support to access efuse Praveen Teja Kundanala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42638b0a-2007-4c50-8046-6dfc33e45441@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=praveen.teja.kundanala@amd.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®