* [PATCH] soc: qcom: ocmem: Add OCMEM hardware version print
@ 2023-05-09 21:26 Luca Weiss
2023-05-09 22:34 ` Konrad Dybcio
0 siblings, 1 reply; 2+ messages in thread
From: Luca Weiss @ 2023-05-09 21:26 UTC (permalink / raw)
To: ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Konrad Dybcio, Brian Masney
Cc: linux-arm-msm, linux-kernel, Luca Weiss
It might be useful to know what hardware version of the OCMEM block the
SoC contains. Add a debug print for that.
Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
---
drivers/soc/qcom/ocmem.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/soc/qcom/ocmem.c b/drivers/soc/qcom/ocmem.c
index 199fe9872035..aa9b3c2c1322 100644
--- a/drivers/soc/qcom/ocmem.c
+++ b/drivers/soc/qcom/ocmem.c
@@ -355,6 +355,10 @@ static int ocmem_dev_probe(struct platform_device *pdev)
}
}
+ reg = ocmem_read(ocmem, OCMEM_REG_HW_VERSION);
+ dev_dbg(dev, "OCMEM hardware version: %ld.%ld.%ld\n",
+ (reg >> 28) & 0x0F, (reg >> 16) & 0xFFF, reg & 0xFFFF);
+
reg = ocmem_read(ocmem, OCMEM_REG_HW_PROFILE);
ocmem->num_ports = OCMEM_HW_PROFILE_NUM_PORTS(reg);
ocmem->num_macros = OCMEM_HW_PROFILE_NUM_MACROS(reg);
---
base-commit: ac9a78681b921877518763ba0e89202254349d1b
change-id: 20230509-ocmem-hwver-99bcb33b028b
Best regards,
--
Luca Weiss <luca@z3ntu.xyz>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] soc: qcom: ocmem: Add OCMEM hardware version print
2023-05-09 21:26 [PATCH] soc: qcom: ocmem: Add OCMEM hardware version print Luca Weiss
@ 2023-05-09 22:34 ` Konrad Dybcio
0 siblings, 0 replies; 2+ messages in thread
From: Konrad Dybcio @ 2023-05-09 22:34 UTC (permalink / raw)
To: Luca Weiss, ~postmarketos/upstreaming, phone-devel, Andy Gross,
Bjorn Andersson, Brian Masney
Cc: linux-arm-msm, linux-kernel
On 9.05.2023 23:26, Luca Weiss wrote:
> It might be useful to know what hardware version of the OCMEM block the
> SoC contains. Add a debug print for that.
>
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>
> ---
> drivers/soc/qcom/ocmem.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/soc/qcom/ocmem.c b/drivers/soc/qcom/ocmem.c
> index 199fe9872035..aa9b3c2c1322 100644
> --- a/drivers/soc/qcom/ocmem.c
> +++ b/drivers/soc/qcom/ocmem.c
> @@ -355,6 +355,10 @@ static int ocmem_dev_probe(struct platform_device *pdev)
> }
> }
>
> + reg = ocmem_read(ocmem, OCMEM_REG_HW_VERSION);
> + dev_dbg(dev, "OCMEM hardware version: %ld.%ld.%ld\n",
> + (reg >> 28) & 0x0F, (reg >> 16) & 0xFFF, reg & 0xFFFF);
Would you mind wrapping this into
#define REG_HW_VERSION_MAJ(ver) FIELD_GET(GENMASK(31, 28), ver)
etc.?
Konrad
> +
> reg = ocmem_read(ocmem, OCMEM_REG_HW_PROFILE);
> ocmem->num_ports = OCMEM_HW_PROFILE_NUM_PORTS(reg);
> ocmem->num_macros = OCMEM_HW_PROFILE_NUM_MACROS(reg);
>
> ---
> base-commit: ac9a78681b921877518763ba0e89202254349d1b
> change-id: 20230509-ocmem-hwver-99bcb33b028b
>
> Best regards,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-05-09 22:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-09 21:26 [PATCH] soc: qcom: ocmem: Add OCMEM hardware version print Luca Weiss
2023-05-09 22:34 ` Konrad Dybcio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®