* [PATCH] serial: 8250_pci: Fix EXAR feature control register constants
@ 2017-02-03 13:22 Jan Kiszka
2017-02-07 11:55 ` Andy Shevchenko
0 siblings, 1 reply; 4+ messages in thread
From: Jan Kiszka @ 2017-02-03 13:22 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Linux Kernel Mailing List
According to the XR17V352 manual, bit 4 is IrDA control and bit 5 for
485. Fortunately, no driver used them so far.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
include/uapi/linux/serial_reg.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/uapi/linux/serial_reg.h b/include/uapi/linux/serial_reg.h
index b4c0484..b1f60cb 100644
--- a/include/uapi/linux/serial_reg.h
+++ b/include/uapi/linux/serial_reg.h
@@ -366,8 +366,8 @@
#define UART_EXAR_DVID 0x8d /* Device identification */
#define UART_EXAR_FCTR 0x08 /* Feature Control Register */
-#define UART_FCTR_EXAR_IRDA 0x08 /* IrDa data encode select */
-#define UART_FCTR_EXAR_485 0x10 /* Auto 485 half duplex dir ctl */
+#define UART_FCTR_EXAR_IRDA 0x10 /* IrDa data encode select */
+#define UART_FCTR_EXAR_485 0x20 /* Auto 485 half duplex dir ctl */
#define UART_FCTR_EXAR_TRGA 0x00 /* FIFO trigger table A */
#define UART_FCTR_EXAR_TRGB 0x60 /* FIFO trigger table B */
#define UART_FCTR_EXAR_TRGC 0x80 /* FIFO trigger table C */
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] serial: 8250_pci: Fix EXAR feature control register constants
2017-02-03 13:22 [PATCH] serial: 8250_pci: Fix EXAR feature control register constants Jan Kiszka
@ 2017-02-07 11:55 ` Andy Shevchenko
2017-02-07 12:01 ` Jan Kiszka
0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2017-02-07 11:55 UTC (permalink / raw)
To: Jan Kiszka, Sudip Mukherjee; +Cc: Greg Kroah-Hartman, Linux Kernel Mailing List
+Cc Sudip
On Fri, Feb 3, 2017 at 3:22 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> According to the XR17V352 manual, bit 4 is IrDA control and bit 5 for
> 485. Fortunately, no driver used them so far.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> include/uapi/linux/serial_reg.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/uapi/linux/serial_reg.h b/include/uapi/linux/serial_reg.h
> index b4c0484..b1f60cb 100644
> --- a/include/uapi/linux/serial_reg.h
> +++ b/include/uapi/linux/serial_reg.h
> @@ -366,8 +366,8 @@
> #define UART_EXAR_DVID 0x8d /* Device identification */
>
> #define UART_EXAR_FCTR 0x08 /* Feature Control Register */
> -#define UART_FCTR_EXAR_IRDA 0x08 /* IrDa data encode select */
> -#define UART_FCTR_EXAR_485 0x10 /* Auto 485 half duplex dir ctl */
> +#define UART_FCTR_EXAR_IRDA 0x10 /* IrDa data encode select */
> +#define UART_FCTR_EXAR_485 0x20 /* Auto 485 half duplex dir ctl */
> #define UART_FCTR_EXAR_TRGA 0x00 /* FIFO trigger table A */
> #define UART_FCTR_EXAR_TRGB 0x60 /* FIFO trigger table B */
> #define UART_FCTR_EXAR_TRGC 0x80 /* FIFO trigger table C */
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] serial: 8250_pci: Fix EXAR feature control register constants
2017-02-07 11:55 ` Andy Shevchenko
@ 2017-02-07 12:01 ` Jan Kiszka
2017-02-07 12:21 ` Andy Shevchenko
0 siblings, 1 reply; 4+ messages in thread
From: Jan Kiszka @ 2017-02-07 12:01 UTC (permalink / raw)
To: Andy Shevchenko, Sudip Mukherjee
Cc: Greg Kroah-Hartman, Linux Kernel Mailing List
On 2017-02-07 12:55, Andy Shevchenko wrote:
> +Cc Sudip
>
> On Fri, Feb 3, 2017 at 3:22 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
>> According to the XR17V352 manual, bit 4 is IrDA control and bit 5 for
>> 485. Fortunately, no driver used them so far.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>> include/uapi/linux/serial_reg.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/include/uapi/linux/serial_reg.h b/include/uapi/linux/serial_reg.h
>> index b4c0484..b1f60cb 100644
>> --- a/include/uapi/linux/serial_reg.h
>> +++ b/include/uapi/linux/serial_reg.h
>> @@ -366,8 +366,8 @@
>> #define UART_EXAR_DVID 0x8d /* Device identification */
>>
>> #define UART_EXAR_FCTR 0x08 /* Feature Control Register */
>> -#define UART_FCTR_EXAR_IRDA 0x08 /* IrDa data encode select */
>> -#define UART_FCTR_EXAR_485 0x10 /* Auto 485 half duplex dir ctl */
>> +#define UART_FCTR_EXAR_IRDA 0x10 /* IrDa data encode select */
>> +#define UART_FCTR_EXAR_485 0x20 /* Auto 485 half duplex dir ctl */
>> #define UART_FCTR_EXAR_TRGA 0x00 /* FIFO trigger table A */
>> #define UART_FCTR_EXAR_TRGB 0x60 /* FIFO trigger table B */
>> #define UART_FCTR_EXAR_TRGC 0x80 /* FIFO trigger table C */
>
>
>
BTW, I recalled that Greg preferred to remove these regs from uapi. Once
I'm done with moving the fastcom exar code over to 8250_exar.c
(currently compiling...), I'll also write a patch to move these defines
in the same file.
Jan
--
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] serial: 8250_pci: Fix EXAR feature control register constants
2017-02-07 12:01 ` Jan Kiszka
@ 2017-02-07 12:21 ` Andy Shevchenko
0 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2017-02-07 12:21 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Sudip Mukherjee, Greg Kroah-Hartman, Linux Kernel Mailing List
On Tue, Feb 7, 2017 at 2:01 PM, Jan Kiszka <jan.kiszka@siemens.com> wrote:
> On 2017-02-07 12:55, Andy Shevchenko wrote:
>> +Cc Sudip
> BTW, I recalled that Greg preferred to remove these regs from uapi. Once
> I'm done with moving the fastcom exar code over to 8250_exar.c
> (currently compiling...), I'll also write a patch to move these defines
> in the same file.
Sounds like a plan!
Just Cc Sudip for your future patches. Thanks.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-02-07 12:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-03 13:22 [PATCH] serial: 8250_pci: Fix EXAR feature control register constants Jan Kiszka
2017-02-07 11:55 ` Andy Shevchenko
2017-02-07 12:01 ` Jan Kiszka
2017-02-07 12:21 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®