* [PATCH] arm64: dts: ti: k3-am69-sk: Update OSPI partitions offsets
@ 2024-08-30 9:07 Beleswar Padhi
2024-08-30 9:22 ` Nishanth Menon
0 siblings, 1 reply; 5+ messages in thread
From: Beleswar Padhi @ 2024-08-30 9:07 UTC (permalink / raw)
To: nm, vigneshr, kristo, robh, krzk+dt, conor+dt
Cc: u-kumar1, p-mantena, devicetree, linux-kernel, linux-arm-kernel
OSPI NOR flash was partitioned with a size of 1 MB for the initial
bootloader ("ospi.tiboot3"). On the AM69-SK board, boot failures were
sometimes observed when the initial bootloader size exceeded 512 KB. To
address this, the initial bootloader image has been optimized to be
smaller than 512 KB.
Therefore, limit the first OSPI partition size to 512 KB and adjust the
remaining size across the subsequent partitions.
Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
---
arch/arm64/boot/dts/ti/k3-am69-sk.dts | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/arch/arm64/boot/dts/ti/k3-am69-sk.dts b/arch/arm64/boot/dts/ti/k3-am69-sk.dts
index 1e36965a1403..641236918379 100644
--- a/arch/arm64/boot/dts/ti/k3-am69-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-am69-sk.dts
@@ -1241,27 +1241,27 @@ partitions {
partition@0 {
label = "ospi.tiboot3";
- reg = <0x0 0x100000>;
+ reg = <0x0 0x80000>;
};
- partition@100000 {
+ partition@80000 {
label = "ospi.tispl";
- reg = <0x100000 0x200000>;
+ reg = <0x80000 0x200000>;
};
- partition@300000 {
+ partition@280000 {
label = "ospi.u-boot";
- reg = <0x300000 0x400000>;
+ reg = <0x280000 0x400000>;
};
- partition@700000 {
+ partition@680000 {
label = "ospi.env";
- reg = <0x700000 0x40000>;
+ reg = <0x680000 0x40000>;
};
- partition@740000 {
+ partition@6c0000 {
label = "ospi.env.backup";
- reg = <0x740000 0x40000>;
+ reg = <0x6c0000 0x40000>;
};
partition@800000 {
--
2.34.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: ti: k3-am69-sk: Update OSPI partitions offsets
2024-08-30 9:07 [PATCH] arm64: dts: ti: k3-am69-sk: Update OSPI partitions offsets Beleswar Padhi
@ 2024-08-30 9:22 ` Nishanth Menon
2024-08-30 15:08 ` Beleswar Prasad Padhi
2024-08-30 15:15 ` Kumar, Udit
0 siblings, 2 replies; 5+ messages in thread
From: Nishanth Menon @ 2024-08-30 9:22 UTC (permalink / raw)
To: Beleswar Padhi
Cc: vigneshr, kristo, robh, krzk+dt, conor+dt, u-kumar1, p-mantena,
devicetree, linux-kernel, linux-arm-kernel
On 14:37-20240830, Beleswar Padhi wrote:
> OSPI NOR flash was partitioned with a size of 1 MB for the initial
> bootloader ("ospi.tiboot3"). On the AM69-SK board, boot failures were
> sometimes observed when the initial bootloader size exceeded 512 KB. To
Why does the boot fail when > 512MB?
> address this, the initial bootloader image has been optimized to be
> smaller than 512 KB.
>
> Therefore, limit the first OSPI partition size to 512 KB and adjust the
> remaining size across the subsequent partitions.
I am NOT a fan of redoing flash partition organization of platforms that
are already in production - all kinds of ecosystem messes happen as a
result. Alternatively - give the 512K to u-boot tispl partition and
leave all others as is - this will at least allow people's current env
to be retained.
>
> Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-am69-sk.dts | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am69-sk.dts b/arch/arm64/boot/dts/ti/k3-am69-sk.dts
> index 1e36965a1403..641236918379 100644
> --- a/arch/arm64/boot/dts/ti/k3-am69-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am69-sk.dts
> @@ -1241,27 +1241,27 @@ partitions {
>
> partition@0 {
> label = "ospi.tiboot3";
> - reg = <0x0 0x100000>;
> + reg = <0x0 0x80000>;
> };
>
> - partition@100000 {
> + partition@80000 {
> label = "ospi.tispl";
> - reg = <0x100000 0x200000>;
> + reg = <0x80000 0x200000>;
> };
>
> - partition@300000 {
> + partition@280000 {
> label = "ospi.u-boot";
> - reg = <0x300000 0x400000>;
> + reg = <0x280000 0x400000>;
> };
>
> - partition@700000 {
> + partition@680000 {
> label = "ospi.env";
> - reg = <0x700000 0x40000>;
> + reg = <0x680000 0x40000>;
> };
>
> - partition@740000 {
> + partition@6c0000 {
> label = "ospi.env.backup";
> - reg = <0x740000 0x40000>;
> + reg = <0x6c0000 0x40000>;
> };
>
> partition@800000 {
> --
> 2.34.1
>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: ti: k3-am69-sk: Update OSPI partitions offsets
2024-08-30 9:22 ` Nishanth Menon
@ 2024-08-30 15:08 ` Beleswar Prasad Padhi
2024-09-02 6:01 ` Prasanth Mantena
2024-08-30 15:15 ` Kumar, Udit
1 sibling, 1 reply; 5+ messages in thread
From: Beleswar Prasad Padhi @ 2024-08-30 15:08 UTC (permalink / raw)
To: Nishanth Menon
Cc: vigneshr, kristo, robh, krzk+dt, conor+dt, u-kumar1, p-mantena,
devicetree, linux-kernel, linux-arm-kernel
On 30-08-2024 14:52, Nishanth Menon wrote:
> On 14:37-20240830, Beleswar Padhi wrote:
>> OSPI NOR flash was partitioned with a size of 1 MB for the initial
>> bootloader ("ospi.tiboot3"). On the AM69-SK board, boot failures were
>> sometimes observed when the initial bootloader size exceeded 512 KB. To
> Why does the boot fail when > 512MB?
It is a limitation by BOOT ROM where it can not bring up the initial
bootloader when its size exceeds 512 KB in the DFU boot mode.
>
>> address this, the initial bootloader image has been optimized to be
>> smaller than 512 KB.
>>
>> Therefore, limit the first OSPI partition size to 512 KB and adjust the
>> remaining size across the subsequent partitions.
> I am NOT a fan of redoing flash partition organization of platforms that
> are already in production - all kinds of ecosystem messes happen as a
> result. Alternatively - give the 512K to u-boot tispl partition and
> leave all others as is - this will at least allow people's current env
> to be retained.
This sounds good to me. I will let Prasanth comment over this.
>
>> Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
>> ---
>> arch/arm64/boot/dts/ti/k3-am69-sk.dts | 18 +++++++++---------
>> 1 file changed, 9 insertions(+), 9 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am69-sk.dts b/arch/arm64/boot/dts/ti/k3-am69-sk.dts
>> index 1e36965a1403..641236918379 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am69-sk.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-am69-sk.dts
>> @@ -1241,27 +1241,27 @@ partitions {
>>
>> partition@0 {
>> label = "ospi.tiboot3";
>> - reg = <0x0 0x100000>;
>> + reg = <0x0 0x80000>;
>> };
>>
>> - partition@100000 {
>> + partition@80000 {
>> label = "ospi.tispl";
>> - reg = <0x100000 0x200000>;
>> + reg = <0x80000 0x200000>;
>> };
>>
>> - partition@300000 {
>> + partition@280000 {
>> label = "ospi.u-boot";
>> - reg = <0x300000 0x400000>;
>> + reg = <0x280000 0x400000>;
>> };
>>
>> - partition@700000 {
>> + partition@680000 {
>> label = "ospi.env";
>> - reg = <0x700000 0x40000>;
>> + reg = <0x680000 0x40000>;
>> };
>>
>> - partition@740000 {
>> + partition@6c0000 {
>> label = "ospi.env.backup";
>> - reg = <0x740000 0x40000>;
>> + reg = <0x6c0000 0x40000>;
>> };
>>
>> partition@800000 {
>> --
>> 2.34.1
>>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: ti: k3-am69-sk: Update OSPI partitions offsets
2024-08-30 15:08 ` Beleswar Prasad Padhi
@ 2024-09-02 6:01 ` Prasanth Mantena
0 siblings, 0 replies; 5+ messages in thread
From: Prasanth Mantena @ 2024-09-02 6:01 UTC (permalink / raw)
To: Beleswar Prasad Padhi
Cc: Nishanth Menon, vigneshr, kristo, robh, krzk+dt, conor+dt,
u-kumar1, devicetree, linux-kernel, linux-arm-kernel
On 20:38-20240830, Beleswar Prasad Padhi wrote:
>
> On 30-08-2024 14:52, Nishanth Menon wrote:
> > On 14:37-20240830, Beleswar Padhi wrote:
> > > OSPI NOR flash was partitioned with a size of 1 MB for the initial
> > > bootloader ("ospi.tiboot3"). On the AM69-SK board, boot failures were
> > > sometimes observed when the initial bootloader size exceeded 512 KB. To
> > Why does the boot fail when > 512MB?
>
>
> It is a limitation by BOOT ROM where it can not bring up the initial
> bootloader when its size exceeds 512 KB in the DFU boot mode.
>
> >
> > > address this, the initial bootloader image has been optimized to be
> > > smaller than 512 KB.
> > >
> > > Therefore, limit the first OSPI partition size to 512 KB and adjust the
> > > remaining size across the subsequent partitions.
> > I am NOT a fan of redoing flash partition organization of platforms that
> > are already in production - all kinds of ecosystem messes happen as a
> > result. Alternatively - give the 512K to u-boot tispl partition and
> > leave all others as is - this will at least allow people's current env
> > to be retained.
>
>
> This sounds good to me. I will let Prasanth comment over this.
>
We can align things in u-boot level rather than changing anything here.
This patch can be dropped Beleswar.
> >
> > > Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
> > > ---
> > > arch/arm64/boot/dts/ti/k3-am69-sk.dts | 18 +++++++++---------
> > > 1 file changed, 9 insertions(+), 9 deletions(-)
> > >
> > > diff --git a/arch/arm64/boot/dts/ti/k3-am69-sk.dts b/arch/arm64/boot/dts/ti/k3-am69-sk.dts
> > > index 1e36965a1403..641236918379 100644
> > > --- a/arch/arm64/boot/dts/ti/k3-am69-sk.dts
> > > +++ b/arch/arm64/boot/dts/ti/k3-am69-sk.dts
> > > @@ -1241,27 +1241,27 @@ partitions {
> > > partition@0 {
> > > label = "ospi.tiboot3";
> > > - reg = <0x0 0x100000>;
> > > + reg = <0x0 0x80000>;
> > > };
> > > - partition@100000 {
> > > + partition@80000 {
> > > label = "ospi.tispl";
> > > - reg = <0x100000 0x200000>;
> > > + reg = <0x80000 0x200000>;
> > > };
> > > - partition@300000 {
> > > + partition@280000 {
> > > label = "ospi.u-boot";
> > > - reg = <0x300000 0x400000>;
> > > + reg = <0x280000 0x400000>;
> > > };
> > > - partition@700000 {
> > > + partition@680000 {
> > > label = "ospi.env";
> > > - reg = <0x700000 0x40000>;
> > > + reg = <0x680000 0x40000>;
> > > };
> > > - partition@740000 {
> > > + partition@6c0000 {
> > > label = "ospi.env.backup";
> > > - reg = <0x740000 0x40000>;
> > > + reg = <0x6c0000 0x40000>;
> > > };
> > > partition@800000 {
> > > --
> > > 2.34.1
> > >
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: ti: k3-am69-sk: Update OSPI partitions offsets
2024-08-30 9:22 ` Nishanth Menon
2024-08-30 15:08 ` Beleswar Prasad Padhi
@ 2024-08-30 15:15 ` Kumar, Udit
1 sibling, 0 replies; 5+ messages in thread
From: Kumar, Udit @ 2024-08-30 15:15 UTC (permalink / raw)
To: Nishanth Menon, Beleswar Padhi
Cc: vigneshr, kristo, robh, krzk+dt, conor+dt, p-mantena, devicetree,
linux-kernel, linux-arm-kernel, u-kumar1
On 8/30/2024 2:52 PM, Nishanth Menon wrote:
> On 14:37-20240830, Beleswar Padhi wrote:
>> OSPI NOR flash was partitioned with a size of 1 MB for the initial
>> bootloader ("ospi.tiboot3"). On the AM69-SK board, boot failures were
>> sometimes observed when the initial bootloader size exceeded 512 KB. To
> Why does the boot fail when > 512MB?
>
>> address this, the initial bootloader image has been optimized to be
>> smaller than 512 KB.
>>
>> Therefore, limit the first OSPI partition size to 512 KB and adjust the
>> remaining size across the subsequent partitions.
> I am NOT a fan of redoing flash partition organization of platforms that
> are already in production - all kinds of ecosystem messes happen as a
> result. Alternatively - give the 512K to u-boot tispl partition and
> leave all others as is - this will at least allow people's current env
> to be retained.
If preference to keep same partitions, which are defined once. Then
let's align u-boot with this.
Thanks to refactor in u-boot , now AM69 and J784S4 can stay at different
config.
>
>> Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
>> ---
>> arch/arm64/boot/dts/ti/k3-am69-sk.dts | 18 +++++++++---------
>> 1 file changed, 9 insertions(+), 9 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-am69-sk.dts b/arch/arm64/boot/dts/ti/k3-am69-sk.dts
>> index 1e36965a1403..641236918379 100644
>> --- a/arch/arm64/boot/dts/ti/k3-am69-sk.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-am69-sk.dts
>> @@ -1241,27 +1241,27 @@ partitions {
>>
>> partition@0 {
>> label = "ospi.tiboot3";
>> - reg = <0x0 0x100000>;
>> + reg = <0x0 0x80000>;
>> };
>>
>> - partition@100000 {
>> + partition@80000 {
>> label = "ospi.tispl";
>> - reg = <0x100000 0x200000>;
>> + reg = <0x80000 0x200000>;
>> };
>>
>> - partition@300000 {
>> + partition@280000 {
>> label = "ospi.u-boot";
>> - reg = <0x300000 0x400000>;
>> + reg = <0x280000 0x400000>;
>> };
>>
>> - partition@700000 {
>> + partition@680000 {
>> label = "ospi.env";
>> - reg = <0x700000 0x40000>;
>> + reg = <0x680000 0x40000>;
>> };
>>
>> - partition@740000 {
>> + partition@6c0000 {
>> label = "ospi.env.backup";
>> - reg = <0x740000 0x40000>;
>> + reg = <0x6c0000 0x40000>;
>> };
>>
>> partition@800000 {
>> --
>> 2.34.1
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-09-02 6:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-30 9:07 [PATCH] arm64: dts: ti: k3-am69-sk: Update OSPI partitions offsets Beleswar Padhi
2024-08-30 9:22 ` Nishanth Menon
2024-08-30 15:08 ` Beleswar Prasad Padhi
2024-09-02 6:01 ` Prasanth Mantena
2024-08-30 15:15 ` Kumar, Udit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®