From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Arnd Bergmann <arnd@kernel.org>,
linux-sh@vger.kernel.org, Rich Felker <dalias@libc.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 4/4] sh: machvec: remove custom ioport_{un,}map()
Date: Fri, 08 Sep 2023 12:21:42 +0200 [thread overview]
Message-ID: <456ea951a34b3c599d990eddd15fee490fbaee37.camel@physik.fu-berlin.de> (raw)
In-Reply-To: <CAMuHMdVf6pBn2O61ynkdk9MDj0WiMt-12ffvpzfgL51Kz4_Jfg@mail.gmail.com>
Hi Geert!
On Fri, 2023-09-08 at 12:20 +0200, Geert Uytterhoeven wrote:
> > Why aren't you removing the function ioport_unmap(void __iomem *addr) completely
> > and just turn it into stub? Is it still referenced somewhere?
>
> Because architectures are supposed to implement it (there is no
> __weak default).
>
> An alternative would be to provide a dummy static inline, like
> e.g. m68k does:
>
> arch/m68k/include/asm/kmap.h:#define ioport_unmap ioport_unmap
> arch/m68k/include/asm/kmap.h:static inline void ioport_unmap(void __iomem *p)
> arch/m68k/include/asm/kmap.h-{
> arch/m68k/include/asm/kmap.h-}
OK, that explains it. Thanks!
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
next prev parent reply other threads:[~2023-09-08 10:23 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 18:48 [PATCH 1/4] sh: remove stale microdev board Arnd Bergmann
2023-08-02 18:48 ` [PATCH 2/4] sh: remove unused sh4-202 support Arnd Bergmann
2023-09-08 10:00 ` John Paul Adrian Glaubitz
2023-08-02 18:48 ` [PATCH 3/4] sh: remove superhyway bus support Arnd Bergmann
2023-08-03 7:58 ` D. Jeff Dionne
2023-08-03 8:44 ` John Paul Adrian Glaubitz
2023-08-03 9:19 ` Arnd Bergmann
2023-08-03 9:36 ` John Paul Adrian Glaubitz
2023-08-03 9:58 ` Arnd Bergmann
2023-09-08 10:02 ` John Paul Adrian Glaubitz
2023-08-02 18:48 ` [PATCH 4/4] sh: machvec: remove custom ioport_{un,}map() Arnd Bergmann
2023-09-08 10:10 ` John Paul Adrian Glaubitz
2023-09-08 10:20 ` Geert Uytterhoeven
2023-09-08 10:21 ` John Paul Adrian Glaubitz [this message]
2023-09-08 10:23 ` John Paul Adrian Glaubitz
2023-09-13 12:32 ` Geert Uytterhoeven
2023-09-13 14:08 ` Arnd Bergmann
2023-09-13 14:13 ` Geert Uytterhoeven
2023-09-13 14:30 ` Arnd Bergmann
2023-09-14 6:23 ` John Paul Adrian Glaubitz
2023-09-14 15:56 ` Arnd Bergmann
2023-09-15 15:41 ` Geert Uytterhoeven
2023-09-15 15:49 ` Arnd Bergmann
2023-09-21 7:45 ` John Paul Adrian Glaubitz
2023-09-21 8:52 ` Geert Uytterhoeven
2023-09-25 7:08 ` Yoshinori Sato
2023-09-25 7:36 ` Arnd Bergmann
2023-09-26 22:15 ` John Paul Adrian Glaubitz
2023-09-08 9:59 ` [PATCH 1/4] sh: remove stale microdev board John Paul Adrian Glaubitz
2023-09-09 22:06 ` John Paul Adrian Glaubitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=456ea951a34b3c599d990eddd15fee490fbaee37.camel@physik.fu-berlin.de \
--to=glaubitz@physik.fu-berlin.de \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=dalias@libc.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®