From: "Arnd Bergmann" <arnd@arndb.de>
To: "John Paul Adrian Glaubitz" <glaubitz@physik.fu-berlin.de>,
"Geert Uytterhoeven" <geert@linux-m68k.org>
Cc: "Arnd Bergmann" <arnd@kernel.org>,
linux-sh@vger.kernel.org, "Rich Felker" <dalias@libc.org>,
"Yoshinori Sato" <ysato@users.sourceforge.jp>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] sh: machvec: remove custom ioport_{un,}map()
Date: Thu, 14 Sep 2023 17:56:54 +0200 [thread overview]
Message-ID: <73cdb822-4819-4621-bbd0-de60392552b5@app.fastmail.com> (raw)
In-Reply-To: <70e9fe45ca8bbe2dec5541a0c21bee3de8f82f91.camel@physik.fu-berlin.de>
On Thu, Sep 14, 2023, at 08:23, John Paul Adrian Glaubitz wrote:
> On Wed, 2023-09-13 at 16:30 +0200, Arnd Bergmann wrote:
>> > In the meantime, there is a v2, which I wasn't aware of when I wrote
>> > my previous email, so perhaps my comment is no longer valid.
>> > "[RFC PATCH v2 00/30] Device Tree support for SH7751 based board"
>> > https://lore.kernel.org/linux-sh/cover.1694596125.git.ysato@users.sourceforge.jp
>>
>> Right, it looks like the GENERIC_IOMAP part if gone from that
>> series, and I also see that the PCI host bridge does not actually
>> map the port I/O window. That's usually fine because very few
>> drivers actually need it, and it also means that there should be
>> no need for GENERIC_IOMAP or the simpler alternative.
>>
>> The first version probably only did it accidentally, which is a
>> common mistake, and I think the ones for hexagon, m68k, and
>> mips can probably be removed as well with some simplifiations.
>>
>> x86 and ia64 want GENERIC_IOMAP because they require using
>> custom instructions for accessing IORESOURCE_IO registers,
>> but it's not really generic.
>
> Would you suggest to apply your series before or after Yoshinori's series to
> convert arch/sh to device trees? If you want it to go in before the conversion,
> could you rebase your series against v6.6-rc1?
>
> I'm asking because the current version did not apply against v6.5-rc2.
I've rebased and resent the series now, with no other changes
added in. I expect that you can apply it in either order now
if the other series no longer relies on GENERIC_IOMAP.
Arnd
next prev parent reply other threads:[~2023-09-14 15:57 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 18:48 [PATCH 1/4] sh: remove stale microdev board Arnd Bergmann
2023-08-02 18:48 ` [PATCH 2/4] sh: remove unused sh4-202 support Arnd Bergmann
2023-09-08 10:00 ` John Paul Adrian Glaubitz
2023-08-02 18:48 ` [PATCH 3/4] sh: remove superhyway bus support Arnd Bergmann
2023-08-03 7:58 ` D. Jeff Dionne
2023-08-03 8:44 ` John Paul Adrian Glaubitz
2023-08-03 9:19 ` Arnd Bergmann
2023-08-03 9:36 ` John Paul Adrian Glaubitz
2023-08-03 9:58 ` Arnd Bergmann
2023-09-08 10:02 ` John Paul Adrian Glaubitz
2023-08-02 18:48 ` [PATCH 4/4] sh: machvec: remove custom ioport_{un,}map() Arnd Bergmann
2023-09-08 10:10 ` John Paul Adrian Glaubitz
2023-09-08 10:20 ` Geert Uytterhoeven
2023-09-08 10:21 ` John Paul Adrian Glaubitz
2023-09-08 10:23 ` John Paul Adrian Glaubitz
2023-09-13 12:32 ` Geert Uytterhoeven
2023-09-13 14:08 ` Arnd Bergmann
2023-09-13 14:13 ` Geert Uytterhoeven
2023-09-13 14:30 ` Arnd Bergmann
2023-09-14 6:23 ` John Paul Adrian Glaubitz
2023-09-14 15:56 ` Arnd Bergmann [this message]
2023-09-15 15:41 ` Geert Uytterhoeven
2023-09-15 15:49 ` Arnd Bergmann
2023-09-21 7:45 ` John Paul Adrian Glaubitz
2023-09-21 8:52 ` Geert Uytterhoeven
2023-09-25 7:08 ` Yoshinori Sato
2023-09-25 7:36 ` Arnd Bergmann
2023-09-26 22:15 ` John Paul Adrian Glaubitz
2023-09-08 9:59 ` [PATCH 1/4] sh: remove stale microdev board John Paul Adrian Glaubitz
2023-09-09 22:06 ` John Paul Adrian Glaubitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73cdb822-4819-4621-bbd0-de60392552b5@app.fastmail.com \
--to=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=dalias@libc.org \
--cc=geert@linux-m68k.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®