* [PATCH] phy: ti: gmii-sel: fix mac tx internal delay for rgmii-rxid
@ 2019-10-23 14:47 Grygorii Strashko
2019-10-24 2:41 ` Florian Fainelli
0 siblings, 1 reply; 5+ messages in thread
From: Grygorii Strashko @ 2019-10-23 14:47 UTC (permalink / raw)
To: Kishon Vijay Abraham I
Cc: netdev, Sekhar Nori, linux-kernel, Grygorii Strashko
Now phy-gmii-sel will disable MAC TX internal delay for PHY interface mode
"rgmii-rxid" which is incorrect.
Hence, fix it by enabling MAC TX internal delay in the case of "rgmii-rxid"
mode.
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
drivers/phy/ti/phy-gmii-sel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/ti/phy-gmii-sel.c b/drivers/phy/ti/phy-gmii-sel.c
index a52c5bb35033..a28bd15297f5 100644
--- a/drivers/phy/ti/phy-gmii-sel.c
+++ b/drivers/phy/ti/phy-gmii-sel.c
@@ -69,11 +69,11 @@ static int phy_gmii_sel_mode(struct phy *phy, enum phy_mode mode, int submode)
break;
case PHY_INTERFACE_MODE_RGMII:
+ case PHY_INTERFACE_MODE_RGMII_RXID:
gmii_sel_mode = AM33XX_GMII_SEL_MODE_RGMII;
break;
case PHY_INTERFACE_MODE_RGMII_ID:
- case PHY_INTERFACE_MODE_RGMII_RXID:
case PHY_INTERFACE_MODE_RGMII_TXID:
gmii_sel_mode = AM33XX_GMII_SEL_MODE_RGMII;
rgmii_id = 1;
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] phy: ti: gmii-sel: fix mac tx internal delay for rgmii-rxid
2019-10-23 14:47 [PATCH] phy: ti: gmii-sel: fix mac tx internal delay for rgmii-rxid Grygorii Strashko
@ 2019-10-24 2:41 ` Florian Fainelli
2019-10-24 5:42 ` Grygorii Strashko
0 siblings, 1 reply; 5+ messages in thread
From: Florian Fainelli @ 2019-10-24 2:41 UTC (permalink / raw)
To: Grygorii Strashko, Kishon Vijay Abraham I
Cc: netdev, Sekhar Nori, linux-kernel
On 10/23/2019 7:47 AM, Grygorii Strashko wrote:
> Now phy-gmii-sel will disable MAC TX internal delay for PHY interface mode
> "rgmii-rxid" which is incorrect.
> Hence, fix it by enabling MAC TX internal delay in the case of "rgmii-rxid"
> mode.
>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Should this have a:
Fixes: 92b58b34741f ("phy: ti: introduce phy-gmii-sel driver")
--
Florian
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] phy: ti: gmii-sel: fix mac tx internal delay for rgmii-rxid
2019-10-24 2:41 ` Florian Fainelli
@ 2019-10-24 5:42 ` Grygorii Strashko
2019-10-24 6:00 ` Kishon Vijay Abraham I
2019-10-25 11:39 ` Kishon Vijay Abraham I
0 siblings, 2 replies; 5+ messages in thread
From: Grygorii Strashko @ 2019-10-24 5:42 UTC (permalink / raw)
To: Florian Fainelli, Kishon Vijay Abraham I
Cc: netdev, Sekhar Nori, linux-kernel
On 24/10/2019 05:41, Florian Fainelli wrote:
>
>
> On 10/23/2019 7:47 AM, Grygorii Strashko wrote:
>> Now phy-gmii-sel will disable MAC TX internal delay for PHY interface mode
>> "rgmii-rxid" which is incorrect.
>> Hence, fix it by enabling MAC TX internal delay in the case of "rgmii-rxid"
>> mode.
>>
>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>
> Should this have a:
>
> Fixes: 92b58b34741f ("phy: ti: introduce phy-gmii-sel driver")
>
Yes. it should.
Kishon, would you like me to re-submit or can you fix while applying?
--
Best regards,
grygorii
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] phy: ti: gmii-sel: fix mac tx internal delay for rgmii-rxid
2019-10-24 5:42 ` Grygorii Strashko
@ 2019-10-24 6:00 ` Kishon Vijay Abraham I
2019-10-25 11:39 ` Kishon Vijay Abraham I
1 sibling, 0 replies; 5+ messages in thread
From: Kishon Vijay Abraham I @ 2019-10-24 6:00 UTC (permalink / raw)
To: Grygorii Strashko, Florian Fainelli; +Cc: netdev, Sekhar Nori, linux-kernel
On 24/10/19 11:12 AM, Grygorii Strashko wrote:
>
>
> On 24/10/2019 05:41, Florian Fainelli wrote:
>>
>>
>> On 10/23/2019 7:47 AM, Grygorii Strashko wrote:
>>> Now phy-gmii-sel will disable MAC TX internal delay for PHY interface mode
>>> "rgmii-rxid" which is incorrect.
>>> Hence, fix it by enabling MAC TX internal delay in the case of "rgmii-rxid"
>>> mode.
>>>
>>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>>
>> Should this have a:
>>
>> Fixes: 92b58b34741f ("phy: ti: introduce phy-gmii-sel driver")
>>
>
> Yes. it should.
> Kishon, would you like me to re-submit or can you fix while applying?
I'll fix it while applying.
Thanks
Kishon
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] phy: ti: gmii-sel: fix mac tx internal delay for rgmii-rxid
2019-10-24 5:42 ` Grygorii Strashko
2019-10-24 6:00 ` Kishon Vijay Abraham I
@ 2019-10-25 11:39 ` Kishon Vijay Abraham I
1 sibling, 0 replies; 5+ messages in thread
From: Kishon Vijay Abraham I @ 2019-10-25 11:39 UTC (permalink / raw)
To: Grygorii Strashko, Florian Fainelli; +Cc: netdev, Sekhar Nori, linux-kernel
On 24/10/19 11:12 AM, Grygorii Strashko wrote:
>
>
> On 24/10/2019 05:41, Florian Fainelli wrote:
>>
>>
>> On 10/23/2019 7:47 AM, Grygorii Strashko wrote:
>>> Now phy-gmii-sel will disable MAC TX internal delay for PHY interface mode
>>> "rgmii-rxid" which is incorrect.
>>> Hence, fix it by enabling MAC TX internal delay in the case of "rgmii-rxid"
>>> mode.
>>>
>>> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>>
>> Should this have a:
>>
>> Fixes: 92b58b34741f ("phy: ti: introduce phy-gmii-sel driver")
>>
>
> Yes. it should.
> Kishon, would you like me to re-submit or can you fix while applying?
merged now, thanks!
-Kishon
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-10-25 11:39 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-23 14:47 [PATCH] phy: ti: gmii-sel: fix mac tx internal delay for rgmii-rxid Grygorii Strashko
2019-10-24 2:41 ` Florian Fainelli
2019-10-24 5:42 ` Grygorii Strashko
2019-10-24 6:00 ` Kishon Vijay Abraham I
2019-10-25 11:39 ` Kishon Vijay Abraham I
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome