* [PATCH -next] ASoC: simple-card-utils: remove set but not used variable ''
@ 2019-03-23 2:08 YueHaibing
[not found] ` <87a7hjitm0.wl-kuninori.morimoto.gx@renesas.com>
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: YueHaibing @ 2019-03-23 2:08 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Katsuhiro Suzuki, Kuninori Morimoto
Cc: YueHaibing, alsa-devel, linux-kernel, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
sound/soc/generic/simple-card-utils.c: In function 'asoc_simple_parse_clk':
sound/soc/generic/simple-card-utils.c:164:18: warning:
parameter 'dai_name' set but not used [-Wunused-but-set-parameter]
It's not used since commit 0580dde59438 ("ASoC: simple-card-utils: add
asoc_simple_debug_info()"), so can be removed.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
sound/soc/generic/simple-card-utils.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/sound/soc/generic/simple-card-utils.c b/sound/soc/generic/simple-card-utils.c
index 4ed68348f939..db1458a19985 100644
--- a/sound/soc/generic/simple-card-utils.c
+++ b/sound/soc/generic/simple-card-utils.c
@@ -173,10 +173,8 @@ int asoc_simple_parse_clk(struct device *dev,
* see
* soc-core.c :: snd_soc_init_multicodec()
*/
- if (dlc) {
+ if (dlc)
dai_of_node = dlc->of_node;
- dai_name = dlc->dai_name;
- }
/*
* Parse dai->sysclk come from "clocks = <&xxx>"
^ permalink raw reply [flat|nested] 6+ messages in thread[parent not found: <87a7hjitm0.wl-kuninori.morimoto.gx@renesas.com>]
* Re: [PATCH -next] ASoC: simple-card-utils: remove set but not used variable ''
[not found] ` <87a7hjitm0.wl-kuninori.morimoto.gx@renesas.com>
@ 2019-03-25 3:03 ` YueHaibing
0 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2019-03-25 3:03 UTC (permalink / raw)
To: Kuninori Morimoto
Cc: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Katsuhiro Suzuki, alsa-devel, linux-kernel, kernel-janitors
On 2019/3/25 10:31, Kuninori Morimoto wrote:
>
> Hi
>
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> sound/soc/generic/simple-card-utils.c: In function 'asoc_simple_parse_clk':
>> sound/soc/generic/simple-card-utils.c:164:18: warning:
>> parameter 'dai_name' set but not used [-Wunused-but-set-parameter]
>>
>> It's not used since commit 0580dde59438 ("ASoC: simple-card-utils: add
>> asoc_simple_debug_info()"), so can be removed.
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>
> I think dai_name parameter itself is no longer needed for this function,
> but, it will be removed if all driver switched to modern dai_link style.
> So, it is not a big deal.
>
> Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Thanks, yes, this just a code cleanup.
>
> Best regards
> ---
> Kuninori Morimoto
>
> .
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 -next] ASoC: simple-card-utils: remove set but not used variable 'dai_name'
2019-03-23 2:08 [PATCH -next] ASoC: simple-card-utils: remove set but not used variable '' YueHaibing
[not found] ` <87a7hjitm0.wl-kuninori.morimoto.gx@renesas.com>
@ 2019-03-25 3:17 ` YueHaibing
2019-03-27 14:53 ` Mukesh Ojha
2019-03-25 7:42 ` [PATCH -next] ASoC: simple-card-utils: remove set but not used variable '' Mukesh Ojha
2 siblings, 1 reply; 6+ messages in thread
From: YueHaibing @ 2019-03-25 3:17 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Jaroslav Kysela, Takashi Iwai,
Katsuhiro Suzuki, Kuninori Morimoto
Cc: YueHaibing, alsa-devel, linux-kernel, kernel-janitors
Fixes gcc '-Wunused-but-set-variable' warning:
sound/soc/generic/simple-card-utils.c: In function 'asoc_simple_parse_clk':
sound/soc/generic/simple-card-utils.c:164:18: warning:
parameter 'dai_name' set but not used [-Wunused-but-set-parameter]
It's not used since commit 0580dde59438 ("ASoC: simple-card-utils: add
asoc_simple_debug_info()"), so can be removed.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
v2: fix patch title
---
sound/soc/generic/simple-card-utils.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/sound/soc/generic/simple-card-utils.c b/sound/soc/generic/simple-card-utils.c
index 4ed68348f939..db1458a19985 100644
--- a/sound/soc/generic/simple-card-utils.c
+++ b/sound/soc/generic/simple-card-utils.c
@@ -173,10 +173,8 @@ int asoc_simple_parse_clk(struct device *dev,
* see
* soc-core.c :: snd_soc_init_multicodec()
*/
- if (dlc) {
+ if (dlc)
dai_of_node = dlc->of_node;
- dai_name = dlc->dai_name;
- }
/*
* Parse dai->sysclk come from "clocks = <&xxx>"
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2 -next] ASoC: simple-card-utils: remove set but not used variable 'dai_name'
2019-03-25 3:17 ` [PATCH v2 -next] ASoC: simple-card-utils: remove set but not used variable 'dai_name' YueHaibing
@ 2019-03-27 14:53 ` Mukesh Ojha
0 siblings, 0 replies; 6+ messages in thread
From: Mukesh Ojha @ 2019-03-27 14:53 UTC (permalink / raw)
To: YueHaibing, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Katsuhiro Suzuki, Kuninori Morimoto
Cc: alsa-devel, linux-kernel, kernel-janitors
On 3/25/2019 8:47 AM, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> sound/soc/generic/simple-card-utils.c: In function 'asoc_simple_parse_clk':
> sound/soc/generic/simple-card-utils.c:164:18: warning:
> parameter 'dai_name' set but not used [-Wunused-but-set-parameter]
>
> It's not used since commit 0580dde59438 ("ASoC: simple-card-utils: add
> asoc_simple_debug_info()"), so can be removed.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
-Mukesh
> ---
> v2: fix patch title
> ---
> sound/soc/generic/simple-card-utils.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/sound/soc/generic/simple-card-utils.c b/sound/soc/generic/simple-card-utils.c
> index 4ed68348f939..db1458a19985 100644
> --- a/sound/soc/generic/simple-card-utils.c
> +++ b/sound/soc/generic/simple-card-utils.c
> @@ -173,10 +173,8 @@ int asoc_simple_parse_clk(struct device *dev,
> * see
> * soc-core.c :: snd_soc_init_multicodec()
> */
> - if (dlc) {
> + if (dlc)
> dai_of_node = dlc->of_node;
> - dai_name = dlc->dai_name;
> - }
>
> /*
> * Parse dai->sysclk come from "clocks = <&xxx>"
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] ASoC: simple-card-utils: remove set but not used variable ''
2019-03-23 2:08 [PATCH -next] ASoC: simple-card-utils: remove set but not used variable '' YueHaibing
[not found] ` <87a7hjitm0.wl-kuninori.morimoto.gx@renesas.com>
2019-03-25 3:17 ` [PATCH v2 -next] ASoC: simple-card-utils: remove set but not used variable 'dai_name' YueHaibing
@ 2019-03-25 7:42 ` Mukesh Ojha
2019-03-25 7:58 ` YueHaibing
2 siblings, 1 reply; 6+ messages in thread
From: Mukesh Ojha @ 2019-03-25 7:42 UTC (permalink / raw)
To: YueHaibing, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Katsuhiro Suzuki, Kuninori Morimoto
Cc: alsa-devel, linux-kernel, kernel-janitors
On 3/23/2019 7:38 AM, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> sound/soc/generic/simple-card-utils.c: In function 'asoc_simple_parse_clk':
> sound/soc/generic/simple-card-utils.c:164:18: warning:
> parameter 'dai_name' set but not used [-Wunused-but-set-parameter]
>
> It's not used since commit 0580dde59438 ("ASoC: simple-card-utils: add
I am not able to find this commit
0580dde59438
> asoc_simple_debug_info()"), so can be removed.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> sound/soc/generic/simple-card-utils.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/sound/soc/generic/simple-card-utils.c b/sound/soc/generic/simple-card-utils.c
> index 4ed68348f939..db1458a19985 100644
> --- a/sound/soc/generic/simple-card-utils.c
> +++ b/sound/soc/generic/simple-card-utils.c
> @@ -173,10 +173,8 @@ int asoc_simple_parse_clk(struct device *dev,
> * see
> * soc-core.c :: snd_soc_init_multicodec()
> */
> - if (dlc) {
> + if (dlc)
> dai_of_node = dlc->of_node;
> - dai_name = dlc->dai_name;
I don't see any function like `asoc_simple_parse_clk`
but instead this `asoc_simple_card_parse_clk` and there the variable is
used.
Can you double check latest code base ?
Thanks,
Mukesh
> - }
>
> /*
> * Parse dai->sysclk come from "clocks = <&xxx>"
>
>
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH -next] ASoC: simple-card-utils: remove set but not used variable ''
2019-03-25 7:42 ` [PATCH -next] ASoC: simple-card-utils: remove set but not used variable '' Mukesh Ojha
@ 2019-03-25 7:58 ` YueHaibing
0 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2019-03-25 7:58 UTC (permalink / raw)
To: Mukesh Ojha, Liam Girdwood, Mark Brown, Jaroslav Kysela,
Takashi Iwai, Katsuhiro Suzuki, Kuninori Morimoto
Cc: alsa-devel, linux-kernel, kernel-janitors
On 2019/3/25 15:42, Mukesh Ojha wrote:
>
> On 3/23/2019 7:38 AM, YueHaibing wrote:
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> sound/soc/generic/simple-card-utils.c: In function 'asoc_simple_parse_clk':
>> sound/soc/generic/simple-card-utils.c:164:18: warning:
>> parameter 'dai_name' set but not used [-Wunused-but-set-parameter]
>>
>> It's not used since commit 0580dde59438 ("ASoC: simple-card-utils: add
>
>
> I am not able to find this commit
>
> 0580dde59438
It's now in linux-next tree.
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=0580dde59438686d60762b6da9229ebec693b94f
>
>
>> asoc_simple_debug_info()"), so can be removed.
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>> sound/soc/generic/simple-card-utils.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/sound/soc/generic/simple-card-utils.c b/sound/soc/generic/simple-card-utils.c
>> index 4ed68348f939..db1458a19985 100644
>> --- a/sound/soc/generic/simple-card-utils.c
>> +++ b/sound/soc/generic/simple-card-utils.c
>> @@ -173,10 +173,8 @@ int asoc_simple_parse_clk(struct device *dev,
>> * see
>> * soc-core.c :: snd_soc_init_multicodec()
>> */
>> - if (dlc) {
>> + if (dlc)
>> dai_of_node = dlc->of_node;
>> - dai_name = dlc->dai_name;
>
> I don't see any function like `asoc_simple_parse_clk`
>
> but instead this `asoc_simple_card_parse_clk` and there the variable is used.
>
> Can you double check latest code base ?
>
> Thanks,
> Mukesh
>
>
>> - }
>> /*
>> * Parse dai->sysclk come from "clocks = <&xxx>"
>>
>>
>>
>>
>>
>
> .
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-03-27 14:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-23 2:08 [PATCH -next] ASoC: simple-card-utils: remove set but not used variable '' YueHaibing
[not found] ` <87a7hjitm0.wl-kuninori.morimoto.gx@renesas.com>
2019-03-25 3:03 ` YueHaibing
2019-03-25 3:17 ` [PATCH v2 -next] ASoC: simple-card-utils: remove set but not used variable 'dai_name' YueHaibing
2019-03-27 14:53 ` Mukesh Ojha
2019-03-25 7:42 ` [PATCH -next] ASoC: simple-card-utils: remove set but not used variable '' Mukesh Ojha
2019-03-25 7:58 ` YueHaibing
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome