From: "Jan Beulich" <jbeulich@novell.com>
To: <shemminger@linux-foundation.org>
Cc: <bridge@lists.linux-foundation.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH] Module use count must be updated as bridges are created/destroyed
Date: Wed, 26 Sep 2007 08:53:27 +0100 [thread overview]
Message-ID: <46FA2C17.76E4.0078.0@novell.com> (raw)
Otherwise 'modprobe -r' on a module having a dependency on bridge will
implicitly unload bridge, bringing down all connectivity that was using
bridges.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
net/bridge/br_if.c | 9 +++++++++
1 file changed, 9 insertions(+)
--- linux-2.6.23-rc8/net/bridge/br_if.c 2007-09-26 09:23:54.000000000 +0200
+++ 2.6.23-rc8-bridge-module-get-put/net/bridge/br_if.c 2007-09-25 14:31:01.000000000 +0200
@@ -276,6 +276,11 @@ int br_add_bridge(const char *name)
if (!dev)
return -ENOMEM;
+ if (!try_module_get(THIS_MODULE)) {
+ free_netdev(dev);
+ return -ENOENT;
+ }
+
rtnl_lock();
if (strchr(dev->name, '%')) {
ret = dev_alloc_name(dev, dev->name);
@@ -294,6 +299,8 @@ int br_add_bridge(const char *name)
unregister_netdevice(dev);
out:
rtnl_unlock();
+ if (ret)
+ module_put(THIS_MODULE);
return ret;
}
@@ -321,6 +328,8 @@ int br_del_bridge(const char *name)
del_br(netdev_priv(dev));
rtnl_unlock();
+ if (ret == 0)
+ module_put(THIS_MODULE);
return ret;
}
next reply other threads:[~2007-09-26 7:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-26 7:53 Jan Beulich [this message]
2007-09-26 15:37 ` Stephen Hemminger
2007-09-26 21:06 ` why network devices don't do reference counting? (Re: [PATCH] Module use count must be updated as bridges are created/destroyed) Oleg Verych
2007-09-26 21:06 ` Stephen Hemminger
2007-09-26 22:18 ` Jan Engelhardt
2007-09-26 22:33 ` Stephen Hemminger
2007-09-26 22:57 ` why network devices don't do reference counting? David Miller
2007-09-27 11:54 ` why network devices don't do reference counting? (Re: [PATCH] Module use count must be updated as bridges are created/destroyed) Helge Hafting
2007-09-27 14:51 ` Stephen Hemminger
2007-09-27 14:55 ` Jan Engelhardt
2007-09-27 19:15 ` why network devices don't do reference counting? David Miller
2007-09-27 19:01 ` David Miller
[not found] ` <46FAA013.76E4.0078.0@novell.com>
[not found] ` <20070926101252.3ccbb987@freepuppy.rosehill>
2007-09-27 7:40 ` [PATCH] Module use count must be updated as bridges are created/destroyed Jan Beulich
2007-09-27 14:48 ` Stephen Hemminger
2007-09-27 15:05 ` Jan Beulich
2007-09-28 5:37 ` Herbert Xu
2007-09-28 18:11 ` Stephen Hemminger
2007-09-29 0:55 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46FA2C17.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=bridge@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome