mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jan Beulich" <jbeulich@novell.com>
To: "Stephen Hemminger" <shemminger@linux-foundation.org>
Cc: <bridge@lists.linux-foundation.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Module use count must be updated as bridges are created/destroyed
Date: Thu, 27 Sep 2007 16:05:33 +0100	[thread overview]
Message-ID: <46FBE2DD.76E4.0078.0@novell.com> (raw)
In-Reply-To: <20070927074849.074fdb88@freepuppy.rosehill>

>> >Sounds like a module utilities problem since unloading one module doesn't
>> >normally unload others.
>> 
>> I have to disagree here - 'modprobe -r' is specifically unloading all modules the
>> specified one references as long as they have a use count of zero. The
>> difference to other networking modules is that the latter normally don't export
>> symbols, and hence don't have dependent modules (and thus cannot be
>> subject of implicit unloading). Bridge does have dependents, and hence must
>> avoid implicit unloading by managing its use count.
>
>I want keep the behavior that:
>	modprobe -r bridge
>removes all bridges.  It is too useful and may already be in some user scripts.

So we have an unsolvable problem here then, unless infrastructure gets added
that allows a module to declare itself as not-implicit-unload-safe, forcing
modprobe -r to keep its hands off it. Ugly.

Jan


  reply	other threads:[~2007-09-27 15:04 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-26  7:53 Jan Beulich
2007-09-26 15:37 ` Stephen Hemminger
2007-09-26 21:06   ` why network devices don't do reference counting? (Re: [PATCH] Module use count must be updated as bridges are created/destroyed) Oleg Verych
2007-09-26 21:06     ` Stephen Hemminger
2007-09-26 22:18       ` Jan Engelhardt
2007-09-26 22:33         ` Stephen Hemminger
2007-09-26 22:57           ` why network devices don't do reference counting? David Miller
2007-09-27 11:54           ` why network devices don't do reference counting? (Re: [PATCH] Module use count must be updated as bridges are created/destroyed) Helge Hafting
2007-09-27 14:51             ` Stephen Hemminger
2007-09-27 14:55               ` Jan Engelhardt
2007-09-27 19:15                 ` why network devices don't do reference counting? David Miller
2007-09-27 19:01             ` David Miller
     [not found]   ` <46FAA013.76E4.0078.0@novell.com>
     [not found]     ` <20070926101252.3ccbb987@freepuppy.rosehill>
2007-09-27  7:40       ` [PATCH] Module use count must be updated as bridges are created/destroyed Jan Beulich
2007-09-27 14:48         ` Stephen Hemminger
2007-09-27 15:05           ` Jan Beulich [this message]
2007-09-28  5:37             ` Herbert Xu
2007-09-28 18:11               ` Stephen Hemminger
2007-09-29  0:55                 ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46FBE2DD.76E4.0078.0@novell.com \
    --to=jbeulich@novell.com \
    --cc=bridge@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shemminger@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome