From: Risto Suominen <risto.suominen@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: geert@linux-m68k.org, adaplas@pol.net,
linux-fbdev-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org,
Krzysztof Helt <krzysztof.h1@poczta.fm>
Subject: Re: [Linux-fbdev-devel] [PATCH] fb: hide cursor in graphics mode
Date: Thu, 12 Feb 2009 23:12:26 +0200 [thread overview]
Message-ID: <46e1c7760902121312o1476e734xc1fc1d6e11ce4d2e@mail.gmail.com> (raw)
In-Reply-To: <20090211142409.b88c577e.akpm@linux-foundation.org>
2009/2/12 Andrew Morton <akpm@linux-foundation.org>:
>> ---
>> The testing is done on kernel version 2.6.18.
>
> That's a truly ancient kernel. Is the patch needed on current kernels?
> Does it work correctly in current kernels?
>
It does not on 2.6.24. The patch works.
> How does the cursor get re-enabled?
>
I have not thought of that.
> Should we be calling ops->cursor() if fbcon_is_inactive() is true?
>
Maybe we shouldn't, but we must. The situation is that we are ordered
to enter graphics mode and the variable saying 'graphics' is already
set in vt_ioctl.c. fbcon_is_inactive() tests it and returns true.
The question is, whether this function is called later during normal
operation, and how often?
Risto
next prev parent reply other threads:[~2009-02-12 21:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-23 12:33 Risto Suominen
2009-01-24 8:51 ` [Linux-fbdev-devel] " Geert Uytterhoeven
2009-01-24 9:09 ` Risto Suominen
2009-01-24 13:26 ` Geert Uytterhoeven
2009-01-24 14:49 ` Risto Suominen
2009-02-10 21:37 ` Risto Suominen
2009-02-10 21:50 ` Risto Suominen
2009-02-11 12:35 ` Risto Suominen
2009-02-11 22:24 ` Andrew Morton
2009-02-12 21:12 ` Risto Suominen [this message]
2009-02-13 20:06 ` Krzysztof Helt
2009-02-22 7:15 ` Krzysztof Helt
2009-02-22 9:25 ` Risto Suominen
2009-02-22 11:20 ` Krzysztof Helt
[not found] ` <20090222164052.dd5442c4.krzysztof.h1@poczta.fm>
2009-02-23 6:53 ` Risto Suominen
2009-02-28 18:51 ` Krzysztof Helt
2009-03-01 11:50 ` Risto Suominen
2009-03-12 15:19 ` Risto Suominen
2009-03-17 21:02 ` [PATCH] fb: hide hardware cursor in graphics mode (Mach64) Krzysztof Helt
2009-03-21 22:01 ` Risto Suominen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46e1c7760902121312o1476e734xc1fc1d6e11ce4d2e@mail.gmail.com \
--to=risto.suominen@gmail.com \
--cc=adaplas@pol.net \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=krzysztof.h1@poczta.fm \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®