mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Risto Suominen <risto.suominen@gmail.com>
To: Krzysztof Helt <krzysztof.h1@poczta.fm>
Cc: adaplas@pol.net, Andrew Morton <akpm@linux-foundation.org>,
	geert@linux-m68k.org, linux-fbdev-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: Re: [Linux-fbdev-devel] [PATCH] fb: hide cursor in graphics mode
Date: Mon, 23 Feb 2009 08:53:57 +0200	[thread overview]
Message-ID: <46e1c7760902222253p34a714bao5c06b0ad4d779337@mail.gmail.com> (raw)
In-Reply-To: <20090222164052.dd5442c4.krzysztof.h1@poczta.fm>

Krzysztof, my patch is basically the same as yours. I already tried
to send it to Xorg mailing list, but did not receive any feedback.

Risto

If virtual resolution is higher than the screen (as in atyfb), and yoffset
given by the framebuffer driver happens to be non-zero (fbcon changes it on-
the-fly), Xfbdev places its image starting above the displayed part of the
framebuffer. This patch makes sure that the whole picture is visible.

Signed-off-by: Risto Suominen <Risto.Suominen@gmail.com>
---
The testing is done on version 1.1.1 and linux kernel version 2.6.18.

--- a/hw/kdrive/fbdev/fbdev.c.org       2006-07-05 21:31:39.000000000 +0300
+++ b/hw/kdrive/fbdev/fbdev.c   2009-01-18 15:42:06.000000000 +0200
@@ -215,6 +215,8 @@ fbdevScreenInitialize (KdScreenInfo *scr

     /* Now get the new screeninfo */
     ioctl (priv->fd, FBIOGET_VSCREENINFO, &priv->var);
+    /* We can get anything into yoffset if fbcon is active */
+    priv->var.yoffset = 0;
     depth = priv->var.bits_per_pixel;
     gray = priv->var.grayscale;

  parent reply	other threads:[~2009-02-23  6:54 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-23 12:33 Risto Suominen
2009-01-24  8:51 ` [Linux-fbdev-devel] " Geert Uytterhoeven
2009-01-24  9:09   ` Risto Suominen
2009-01-24 13:26     ` Geert Uytterhoeven
2009-01-24 14:49       ` Risto Suominen
2009-02-10 21:37         ` Risto Suominen
2009-02-10 21:50           ` Risto Suominen
2009-02-11 12:35             ` Risto Suominen
2009-02-11 22:24             ` Andrew Morton
2009-02-12 21:12               ` Risto Suominen
2009-02-13 20:06                 ` Krzysztof Helt
2009-02-22  7:15                   ` Krzysztof Helt
2009-02-22  9:25                     ` Risto Suominen
2009-02-22 11:20                       ` Krzysztof Helt
     [not found]                       ` <20090222164052.dd5442c4.krzysztof.h1@poczta.fm>
2009-02-23  6:53                         ` Risto Suominen [this message]
2009-02-28 18:51                           ` Krzysztof Helt
2009-03-01 11:50                             ` Risto Suominen
2009-03-12 15:19                               ` Risto Suominen
2009-03-17 21:02               ` [PATCH] fb: hide hardware cursor in graphics mode (Mach64) Krzysztof Helt
2009-03-21 22:01                 ` Risto Suominen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46e1c7760902222253p34a714bao5c06b0ad4d779337@mail.gmail.com \
    --to=risto.suominen@gmail.com \
    --cc=adaplas@pol.net \
    --cc=akpm@linux-foundation.org \
    --cc=geert@linux-m68k.org \
    --cc=krzysztof.h1@poczta.fm \
    --cc=linux-fbdev-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®