From: Risto Suominen <risto.suominen@gmail.com>
To: Krzysztof Helt <krzysztof.h1@poczta.fm>
Cc: linux-fbdev-devel@lists.sourceforge.net, geert@linux-m68k.org,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] fb: hide hardware cursor in graphics mode (Mach64)
Date: Sun, 22 Mar 2009 00:01:06 +0200 [thread overview]
Message-ID: <46e1c7760903211501s41a05aeei8bf8cf82d3261e9e@mail.gmail.com> (raw)
In-Reply-To: <20090317220251.d6fb00ff.krzysztof.h1@poczta.fm>
From: Krzysztof Helt <krzysztof.h1@wp.pl>
A hardware cursor is left enabled in
the fb_set_par() which is called when
a new console is created. This is
inconsistent with software cursor's
behaviour.
Also, this makes a hardware cursor
always visible in the Xfbdev
(Xorg kdrive) server.
Signed-off-by: Krzysztof Helt <krzysztof.h1@wp.pl>
Tested-by: Risto Suominen <Risto.Suominen@gmail.com>
---
Well done, Krzysztof. It solves the problem on my three computers
using the mach64 chip: PowerMac 5500, PowerMac G3 Beige, and a PC with
Mach64 GZ card.
drivers/video/aty/mach64_accel.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/video/aty/mach64_accel.c b/drivers/video/aty/mach64_accel.c
index a8f60c3..0cc9724 100644
--- a/drivers/video/aty/mach64_accel.c
+++ b/drivers/video/aty/mach64_accel.c
@@ -39,7 +39,8 @@ void aty_reset_engine(const struct atyfb_par *par)
{
/* reset engine */
aty_st_le32(GEN_TEST_CNTL,
- aty_ld_le32(GEN_TEST_CNTL, par) & ~GUI_ENGINE_ENABLE, par);
+ aty_ld_le32(GEN_TEST_CNTL, par) &
+ ~(GUI_ENGINE_ENABLE | HWCURSOR_ENABLE), par);
/* enable engine */
aty_st_le32(GEN_TEST_CNTL,
aty_ld_le32(GEN_TEST_CNTL, par) | GUI_ENGINE_ENABLE, par);
--
1.5.2.2
prev parent reply other threads:[~2009-03-21 22:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-23 12:33 [PATCH] fb: hide cursor in graphics mode Risto Suominen
2009-01-24 8:51 ` [Linux-fbdev-devel] " Geert Uytterhoeven
2009-01-24 9:09 ` Risto Suominen
2009-01-24 13:26 ` Geert Uytterhoeven
2009-01-24 14:49 ` Risto Suominen
2009-02-10 21:37 ` Risto Suominen
2009-02-10 21:50 ` Risto Suominen
2009-02-11 12:35 ` Risto Suominen
2009-02-11 22:24 ` Andrew Morton
2009-02-12 21:12 ` Risto Suominen
2009-02-13 20:06 ` Krzysztof Helt
2009-02-22 7:15 ` Krzysztof Helt
2009-02-22 9:25 ` Risto Suominen
2009-02-22 11:20 ` Krzysztof Helt
[not found] ` <20090222164052.dd5442c4.krzysztof.h1@poczta.fm>
2009-02-23 6:53 ` Risto Suominen
2009-02-28 18:51 ` Krzysztof Helt
2009-03-01 11:50 ` Risto Suominen
2009-03-12 15:19 ` Risto Suominen
2009-03-17 21:02 ` [PATCH] fb: hide hardware cursor in graphics mode (Mach64) Krzysztof Helt
2009-03-21 22:01 ` Risto Suominen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46e1c7760903211501s41a05aeei8bf8cf82d3261e9e@mail.gmail.com \
--to=risto.suominen@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=geert@linux-m68k.org \
--cc=krzysztof.h1@poczta.fm \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®