From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
David Vrabel <dvrabel@cantab.net>,
Shannon Zhao <shannon.zhao@linaro.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
xen-devel <xen-devel@lists.xenproject.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [Xen-devel] [GIT PULL] xen: features and fixes for 4.8-rc0
Date: Thu, 28 Jul 2016 01:09:06 +0200 [thread overview]
Message-ID: <4745197.6nnjR21Chc@vostro.rjw.lan> (raw)
In-Reply-To: <d1538de2-5819-7d67-4e6e-00564bbcbe2b@citrix.com>
On Wednesday, July 27, 2016 07:57:34 PM Andrew Cooper wrote:
> On 27/07/16 19:42, Linus Torvalds wrote:
> > On Wed, Jul 27, 2016 at 6:45 AM, David Vrabel <dvrabel@cantab.net> wrote:
> >> Shannon Zhao (16):
> >> Xen: ACPI: Hide UART used by Xen
> > So this caused a trivial conflict. No biggie, it wasn't bad and the
> > patch was acked by Rafael. However, looking at it made me somewhat
> > unhappy.
> >
> > Should the device entry in ACPI really be hidden unconditionally? In
> > particular, if we are *not* running under virtualization, it sounds
> > wrong to hide it.
> >
> > Comments? Am I missing something?
>
> The purpose of the ACPI STAO table (Status Override table, ratified in
> ACPI 6.0) is to list items elsewhere in the ACPI namespace which should
> be completely ignored. It is used in cases where it is impossible or
> prohibitive to edit the system AML.
>
> The patch itself only hides the UART if instructed to do so by the STAO
> table (last hunk).
Right.
The STAO definition document:
http://wiki.xenproject.org/mediawiki/images/0/02/Status-override-table.pdf
requires as to "operate as if that device does not exist", quite literally.
Thanks,
Rafael
next prev parent reply other threads:[~2016-07-27 23:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-27 13:45 David Vrabel
2016-07-27 18:42 ` Linus Torvalds
2016-07-27 18:57 ` [Xen-devel] " Andrew Cooper
2016-07-27 23:09 ` Rafael J. Wysocki [this message]
2016-07-27 23:18 ` Linus Torvalds
2016-07-27 23:46 ` Rafael J. Wysocki
2016-07-28 0:03 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4745197.6nnjR21Chc@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=andrew.cooper3@citrix.com \
--cc=dvrabel@cantab.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=shannon.zhao@linaro.org \
--cc=torvalds@linux-foundation.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®