[PATCH] dt-bindings: mfd: syscon: Revert renesas,r9a08g046-lvds-cmn

[PATCH] dt-bindings: mfd: syscon: Revert renesas,r9a08g046-lvds-cmn

[Krzysztof Kozlowski]

Revert commit 51284d8b1dbc ("dt-bindings: mfd: syscon: Document the
LVDS_CMN syscon for the RZ/G3L") because it is completely not matching
reality and clearly incorrect in respect of renesas,r9a08g046-lvds-cmn.

It wasn't ever build-tested by author on their DTS, either.

The documented renesas,r9a08g046-lvds-cmn compatible clearly disallows
any children and simple-mfd fallback, however its only use in original
patchset is with simple-mfd and children, so this could have never
worked.

Fixes: 51284d8b1dbc ("dt-bindings: mfd: syscon: Document the LVDS_CMN syscon for the RZ/G3L")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/mfd/syscon.yaml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
index 9c81010d5a74..e22867088063 100644
--- a/Documentation/devicetree/bindings/mfd/syscon.yaml
+++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
@@ -221,7 +221,6 @@ properties:
               - nxp,s32g3-gpr
               - qcom,apq8064-mmss-sfpb
               - qcom,apq8064-sps-sic
-              - renesas,r9a08g046-lvds-cmn
               - rockchip,px30-qos
               - rockchip,rk3036-qos
               - rockchip,rk3066-qos
-- 
2.53.0

RE: [PATCH] dt-bindings: mfd: syscon: Revert renesas,r9a08g046-lvds-cmn

[Biju Das]

Hi Krzysztof Kozlowski,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> Sent: 08 June 2026 12:55
> Subject: [PATCH] dt-bindings: mfd: syscon: Revert renesas,r9a08g046-lvds-cmn
> 
> Revert commit 51284d8b1dbc ("dt-bindings: mfd: syscon: Document the LVDS_CMN syscon for the RZ/G3L")
> because it is completely not matching reality and clearly incorrect in respect of renesas,r9a08g046-
> lvds-cmn.
> 
> It wasn't ever build-tested by author on their DTS, either.

You are wrong here.

It is tested with below DTS,

		lvds: lvds-cmn@108a0000 {
			compatible = "renesas,r9a08g046-lvds-cmn",
				     "simple-mfd", "syscon";
			reg = <0 0x108a0000 0 0x10000>;
			#address-cells = <2>;
			#size-cells = <2>;
			ranges;

			lvds0: lvds@10 {
				compatible = "renesas,r9a08g046-lvds";
				reg = <0 0x10 0 0x8>;
				clocks = <&cpg CPG_MOD R9A08G046_MIPI_DSI_PCLK>,
					 <&cpg CPG_MOD R9A08G046_LVDS_PLLCLK>,
					 <&cpg CPG_MOD R9A08G046_LVDS_CLK_DOT0>;
				clock-names = "pclk", "phyclk", "dotclk";
				resets = <&cpg R9A08G046_LVDS_RESET_N>,
				 	 <&cpg R9A08G046_MIPI_DSI_PRESET_N>,
				 	 <&cpg R9A08G046_MIPI_DSI_CMN_RSTB>,
				 	 <&cpg R9A08G046_MIPI_DSI_ARESET_N>;
				reset-names = "lvdrst", "prst", "rst", "arst";
				power-domains = <&cpg>;
				status = "disabled";

				ports {
					#address-cells = <1>;
					#size-cells = <0>;

					port@0 {
						reg = <0>;
						lvds0_in: endpoint {
							remote-endpoint = <&du_out_lvds0>;
						};
					};

					port@1 {
						reg = <1>;
						lvds_ch0: endpoint {
						};
					};
				};
			};
		};

Cheers,
Biju

Re: [PATCH] dt-bindings: mfd: syscon: Revert renesas,r9a08g046-lvds-cmn

[Krzysztof Kozlowski]

On 08/06/2026 13:59, Biju Das wrote:
> Hi Krzysztof Kozlowski,
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>> Sent: 08 June 2026 12:55
>> Subject: [PATCH] dt-bindings: mfd: syscon: Revert renesas,r9a08g046-lvds-cmn
>>
>> Revert commit 51284d8b1dbc ("dt-bindings: mfd: syscon: Document the LVDS_CMN syscon for the RZ/G3L")
>> because it is completely not matching reality and clearly incorrect in respect of renesas,r9a08g046-
>> lvds-cmn.
>>
>> It wasn't ever build-tested by author on their DTS, either.
> 
> You are wrong here.
> 
> It is tested with below DTS,

Sure, I believe you. Binding is still obviously wrong and does not match
the DTS at all.

Best regards,
Krzysztof

RE: [PATCH] dt-bindings: mfd: syscon: Revert renesas,r9a08g046-lvds-cmn

[Biju Das]

Hi Krzysztof Kozlowski,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 08 June 2026 13:12
> Subject: Re: [PATCH] dt-bindings: mfd: syscon: Revert renesas,r9a08g046-lvds-cmn
> 
> On 08/06/2026 13:59, Biju Das wrote:
> > Hi Krzysztof Kozlowski,
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> >> Sent: 08 June 2026 12:55
> >> Subject: [PATCH] dt-bindings: mfd: syscon: Revert
> >> renesas,r9a08g046-lvds-cmn
> >>
> >> Revert commit 51284d8b1dbc ("dt-bindings: mfd: syscon: Document the
> >> LVDS_CMN syscon for the RZ/G3L") because it is completely not
> >> matching reality and clearly incorrect in respect of renesas,r9a08g046- lvds-cmn.
> >>
> >> It wasn't ever build-tested by author on their DTS, either.
> >
> > You are wrong here.
> >
> > It is tested with below DTS,
> 
> Sure, I believe you. Binding is still obviously wrong and does not match the DTS at all.

You are not actually pointing to the mistake in the bindings. It is reviewed by Conor.

Cheers,
Biju

Re: [PATCH] dt-bindings: mfd: syscon: Revert renesas,r9a08g046-lvds-cmn

[Krzysztof Kozlowski]

On 08/06/2026 14:15, Biju Das wrote:
> Hi Krzysztof Kozlowski,
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@kernel.org>
>> Sent: 08 June 2026 13:12
>> Subject: Re: [PATCH] dt-bindings: mfd: syscon: Revert renesas,r9a08g046-lvds-cmn
>>
>> On 08/06/2026 13:59, Biju Das wrote:
>>> Hi Krzysztof Kozlowski,
>>>
>>>> -----Original Message-----
>>>> From: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>>>> Sent: 08 June 2026 12:55
>>>> Subject: [PATCH] dt-bindings: mfd: syscon: Revert
>>>> renesas,r9a08g046-lvds-cmn
>>>>
>>>> Revert commit 51284d8b1dbc ("dt-bindings: mfd: syscon: Document the
>>>> LVDS_CMN syscon for the RZ/G3L") because it is completely not
>>>> matching reality and clearly incorrect in respect of renesas,r9a08g046- lvds-cmn.
>>>>
>>>> It wasn't ever build-tested by author on their DTS, either.
>>>
>>> You are wrong here.
>>>
>>> It is tested with below DTS,
>>
>> Sure, I believe you. Binding is still obviously wrong and does not match the DTS at all.
> 
> You are not actually pointing to the mistake in the bindings. It is reviewed by Conor.

I described it very clear in the part of the msg YOU REMOVED.

Does not matter if it was reviewed by Conor. The patch looked correct
for our eyes when looking ALONE at this patch, I also would not spot the
issue. You as the author have the complete picture and you should see
that it is completely bogus combination of compatibles.

Best regards,
Krzysztof

RE: [PATCH] dt-bindings: mfd: syscon: Revert renesas,r9a08g046-lvds-cmn

[Biju Das]

Hi Krzysztof Kozlowski,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 08 June 2026 13:23
> Subject: Re: [PATCH] dt-bindings: mfd: syscon: Revert renesas,r9a08g046-lvds-cmn
> 
> On 08/06/2026 14:15, Biju Das wrote:
> > Hi Krzysztof Kozlowski,
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzk@kernel.org>
> >> Sent: 08 June 2026 13:12
> >> Subject: Re: [PATCH] dt-bindings: mfd: syscon: Revert
> >> renesas,r9a08g046-lvds-cmn
> >>
> >> On 08/06/2026 13:59, Biju Das wrote:
> >>> Hi Krzysztof Kozlowski,
> >>>
> >>>> -----Original Message-----
> >>>> From: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> >>>> Sent: 08 June 2026 12:55
> >>>> Subject: [PATCH] dt-bindings: mfd: syscon: Revert
> >>>> renesas,r9a08g046-lvds-cmn
> >>>>
> >>>> Revert commit 51284d8b1dbc ("dt-bindings: mfd: syscon: Document the
> >>>> LVDS_CMN syscon for the RZ/G3L") because it is completely not
> >>>> matching reality and clearly incorrect in respect of renesas,r9a08g046- lvds-cmn.
> >>>>
> >>>> It wasn't ever build-tested by author on their DTS, either.
> >>>
> >>> You are wrong here.
> >>>
> >>> It is tested with below DTS,
> >>
> >> Sure, I believe you. Binding is still obviously wrong and does not match the DTS at all.
> >
> > You are not actually pointing to the mistake in the bindings. It is reviewed by Conor.
> 
> I described it very clear in the part of the msg YOU REMOVED.
> 
> Does not matter if it was reviewed by Conor. The patch looked correct for our eyes when looking ALONE
> at this patch, I also would not spot the issue. You as the author have the complete picture and you
> should see that it is completely bogus combination of compatibles.

I missed adding r9a08g046-lvds-cmn in the top block, which skipped the DT binding checks.

Now I getting the below warnings, after adding the compatible to select block.

/home/biju/share/linux-work/linux/arch/arm64/boot/dts/renesas/r9a08g046l48-smarc.dtb: lvds-cmn@108a0000 (renesas,r9a08g046-lvds-cmn): compatible: 'oneOf' conditional failed, one must be fixed:
	['renesas,r9a08g046-lvds-cmn', 'simple-mfd', 'syscon'] is too long

For your patch,

Acked-by: Biju Das <biju.das.jz@bp.renesas.com>

So going forward, I will create [1] with the below compatible and properties.

[1] Documentation/devicetree/bindings/mfd/renesas,r9a08g046-lvds-cmn.yaml

  compatible:
    items:
      - enum:
          - renesas,r9a08g046-lvds-cmn
      - const: simple-mfd
      - const: syscon

  reg:
    maxItems: 1

  "#address-cells": true

  "#size-cells": true

  ranges: true

patternProperties:
  "^lvds@[0-9a-f]+$":
    $ref: /schemas/display/bridge/renesas,r9a08g046-lvds.yaml#

required:
  - compatible
  - reg


Cheers,
Biju

Re: [PATCH] dt-bindings: mfd: syscon: Revert renesas,r9a08g046-lvds-cmn

[Krzysztof Kozlowski]

On 08/06/2026 15:53, Biju Das wrote:
> 
>   reg:
>     maxItems: 1
> 
>   "#address-cells": true
> 
>   "#size-cells": true
> 
>   ranges: true
> 
> patternProperties:
>   "^lvds@[0-9a-f]+$":
>     $ref: /schemas/display/bridge/renesas,r9a08g046-lvds.yaml#

I commented on patch there about this - this probably should be squashed
into one device node, thus no need for simple-mfd.

Best regards,
Krzysztof

RE: [PATCH] dt-bindings: mfd: syscon: Revert renesas,r9a08g046-lvds-cmn

[Biju Das]

Hi Krzysztof Kozlowski,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 08 June 2026 14:57
> Subject: Re: [PATCH] dt-bindings: mfd: syscon: Revert renesas,r9a08g046-lvds-cmn
> 
> On 08/06/2026 15:53, Biju Das wrote:
> >
> >   reg:
> >     maxItems: 1
> >
> >   "#address-cells": true
> >
> >   "#size-cells": true
> >
> >   ranges: true
> >
> > patternProperties:
> >   "^lvds@[0-9a-f]+$":
> >     $ref: /schemas/display/bridge/renesas,r9a08g046-lvds.yaml#
> 
> I commented on patch there about this - this probably should be squashed into one device node, thus no
> need for simple-mfd.

RZ/G3L has one LVDS channel

RZ/G3E has two LVDS channel sharing common block.

For scalability we need simple-mfd.


Cheers,
Biju

Re: [PATCH] dt-bindings: mfd: syscon: Revert renesas,r9a08g046-lvds-cmn

[Krzysztof Kozlowski]

On 08/06/2026 16:04, Biju Das wrote:
> Hi Krzysztof Kozlowski,
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@kernel.org>
>> Sent: 08 June 2026 14:57
>> Subject: Re: [PATCH] dt-bindings: mfd: syscon: Revert renesas,r9a08g046-lvds-cmn
>>
>> On 08/06/2026 15:53, Biju Das wrote:
>>>
>>>   reg:
>>>     maxItems: 1
>>>
>>>   "#address-cells": true
>>>
>>>   "#size-cells": true
>>>
>>>   ranges: true
>>>
>>> patternProperties:
>>>   "^lvds@[0-9a-f]+$":
>>>     $ref: /schemas/display/bridge/renesas,r9a08g046-lvds.yaml#
>>
>> I commented on patch there about this - this probably should be squashed into one device node, thus no
>> need for simple-mfd.
> 
> RZ/G3L has one LVDS channel
> 
> RZ/G3E has two LVDS channel sharing common block.
> 
> For scalability we need simple-mfd.

If you have here only LVDS then you do not need simple-mfd. Your code
will be exactly the same, no? simple-mfd is when you have multiple
children, usually different. LVDS - one or two channel - is basically
one feature, so not really suitable for simple-mfd.

Best regards,
Krzysztof

RE: [PATCH] dt-bindings: mfd: syscon: Revert renesas,r9a08g046-lvds-cmn

[Biju Das]

Hi Krzysztof Kozlowski,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 08 June 2026 15:06
> Subject: Re: [PATCH] dt-bindings: mfd: syscon: Revert renesas,r9a08g046-lvds-cmn
> 
> On 08/06/2026 16:04, Biju Das wrote:
> > Hi Krzysztof Kozlowski,
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzk@kernel.org>
> >> Sent: 08 June 2026 14:57
> >> Subject: Re: [PATCH] dt-bindings: mfd: syscon: Revert
> >> renesas,r9a08g046-lvds-cmn
> >>
> >> On 08/06/2026 15:53, Biju Das wrote:
> >>>
> >>>   reg:
> >>>     maxItems: 1
> >>>
> >>>   "#address-cells": true
> >>>
> >>>   "#size-cells": true
> >>>
> >>>   ranges: true
> >>>
> >>> patternProperties:
> >>>   "^lvds@[0-9a-f]+$":
> >>>     $ref: /schemas/display/bridge/renesas,r9a08g046-lvds.yaml#
> >>
> >> I commented on patch there about this - this probably should be
> >> squashed into one device node, thus no need for simple-mfd.
> >
> > RZ/G3L has one LVDS channel
> >
> > RZ/G3E has two LVDS channel sharing common block.
> >
> > For scalability we need simple-mfd.
> 
> If you have here only LVDS then you do not need simple-mfd. Your code will be exactly the same, no?
> simple-mfd is when you have multiple children, usually different. LVDS - one or two channel - is
> basically one feature, so not really suitable for simple-mfd.

OK, Will drop simple-mfd.

Cheers,
Biju

Re: [PATCH] dt-bindings: mfd: syscon: Revert renesas,r9a08g046-lvds-cmn

[Krzysztof Kozlowski]

On Mon, Jun 08, 2026 at 01:55:08PM +0200, Krzysztof Kozlowski wrote:
> Revert commit 51284d8b1dbc ("dt-bindings: mfd: syscon: Document the
> LVDS_CMN syscon for the RZ/G3L") because it is completely not matching
> reality and clearly incorrect in respect of renesas,r9a08g046-lvds-cmn.
> 
> It wasn't ever build-tested by author on their DTS, either.
> 
> The documented renesas,r9a08g046-lvds-cmn compatible clearly disallows
> any children and simple-mfd fallback, however its only use in original
> patchset is with simple-mfd and children, so this could have never
> worked.
> 
> Fixes: 51284d8b1dbc ("dt-bindings: mfd: syscon: Document the LVDS_CMN syscon for the RZ/G3L")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
>  Documentation/devicetree/bindings/mfd/syscon.yaml | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
> index 9c81010d5a74..e22867088063 100644
> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml


For the record: this patch is still valid and justified, even with my
other syscon-related work.

The compatible here is not correctly documented and should be reverted.

Best regards,
Krzysztof

RE: [PATCH] dt-bindings: mfd: syscon: Revert renesas,r9a08g046-lvds-cmn

[Biju Das]

Hi Krzysztof Kozlowski,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 15 June 2026 07:10
> Subject: Re: [PATCH] dt-bindings: mfd: syscon: Revert renesas,r9a08g046-lvds-cmn
> 
> On Mon, Jun 08, 2026 at 01:55:08PM +0200, Krzysztof Kozlowski wrote:
> > Revert commit 51284d8b1dbc ("dt-bindings: mfd: syscon: Document the
> > LVDS_CMN syscon for the RZ/G3L") because it is completely not matching
> > reality and clearly incorrect in respect of renesas,r9a08g046-lvds-cmn.
> >
> > It wasn't ever build-tested by author on their DTS, either.
> >
> > The documented renesas,r9a08g046-lvds-cmn compatible clearly disallows
> > any children and simple-mfd fallback, however its only use in original
> > patchset is with simple-mfd and children, so this could have never
> > worked.
> >
> > Fixes: 51284d8b1dbc ("dt-bindings: mfd: syscon: Document the LVDS_CMN
> > syscon for the RZ/G3L")
> > Signed-off-by: Krzysztof Kozlowski
> > <krzysztof.kozlowski@oss.qualcomm.com>
> > ---
> >  Documentation/devicetree/bindings/mfd/syscon.yaml | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml
> > b/Documentation/devicetree/bindings/mfd/syscon.yaml
> > index 9c81010d5a74..e22867088063 100644
> > --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> 
> 
> For the record: this patch is still valid and justified, even with my other syscon-related work.
> 
> The compatible here is not correctly documented and should be reverted.

I agree.

Acked-by: Biju Das <biju.das.jz@bp.renesas.com>

Cheers,
Biju

Re: (subset) [PATCH] dt-bindings: mfd: syscon: Revert renesas,r9a08g046-lvds-cmn

[Lee Jones]

On Mon, 08 Jun 2026 13:55:08 +0200, Krzysztof Kozlowski wrote:
> Revert commit 51284d8b1dbc ("dt-bindings: mfd: syscon: Document the
> LVDS_CMN syscon for the RZ/G3L") because it is completely not matching
> reality and clearly incorrect in respect of renesas,r9a08g046-lvds-cmn.
> 
> It wasn't ever build-tested by author on their DTS, either.
> 
> The documented renesas,r9a08g046-lvds-cmn compatible clearly disallows
> any children and simple-mfd fallback, however its only use in original
> patchset is with simple-mfd and children, so this could have never
> worked.
> 
> [...]

Applied, thanks!

[1/1] dt-bindings: mfd: syscon: Revert renesas,r9a08g046-lvds-cmn
      commit: 4143734f197c0065bf5fce7da22f4d0eaf404753

--
Lee Jones [李琼斯]