From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Jarod Wilson <jwilson@redhat.com>
Cc: linux1394-devel@lists.sourceforge.net,
"Kristian Høgsberg" <krh@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firewire: fail open() quickly if the node doesn't exist anymore
Date: Tue, 29 Jan 2008 00:50:21 +0100 [thread overview]
Message-ID: <479E6A3D.3090201@s5r6.in-berlin.de> (raw)
In-Reply-To: <200801281732.03912.jwilson@redhat.com>
Jarod Wilson wrote:
> On Sunday 27 January 2008 12:21:56 pm Stefan Richter wrote:
>> Scenario: Process A keeps the character device file of node N open.
>> N is being unplugged. File /dev/fwN won't be destroyed as long as A
>> doesn't close it. Now, process B opens /dev/fwN as well. Previously
>> it would succeed but be unable to do any IO on it of course. With this
>> patch, process B's open() will fail immediately with -ENODEV.
> Makes perfect sense to me, no problems with it in cursory testing.
Actually I have 2nd thoughts about it. Clients should have a general
way to know that a device went away. (I.e. distinguish I/O errors from
mere stale generation from I/O errors due to the node being gone for
good.) I will check tomorrow if the ABI does this distinction already.
If yes, we don't need the patch. (But might still need improvements in
libraw1394 or/and clients to fail fast when appropriate.)
--
Stefan Richter
-=====-==--- ---= ===-=
http://arcgraph.de/sr/
next prev parent reply other threads:[~2008-01-28 23:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-27 0:05 [PATCH] firewire: fix "kobject_add failed for fw* with -EEXIST" Stefan Richter
2008-01-27 17:20 ` [PATCH update] " Stefan Richter
2008-01-27 17:21 ` [PATCH] firewire: fail open() quickly if the node doesn't exist anymore Stefan Richter
2008-01-28 22:32 ` Jarod Wilson
2008-01-28 23:50 ` Stefan Richter [this message]
2008-01-28 16:48 ` [PATCH update] firewire: fix "kobject_add failed for fw* with -EEXIST" Jarod Wilson
2008-01-28 18:54 ` Stefan Richter
2008-01-28 22:24 ` Jarod Wilson
2008-01-28 19:16 ` Stefan Richter
2008-01-28 23:31 ` Stefan Richter
2008-02-02 14:01 ` [PATCH update 2] " Stefan Richter
2008-01-28 22:30 ` [PATCH update] " Jarod Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=479E6A3D.3090201@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=jwilson@redhat.com \
--cc=krh@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®