[patch 1.2.32] WAN: merge driver retina

[patch 1.2.32] WAN: merge driver retina

[Matti Linnanvuori]

The following patch is based on linux-next:
http://pcidriver.googlegroups.com/web/retina-patch.txt?gda=Hj6V2UEAAAD9a223ZdyQxc6jQf5toR434ka3fTOuf9SStRjUQ9KuyGG1qiJ7UbTIup-M2XPURDRb8A7WwO6f6JZwMwSZaAwRMXXBcZFbXU7ojtsMSuO4sA
The build error and the warnings reported by David Miller have been fixed.

Re: [patch 1.2.32] WAN: merge driver retina

[Jeff Garzik]

Matti Linnanvuori wrote:
> The following patch is based on linux-next:
> http://pcidriver.googlegroups.com/web/retina-patch.txt?gda=Hj6V2UEAAAD9a223ZdyQxc6jQf5toR434ka3fTOuf9SStRjUQ9KuyGG1qiJ7UbTIup-M2XPURDRb8A7WwO6f6JZwMwSZaAwRMXXBcZFbXU7ojtsMSuO4sA
> The build error and the warnings reported by David Miller have been fixed.

The version I reviewed uses virt_to_bus(), which should not be used in 
modern drivers.  The DMA API should be used instead.

A couple months ago I created a 'retina' branch of 
jgarzik/netdev-2.6.git containing your latest code.  If you could send 
patches against that, that would be helpful in reviewing the 
improvements you make to the driver, and help us get this into the kernel.

	Jeff

Re: [patch v1.2.34] WAN: merge driver retina

[Matti Linnanvuori]

2008/9/14 Jeff Garzik <jgarzik@pobox.com>:
> Changes look good, but do not apply to the 'retina' branch.  Also, the
> virt_to_bus/virt_to_phys stuff should be replaced with DMA mapping API
> usage.

Actually there is one call of virt_to_phys in the patch I sent.
I don't know any way to replace virt_to_phys and still use remap_pfn_range.
If all architectures support virt_to_phys, I see no reason to replace it with
something else. The driver is legacy.

Re: [patch v1.2.34] WAN: merge driver retina

[Jeff Garzik]

Matti Linnanvuori wrote:
> 2008/9/14 Jeff Garzik <jgarzik@pobox.com>:
>> Changes look good, but do not apply to the 'retina' branch.  Also, the
>> virt_to_bus/virt_to_phys stuff should be replaced with DMA mapping API
>> usage.
> 
> Actually there is one call of virt_to_phys in the patch I sent.
> I don't know any way to replace virt_to_phys and still use remap_pfn_range.
> If all architectures support virt_to_phys, I see no reason to replace it with
> something else. The driver is legacy.

We do not merge new drivers that use deprecated APIs.

The whole point of a deprecated API is that you wish to remove it 
eventually.

	Jeff

Re: [patch v1.2.34] WAN: merge driver retina

[David Miller]

From: Jeff Garzik <jgarzik@pobox.com>
Date: Thu, 16 Oct 2008 05:34:08 -0400

> Matti Linnanvuori wrote:
> > 2008/9/14 Jeff Garzik <jgarzik@pobox.com>:
> >> Changes look good, but do not apply to the 'retina' branch.  Also, the
> >> virt_to_bus/virt_to_phys stuff should be replaced with DMA mapping API
> >> usage.
> > Actually there is one call of virt_to_phys in the patch I sent.
> > I don't know any way to replace virt_to_phys and still use remap_pfn_range.
> > If all architectures support virt_to_phys, I see no reason to replace it with
> > something else. The driver is legacy.
> 
> We do not merge new drivers that use deprecated APIs.
> 
> The whole point of a deprecated API is that you wish to remove it eventually.

Note that virt_to_phys() is not a problem.

It's only virt_to_bus() that mustn't be used.