* [PATCH] Fix undefined symbols for nommu architecture
@ 2006-02-20 4:24 Luke Yang
2006-02-20 5:42 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: Luke Yang @ 2006-02-20 4:24 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
Hi,
This is a patch to add or export some undefined symbols in nommu
architectures (mm/nommu.c). Based on latest mm-tree. Following
symbols are added: vmap, vunmap, randomize_va_space.
Signed-off-by: Luke Yang <luke.adi@gmail.com>
Index: git/linux-2.6/mm/nommu.c
===================================================================
--- git.orig/linux-2.6/mm/nommu.c 2006-02-17 17:40:34.000000000 +0800
+++ git/linux-2.6/mm/nommu.c 2006-02-20 12:09:32.000000000 +0800
@@ -57,7 +57,10 @@
EXPORT_SYMBOL(vfree);
EXPORT_SYMBOL(vmalloc_to_page);
EXPORT_SYMBOL(vmalloc_32);
+EXPORT_SYMBOL(vmap);
+EXPORT_SYMBOL(vunmap);
+int randomize_va_space = 0;
/*
* Handle all mappings that got truncated by a "truncate()"
* system call.
--
Best regards,
Luke Yang
magic.yyang@gmail.com; luke.adi@gmail.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix undefined symbols for nommu architecture
2006-02-20 4:24 [PATCH] Fix undefined symbols for nommu architecture Luke Yang
@ 2006-02-20 5:42 ` Andrew Morton
2006-02-20 5:57 ` Luke Yang
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2006-02-20 5:42 UTC (permalink / raw)
To: Luke Yang; +Cc: linux-kernel, David Howells
"Luke Yang" <luke.adi@gmail.com> wrote:
>
> Hi,
>
> This is a patch to add or export some undefined symbols in nommu
> architectures (mm/nommu.c). Based on latest mm-tree. Following
> symbols are added: vmap, vunmap, randomize_va_space.
>
> Signed-off-by: Luke Yang <luke.adi@gmail.com>
>
> Index: git/linux-2.6/mm/nommu.c
> ===================================================================
> --- git.orig/linux-2.6/mm/nommu.c 2006-02-17 17:40:34.000000000 +0800
> +++ git/linux-2.6/mm/nommu.c 2006-02-20 12:09:32.000000000 +0800
> @@ -57,7 +57,10 @@
> EXPORT_SYMBOL(vfree);
> EXPORT_SYMBOL(vmalloc_to_page);
> EXPORT_SYMBOL(vmalloc_32);
> +EXPORT_SYMBOL(vmap);
> +EXPORT_SYMBOL(vunmap);
OK.
> +int randomize_va_space = 0;
Not so sure about this one. Does randomize_va_space actually make sense in
a nommu environment? I guess we could load relocatable binaries into a
randomised place, but I'm not sure that this is implemented?
If no, then it would make more sense to do
#define randomize_va_space 0
for nommu, so the relevant code gets thrown away by the compiler.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix undefined symbols for nommu architecture
2006-02-20 5:42 ` Andrew Morton
@ 2006-02-20 5:57 ` Luke Yang
2006-02-20 6:06 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: Luke Yang @ 2006-02-20 5:57 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, David Howells
On 2/20/06, Andrew Morton <akpm@osdl.org> wrote:
> "Luke Yang" <luke.adi@gmail.com> wrote:
> >
> > Hi,
> >
> > This is a patch to add or export some undefined symbols in nommu
> > architectures (mm/nommu.c). Based on latest mm-tree. Following
> > symbols are added: vmap, vunmap, randomize_va_space.
> >
> > Signed-off-by: Luke Yang <luke.adi@gmail.com>
> >
> > Index: git/linux-2.6/mm/nommu.c
> > ===================================================================
> > --- git.orig/linux-2.6/mm/nommu.c 2006-02-17 17:40:34.000000000 +0800
> > +++ git/linux-2.6/mm/nommu.c 2006-02-20 12:09:32.000000000 +0800
> > @@ -57,7 +57,10 @@
> > EXPORT_SYMBOL(vfree);
> > EXPORT_SYMBOL(vmalloc_to_page);
> > EXPORT_SYMBOL(vmalloc_32);
> > +EXPORT_SYMBOL(vmap);
> > +EXPORT_SYMBOL(vunmap);
>
> OK.
>
> > +int randomize_va_space = 0;
>
> Not so sure about this one. Does randomize_va_space actually make sense in
> a nommu environment? I guess we could load relocatable binaries into a
> randomised place, but I'm not sure that this is implemented?
No, it doesn't make sense now. NOMMU architectures don't really use
it. I put it here just to avoid "undefined symbol" error.
>
> If no, then it would make more sense to do
>
> #define randomize_va_space 0
Yes, this is much better. Do I need to resend a new patch?
>
> for nommu, so the relevant code gets thrown away by the compiler.
>
--
Best regards,
Luke Yang
magic.yyang@gmail.com; luke.adi@gmail.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Fix undefined symbols for nommu architecture
2006-02-20 5:57 ` Luke Yang
@ 2006-02-20 6:06 ` Andrew Morton
0 siblings, 0 replies; 4+ messages in thread
From: Andrew Morton @ 2006-02-20 6:06 UTC (permalink / raw)
To: Luke Yang; +Cc: linux-kernel, dhowells
"Luke Yang" <luke.adi@gmail.com> wrote:
>
> > Not so sure about this one. Does randomize_va_space actually make sense in
> > a nommu environment? I guess we could load relocatable binaries into a
> > randomised place, but I'm not sure that this is implemented?
> No, it doesn't make sense now. NOMMU architectures don't really use
> it. I put it here just to avoid "undefined symbol" error.
> >
> > If no, then it would make more sense to do
> >
> > #define randomize_va_space 0
> Yes, this is much better. Do I need to resend a new patch?
Yes please - I'm not set up to compile any nommu architectures.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-02-20 6:08 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-02-20 4:24 [PATCH] Fix undefined symbols for nommu architecture Luke Yang
2006-02-20 5:42 ` Andrew Morton
2006-02-20 5:57 ` Luke Yang
2006-02-20 6:06 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®