Re: [Patch v6] dt-bindings: media: s5p-mfc: convert bindings to json-schema

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 09/03/2023 09:48, Aakarsh Jain wrote:
>>> won't fit here.
>>> Since IOMMUs maxItems is 2 here for Exynos4. Giving maxItems:2 alone
>> will also break the bindings. Thanks why suggested
>>>          iommus:
>>>            minItems: 1
>>>            maxItems: 2
>>
>> Are you sure you are putting this in correct place? This is if:then for
>> Exynos3250, isn't it?
>>
> Its not only for Exynos3250, its along with Exynos4 since their clock properties are same
> allOf:
>   - if:
>       properties:
>         compatible:
>           contains:
>             enum:
>               - samsung,mfc-v5        #Exynos4
>               - samsung,exynos3250-mfc
>     then:
>       properties:
>         clocks:
>           maxItems: 2
>         clock-names:
>           items:
>             - const: mfc
>             - const: sclk_mfc
>         iommus:
>           minItems: 1
>           maxItems: 2
> 
> or do I keep different if:then condition for both Exynos3250 and Exynos4 for IOMMUs property ?

Yes, they should be split into two if-then.


Best regards,
Krzysztof