From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Aakarsh Jain <aakarsh.jain@samsung.com>,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Cc: m.szyprowski@samsung.com, andrzej.hajda@intel.com,
mchehab@kernel.org, hverkuil-cisco@xs4all.nl,
ezequiel@vanguardiasur.com.ar, jernej.skrabec@gmail.com,
benjamin.gaignard@collabora.com,
krzysztof.kozlowski+dt@linaro.org, stanimir.varbanov@linaro.org,
dillon.minfei@gmail.com, david.plowman@raspberrypi.com,
mark.rutland@arm.com, robh+dt@kernel.org, krzk+dt@kernel.org,
andi@etezian.org, alim.akhtar@samsung.com,
aswani.reddy@samsung.com, pankaj.dubey@samsung.com
Subject: Re: [Patch v6] dt-bindings: media: s5p-mfc: convert bindings to json-schema
Date: Thu, 9 Mar 2023 07:45:23 +0100 [thread overview]
Message-ID: <9b93849d-d4a4-67ba-e8a0-ee6c7209bd65@linaro.org> (raw)
In-Reply-To: <046b01d94d1a$418146a0$c483d3e0$@samsung.com>
On 02/03/2023 16:18, Aakarsh Jain wrote:
>>
>> iommus:
>> maxItems: 1
>> iommu-names: false
>>
> I am getting compilation errors with above property set and its breaking the bindings.
> If we see these two nodes in dtsi files.
> mfc: codec@13400000 {
> compatible = "samsung,mfc-v5";
> ..
> iommus = <&sysmmu_mfc_l>, <&sysmmu_mfc_r>;
> iommu-names = "left", "right";
> }
> And
> mfc: codec@13400000 {
> compatible = "samsung,exynos3250-mfc", "samsung,mfc-v7";
> reg = <0x13400000 0x10000>;
> ...
> iommus = <&sysmmu_mfc>;
> };
> There is no iommu-names property for compatible "samsung,exynos3250-mfc, samsung,mfc-v7", that’s why I kept
> iommus:
> minItems: 1
> maxItems: 2
> I would even go with below if you agree?
> iommus:
> minItems: 1
> maxItems: 2
> iommus-names: false
No, I don't agree. Why do you need two IOMMUs for Exynos3250?
>
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-03-09 6:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230301035153epcas5p40f576188a9a69835c1050135219a3720@epcas5p4.samsung.com>
2023-03-01 3:51 ` Aakarsh Jain
2023-03-02 8:37 ` Krzysztof Kozlowski
2023-03-02 15:18 ` Aakarsh Jain
2023-03-09 6:45 ` Krzysztof Kozlowski [this message]
2023-03-09 7:22 ` Aakarsh Jain
2023-03-09 8:10 ` Krzysztof Kozlowski
2023-03-09 8:48 ` Aakarsh Jain
2023-03-10 9:08 ` Krzysztof Kozlowski
2023-03-13 3:56 ` Aakarsh Jain
2023-03-13 6:44 ` Krzysztof Kozlowski
2023-03-09 5:38 ` Aakarsh Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b93849d-d4a4-67ba-e8a0-ee6c7209bd65@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=aakarsh.jain@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=andi@etezian.org \
--cc=andrzej.hajda@intel.com \
--cc=aswani.reddy@samsung.com \
--cc=benjamin.gaignard@collabora.com \
--cc=david.plowman@raspberrypi.com \
--cc=devicetree@vger.kernel.org \
--cc=dillon.minfei@gmail.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jernej.skrabec@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=mchehab@kernel.org \
--cc=pankaj.dubey@samsung.com \
--cc=robh+dt@kernel.org \
--cc=stanimir.varbanov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®