Re: [Patch v6] dt-bindings: media: s5p-mfc: convert bindings to json-schema

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 09/03/2023 08:22, Aakarsh Jain wrote:
> 
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
>> Sent: 09 March 2023 12:15
>> To: Aakarsh Jain <aakarsh.jain@samsung.com>; linux-arm-
>> kernel@lists.infradead.org; linux-media@vger.kernel.org; linux-
>> kernel@vger.kernel.org; devicetree@vger.kernel.org
>> Cc: m.szyprowski@samsung.com; andrzej.hajda@intel.com;
>> mchehab@kernel.org; hverkuil-cisco@xs4all.nl;
>> ezequiel@vanguardiasur.com.ar; jernej.skrabec@gmail.com;
>> benjamin.gaignard@collabora.com; krzysztof.kozlowski+dt@linaro.org;
>> stanimir.varbanov@linaro.org; dillon.minfei@gmail.com;
>> david.plowman@raspberrypi.com; mark.rutland@arm.com;
>> robh+dt@kernel.org; krzk+dt@kernel.org; andi@etezian.org;
>> alim.akhtar@samsung.com; aswani.reddy@samsung.com;
>> pankaj.dubey@samsung.com
>> Subject: Re: [Patch v6] dt-bindings: media: s5p-mfc: convert bindings to json-
>> schema
>>
>> On 02/03/2023 16:18, Aakarsh Jain wrote:
>>>>
>>>> iommus:
>>>>   maxItems: 1
>>>> iommu-names: false
>>>>
>>> I am getting compilation errors with above property set and its breaking the
>> bindings.
>>> If we see these two nodes in dtsi files.
>>>                mfc: codec@13400000 {
>>>                         compatible = "samsung,mfc-v5"; ..
>>>                         iommus = <&sysmmu_mfc_l>, <&sysmmu_mfc_r>;
>>>                         iommu-names = "left", "right"; } And
>>>               mfc: codec@13400000 {
>>>                         compatible = "samsung,exynos3250-mfc", "samsung,mfc-v7";
>>>                         reg = <0x13400000 0x10000>; ...
>>>                         iommus = <&sysmmu_mfc>;
>>>                 };
>>> There is no iommu-names property for compatible "samsung,exynos3250-
>> mfc, samsung,mfc-v7", that’s why I kept
>>>         iommus:
>>>           minItems: 1
>>>           maxItems: 2
>>> I would even go with below if you agree?
>>>         iommus:
>>>           minItems: 1
>>>           maxItems: 2
>>>         iommus-names: false
>>
>> No, I don't agree. Why do you need two IOMMUs for Exynos3250?
>>>
> Here IOMMUs minItems:1 is meant for Exynos3250 while IOMMUs maxItems:2 meant for samsung,mfc-v5(Exynos 4).
> As you suggested 
> iommus:
>   maxItems: 1
> iommu-names: false
> 
> won't fit here.
> Since IOMMUs maxItems is 2 here for Exynos4. Giving maxItems:2 alone will also break the bindings. Thanks why suggested
>          iommus:
>            minItems: 1
>            maxItems: 2

Are you sure you are putting this in correct place? This is if:then for
Exynos3250, isn't it?

Best regards,
Krzysztof