Re: [PATCH RFT 7/7] firewire: sbp2: add workarounds for 2nd and 3rd generation iPods

[Stefan Richter <stefanr@s5r6.in-berlin.de>]

Alan Stern wrote:
> On Thu, 29 Jan 2009, Stefan Richter wrote:
>> Obviously they changed something in Ubuntu 8.10 which suddenly made 3rd
>> gen iPods vulnerable too.  If the report is accurate, then this is /not/
>> the READ CAPACITY 10 issue where device's capacity report is off by one.
>> (The reported capacity without workaround is an even number and thus
>> possibly correct.)
> 
> Don't make that assumption.  One of the small number of devices which 
> really did have an odd number of sectors was an early iPod.

Ah, interesting.

(Jarod, didn't you see OS X report the same size on that 3rd gen. iPod
as Linux without quirk flag, or did I dream this?  In any case this
could of course simply mean that OS X uses a wrongly reported size...)

>>  Rather, this is apparently the kind of the bug where
>> an access which includes the last sector corrupts some state in the
>> firmware, causing the firmware to error out on subsequent accesses.  The
>> actual IO errors in the reporter's log happen at low LBAs, not at LBAs
>> at the end.
> 
> Are you aware of the last_sector_bug flag?  It prevents sectors near 
> the end of the device from being accessed using anything other than 
> single-sector reads or writes.  Some devices don't like it if, for 
> example, you do a 2-sector read that includes the last sector.

Now that you mention it I do remember.  I would need to ask the reporter
of the Ubuntu bug who has a fully working 3rd gen iPod (unlike Jarod's
3rd gen iPod which doesn't work reliably anymore) to compile a kernel
from patched sources if I really wanted to investigate whether the
last_sector_bug flag fixes the issue too.  The fix_capacity flag can be
easily enabled for FireWire disks by users of binary kernel packages at
runtime, so that's what I had the reporter try.

Hmm, I'm beginning to suspect that I should duplicate usb-storage's

	if (sdev->type == TYPE_DISK)
		sdev->last_sector_bug = 1;

into the FireWire drivers.  There aren't any fundamental downsides to
this, are there?

>> Now, what does OS X do with those iPods?  I don't know.  Maybe they have
>> quirks lists like we do.  There could be something to be found in the
>> Darwin sources.  But I consider it more likely that OS X simply does not
>> do the kind of accesses that Linux does which tend to crash all those
>> crap firmwares left and right.
>>
>> Evidently, at least popular Windows incarnations don't do such accesses,
>> at least not in normal usage.  Otherwise this class of firmware bugs
>> could simply not exist in mass market devices.
> 
> Linux uses the last-sector accesses to check whether or not the device 
> is part of a RAID.  Apparently Windows and OS X don't support the kinds 
> of RAID that need this.

Or they don't support these kinds of RAID over certain transports like
USB and FireWire...?
-- 
Stefan Richter
-=====-==--= ---= ===-=
http://arcgraph.de/sr/