From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Jarod Wilson <jarod@redhat.com>
Cc: linux1394-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org,
"Kristian Høgsberg" <krh@bitplanet.net>
Subject: Re: [PATCH RFT 7/7] firewire: sbp2: add workarounds for 2nd and 3rd generation iPods
Date: Thu, 29 Jan 2009 00:11:32 +0100 (CET) [thread overview]
Message-ID: <tkrat.8899c8be7878fd1f@s5r6.in-berlin.de> (raw)
In-Reply-To: <200901281718.41873.jarod@redhat.com>
Jarod Wilson wrote:
> On Saturday 24 January 2009 13:46:44 Stefan Richter wrote:
>> - Do 2nd and 3rd gen. iPods actually have a model_id == 0, or do they
>> have in fact no model_id at all?
>
> So far as I can decipher (using Kristian's csr-dump utility), they really
> do have model_id == 0.
If model_id weren't there, the older ieee1394/sbp2 driver would log
model_id 0 (and match against quirks list entries with ID 0), while
firewire-sbp2 logs model_id 0xff000000 (which is an impossible value and
thus indicates to those who want to write a new quirks list entry that
there is actually no model_id...). I will soon push the patch which
makes sbp2 behave like firewire-sbp2 in this regard, to eliminate a
potential source of conflicting user reports.
--
Stefan Richter
-=====-==--= ---= ===-=
http://arcgraph.de/sr/
next prev parent reply other threads:[~2009-01-28 23:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-24 18:41 [PATCH 0/7] ieee1394 + firewire: misc sbp2 updates Stefan Richter
2009-01-24 18:42 ` [PATCH 1/7] firewire: sbp2: fix payload limit at S1600 and S3200 Stefan Richter
2009-01-24 18:42 ` [PATCH 2/7] firewire: sbp2: define some magic numbers as macros Stefan Richter
2009-01-24 18:43 ` [PATCH 3/7] ieee1394: sbp2: fix payload limit at S1600 and S3200 Stefan Richter
2009-01-24 18:44 ` [PATCH 4/7] ieee1394: sbp2: don't assume zero model_id or firmware_revision if there is none Stefan Richter
2009-01-24 18:45 ` [PATCH 5/7] ieee1394: sbp2: follow up on "ieee1394: inherit ud vendor_id from node vendor_id" Stefan Richter
2009-01-24 18:45 ` [PATCH RFT 6/7] ieee1394: sbp2: add workarounds for 2nd and 3rd generation iPods Stefan Richter
2009-01-24 22:29 ` Stefan Richter
2009-01-24 18:46 ` [PATCH RFT 7/7] firewire: " Stefan Richter
2009-01-28 22:18 ` Jarod Wilson
2009-01-28 22:25 ` Jarod Wilson
2009-01-28 23:11 ` [PATCH revised] " Stefan Richter
2009-01-28 23:13 ` [PATCH revised] ieee1394: " Stefan Richter
2009-01-29 3:21 ` Jarod Wilson
2009-01-29 3:20 ` [PATCH revised] firewire: " Jarod Wilson
2009-01-28 23:11 ` Stefan Richter [this message]
2009-01-29 3:18 ` [PATCH RFT 7/7] " Jarod Wilson
2009-01-29 20:09 ` Stefan Richter
2009-01-29 20:40 ` Alan Stern
2009-01-29 21:28 ` Stefan Richter
2009-01-29 22:38 ` Alan Stern
2009-01-30 15:16 ` Jarod Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tkrat.8899c8be7878fd1f@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=jarod@redhat.com \
--cc=krh@bitplanet.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®