mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] init: change EXPERT from menuconfig to config to remove an empty menu
@ 2011-04-26  1:00 Peter Foley
  2011-04-26  1:37 ` [PATCH] init: restore the EXPERT kconfig menu Randy Dunlap
  0 siblings, 1 reply; 2+ messages in thread
From: Peter Foley @ 2011-04-26  1:00 UTC (permalink / raw)
  To: linux-kernel

This patch changes CONFIG_EXPERT from a menuconfig to a config
because it no longer has any child items and is therefore an empty menu.

Signed-off-by: Peter Foley <pefoley2@verizon.net>
---
 init/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/init/Kconfig b/init/Kconfig
index 56240e7..332a2b3 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -916,7 +916,7 @@ config SYSCTL
 config ANON_INODES
 	bool

-menuconfig EXPERT
+config EXPERT
 	bool "Configure standard kernel features (expert users)"
 	help
 	  This option allows certain base kernel options and settings
-- 
1.7.5.rc1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH] init: restore the EXPERT kconfig menu
  2011-04-26  1:00 [PATCH] init: change EXPERT from menuconfig to config to remove an empty menu Peter Foley
@ 2011-04-26  1:37 ` Randy Dunlap
  0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2011-04-26  1:37 UTC (permalink / raw)
  To: pefoley2, David Rientjes; +Cc: linux-kernel, akpm, torvalds

On Mon, 25 Apr 2011 21:00:03 -0400 Peter Foley wrote:

> This patch changes CONFIG_EXPERT from a menuconfig to a config
> because it no longer has any child items and is therefore an empty menu.
> 
> Signed-off-by: Peter Foley <pefoley2@verizon.net>
> ---
>  init/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/init/Kconfig b/init/Kconfig
> index 56240e7..332a2b3 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -916,7 +916,7 @@ config SYSCTL
>  config ANON_INODES
>  	bool
> 
> -menuconfig EXPERT
> +config EXPERT
>  	bool "Configure standard kernel features (expert users)"
>  	help
>  	  This option allows certain base kernel options and settings
> -- 

NAK.  Just restore the EXPERT menu.  Patch below.

---
From: Randy Dunlap <randy.dunlap@oracle.com>

Restore the EXPERT menu list -- don't inject a symbol (EMBEDDED)
that does not depend on EXPERT into the list.

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: David Rientjes <rientjes@google.com>
---
 init/Kconfig |   16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

--- lnx-2639-rc4.orig/init/Kconfig
+++ lnx-2639-rc4/init/Kconfig
@@ -924,14 +924,6 @@ menuconfig EXPERT
           environments which can tolerate a "non-standard" kernel.
           Only use this if you really know what you are doing.
 
-config EMBEDDED
-	bool "Embedded system"
-	select EXPERT
-	help
-	  This option should be enabled if compiling the kernel for
-	  an embedded system so certain expert options are available
-	  for configuration.
-
 config UID16
 	bool "Enable 16-bit UID system calls" if EXPERT
 	depends on ARM || BLACKFIN || CRIS || FRV || H8300 || X86_32 || M68K || (S390 && !64BIT) || SUPERH || SPARC32 || (SPARC64 && COMPAT) || UML || (X86_64 && IA32_EMULATION)
@@ -1104,6 +1096,14 @@ config AIO
           by some high performance threaded applications. Disabling
           this option saves about 7k.
 
+config EMBEDDED
+	bool "Embedded system"
+	select EXPERT
+	help
+	  This option should be enabled if compiling the kernel for
+	  an embedded system so certain expert options are available
+	  for configuration.
+
 config HAVE_PERF_EVENTS
 	bool
 	help

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-04-26  1:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-04-26  1:00 [PATCH] init: change EXPERT from menuconfig to config to remove an empty menu Peter Foley
2011-04-26  1:37 ` [PATCH] init: restore the EXPERT kconfig menu Randy Dunlap

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome